Patchwork xfstests: only run generic/300 on filesystems supporting fallocate()

login
register
mail settings
Submitter Eric Whitney
Date Aug. 23, 2013, 8:41 p.m.
Message ID <20130823204132.GB3778@wallace>
Download mbox | patch
Permalink /patch/269557/
State Not Applicable
Headers show

Comments

Eric Whitney - Aug. 23, 2013, 8:41 p.m.
Generic/300 fails when run on a test filesystem that does not support
fallocate(), as in the case of an ext4 filesystem created without the
extent feature.  It uses fio's falloc ioengine to generate part of its
I/O load.

Verify that the test filesystem supports fallocate() before proceeding
with the test.  Also, delete any pre-existing test output to avoid
confusion with old results.

Signed-off-by: Eric Whitney <enwlinux@gmail.com>
---
 tests/generic/300 |    3 +++
 1 file changed, 3 insertions(+)

Patch

diff --git a/tests/generic/300 b/tests/generic/300
index 7c60728..1ac763b 100755
--- a/tests/generic/300
+++ b/tests/generic/300
@@ -43,6 +43,9 @@  _supported_fs generic
 _supported_os Linux
 _need_to_be_root
 _require_scratch
+_require_xfs_io_falloc
+
+rm -f $seqres.full
 
 NUM_JOBS=$((4*LOAD_FACTOR))
 BLK_DEV_SIZE=`blockdev --getsz $SCRATCH_DEV`