From patchwork Fri Aug 23 13:30:52 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lei Li X-Patchwork-Id: 269454 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id CFD3B2C009C for ; Fri, 23 Aug 2013 23:34:19 +1000 (EST) Received: from localhost ([::1]:37004 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCrVK-00046B-5u for incoming@patchwork.ozlabs.org; Fri, 23 Aug 2013 09:34:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47697) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCrTy-0002XO-Uq for qemu-devel@nongnu.org; Fri, 23 Aug 2013 09:33:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCrTq-0000nZ-2R for qemu-devel@nongnu.org; Fri, 23 Aug 2013 09:32:54 -0400 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:38047) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCrTj-0000fX-Us for qemu-devel@nongnu.org; Fri, 23 Aug 2013 09:32:45 -0400 Received: from /spool/local by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 23 Aug 2013 23:21:51 +1000 Received: from d23dlp01.au.ibm.com (202.81.31.203) by e23smtp01.au.ibm.com (202.81.31.207) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 23 Aug 2013 23:21:48 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 238D92CE8052 for ; Fri, 23 Aug 2013 23:32:15 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7NDGBS662390484 for ; Fri, 23 Aug 2013 23:16:14 +1000 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r7NDWAfN007818 for ; Fri, 23 Aug 2013 23:32:10 +1000 Received: from localhost.localdomain ([9.77.182.28]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id r7NDW5ug007752; Fri, 23 Aug 2013 23:32:09 +1000 From: Lei Li To: qemu-devel@nongnu.org Date: Fri, 23 Aug 2013 21:30:52 +0800 Message-Id: <1377264653-31031-2-git-send-email-lilei@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.7.6 In-Reply-To: <1377264653-31031-1-git-send-email-lilei@linux.vnet.ibm.com> References: <1377264653-31031-1-git-send-email-lilei@linux.vnet.ibm.com> X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13082313-1618-0000-0000-000004813695 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 202.81.31.143 Cc: pbonzini@redhat.com, mrhines@linux.vnet.ibm.com, anthony@codemonkey.ws, Lei Li Subject: [Qemu-devel] [PATCH resend 2/3] savevm: fix wrong error set by ram_control_load_hook() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org It should set negative error value if there has been an error. Signed-off-by: Lei Li Reviewed-By: Michael R. Hines --- savevm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/savevm.c b/savevm.c index 95a11f9..a0be109 100644 --- a/savevm.c +++ b/savevm.c @@ -649,7 +649,7 @@ void ram_control_after_iterate(QEMUFile *f, uint64_t flags) void ram_control_load_hook(QEMUFile *f, uint64_t flags) { - int ret = 0; + int ret = -EINVAL; if (f->ops->hook_ram_load) { ret = f->ops->hook_ram_load(f, f->opaque, flags);