Patchwork [1/2,SRU,Raring/Quantal] x86 thermal: Delete power-limit-notification console messages

login
register
mail settings
Submitter Tim Gardner
Date Aug. 23, 2013, 12:41 p.m.
Message ID <1377261689-4843-1-git-send-email-tim.gardner@canonical.com>
Download mbox | patch
Permalink /patch/269443/
State New
Headers show

Comments

Tim Gardner - Aug. 23, 2013, 12:41 p.m.
From: Fenghua Yu <fenghua.yu@intel.com>

BugLink: http://bugs.launchpad.net/bugs/1215748

Package power limits are common on some systems under some conditions --
so printing console messages when limits are reached
causes unnecessary customer concern and support calls.

Note that even with these console messages gone,
the events can still be observed via system counters:

$ grep TRM /proc/interrupts

Shows total thermal interrupts, which includes both power
limit notifications and thermal throttling interrupts.

$ grep . /sys/devices/system/cpu/cpu*/thermal_throttle/*

Will show what caused those interrupts, core and package
throttling and power limit notifications.

https://bugzilla.kernel.org/show_bug.cgi?id=36182

Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
(cherry picked from commit c81147483e525e4a471d581877d7d634591246e1)
---
 arch/x86/kernel/cpu/mcheck/therm_throt.c |    9 ---------
 1 file changed, 9 deletions(-)
Stefan Bader - Aug. 23, 2013, 1:25 p.m.
Was already wondering about this defaults usefulness...
Stefan Bader - Aug. 23, 2013, 1:28 p.m.

Stefan Bader - Aug. 23, 2013, 1:31 p.m.
Ok oviously I failed to end up on the wrong one second time...
Tim Gardner - Aug. 23, 2013, 3:04 p.m.

Patch

diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
index 47a1870..68fa890 100644
--- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
+++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
@@ -181,11 +181,6 @@  static int therm_throt_process(bool new_event, int event, int level)
 				this_cpu,
 				level == CORE_LEVEL ? "Core" : "Package",
 				state->count);
-		else
-			printk(KERN_CRIT "CPU%d: %s power limit notification (total events = %lu)\n",
-				this_cpu,
-				level == CORE_LEVEL ? "Core" : "Package",
-				state->count);
 		return 1;
 	}
 	if (old_event) {
@@ -193,10 +188,6 @@  static int therm_throt_process(bool new_event, int event, int level)
 			printk(KERN_INFO "CPU%d: %s temperature/speed normal\n",
 				this_cpu,
 				level == CORE_LEVEL ? "Core" : "Package");
-		else
-			printk(KERN_INFO "CPU%d: %s power limit normal\n",
-				this_cpu,
-				level == CORE_LEVEL ? "Core" : "Package");
 		return 1;
 	}