Patchwork mtd cs553x_nand: use kzalloc() instead of memset

login
register
mail settings
Submitter Dan Carpenter
Date Aug. 23, 2013, 9:51 a.m.
Message ID <20130823095145.GQ31293@elgon.mountain>
Download mbox | patch
Permalink /patch/269414/
State Accepted
Commit 8e7fd23686b49c186a15343c82a0a54c3a406234
Headers show

Comments

Dan Carpenter - Aug. 23, 2013, 9:51 a.m.
It's cleaner to use kzalloc() instead of zeroing out in a separate call
to memset().

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Brian Norris - Aug. 24, 2013, 4:54 a.m.
On Fri, Aug 23, 2013 at 12:51:45PM +0300, Dan Carpenter wrote:
> It's cleaner to use kzalloc() instead of zeroing out in a separate call
> to memset().
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied to l2-mtd.git. Thanks!

Brian

Patch

diff --git a/drivers/mtd/nand/cs553x_nand.c b/drivers/mtd/nand/cs553x_nand.c
index 2cdeab8..d469a9a 100644
--- a/drivers/mtd/nand/cs553x_nand.c
+++ b/drivers/mtd/nand/cs553x_nand.c
@@ -197,7 +197,7 @@  static int __init cs553x_init_one(int cs, int mmio, unsigned long adr)
 	}
 
 	/* Allocate memory for MTD device structure and private data */
-	new_mtd = kmalloc(sizeof(struct mtd_info) + sizeof(struct nand_chip), GFP_KERNEL);
+	new_mtd = kzalloc(sizeof(struct mtd_info) + sizeof(struct nand_chip), GFP_KERNEL);
 	if (!new_mtd) {
 		printk(KERN_WARNING "Unable to allocate CS553X NAND MTD device structure.\n");
 		err = -ENOMEM;
@@ -207,10 +207,6 @@  static int __init cs553x_init_one(int cs, int mmio, unsigned long adr)
 	/* Get pointer to private data */
 	this = (struct nand_chip *)(&new_mtd[1]);
 
-	/* Initialize structures */
-	memset(new_mtd, 0, sizeof(struct mtd_info));
-	memset(this, 0, sizeof(struct nand_chip));
-
 	/* Link the private data with the MTD structure */
 	new_mtd->priv = this;
 	new_mtd->owner = THIS_MODULE;