Patchwork [-next] mtd: ofpart: use for_each_child_of_node() macro

login
register
mail settings
Submitter Wei Yongjun
Date Aug. 23, 2013, 3:04 a.m.
Message ID <CAPgLHd_zSXzRWGgQUzsmsM4beiTFKoWtcic6QmJdxhfBvNEZYg@mail.gmail.com>
Download mbox | patch
Permalink /patch/269268/
State Accepted
Commit 60ea89e22aa5de529d0fdb9de07504afa8e5d4b0
Headers show

Comments

Wei Yongjun - Aug. 23, 2013, 3:04 a.m.
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Use for_each_child_of_node() macro instead of open coding it.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/mtd/ofpart.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Huang Shijie - Aug. 23, 2013, 7:42 a.m.
于 2013年08月23日 11:04, Wei Yongjun 写道:
> From: Wei Yongjun<yongjun_wei@trendmicro.com.cn>
>
> Use for_each_child_of_node() macro instead of open coding it.
>
> Signed-off-by: Wei Yongjun<yongjun_wei@trendmicro.com.cn>
> ---
>   drivers/mtd/ofpart.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c
> index 7843a44..d64f8c3 100644
> --- a/drivers/mtd/ofpart.c
> +++ b/drivers/mtd/ofpart.c
> @@ -43,9 +43,8 @@ static int parse_ofpart_partitions(struct mtd_info *master,
>   		return 0;
>
>   	/* First count the subnodes */
> -	pp = NULL;
>   	nr_parts = 0;
> -	while ((pp = of_get_next_child(node, pp))) {
> +	for_each_child_of_node(node,  pp) {
>   		if (node_has_compatible(pp))
>   			continue;
>
> @@ -59,9 +58,8 @@ static int parse_ofpart_partitions(struct mtd_info *master,
>   	if (!*pparts)
>   		return -ENOMEM;
>
> -	pp = NULL;
>   	i = 0;
> -	while ((pp = of_get_next_child(node, pp))) {
> +	for_each_child_of_node(node,  pp) {
>   		const __be32 *reg;
>   		int len;
>   		int a_cells, s_cells;
Acked-by: Huang Shijie <b32955@freescale.com>
Brian Norris - Aug. 24, 2013, 5:10 a.m.
On Fri, Aug 23, 2013 at 11:04:27AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> Use for_each_child_of_node() macro instead of open coding it.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Pushed to l2-mtd.git. Thanks!

Brian

Patch

diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c
index 7843a44..d64f8c3 100644
--- a/drivers/mtd/ofpart.c
+++ b/drivers/mtd/ofpart.c
@@ -43,9 +43,8 @@  static int parse_ofpart_partitions(struct mtd_info *master,
 		return 0;
 
 	/* First count the subnodes */
-	pp = NULL;
 	nr_parts = 0;
-	while ((pp = of_get_next_child(node, pp))) {
+	for_each_child_of_node(node,  pp) {
 		if (node_has_compatible(pp))
 			continue;
 
@@ -59,9 +58,8 @@  static int parse_ofpart_partitions(struct mtd_info *master,
 	if (!*pparts)
 		return -ENOMEM;
 
-	pp = NULL;
 	i = 0;
-	while ((pp = of_get_next_child(node, pp))) {
+	for_each_child_of_node(node,  pp) {
 		const __be32 *reg;
 		int len;
 		int a_cells, s_cells;