Patchwork [net-next,v2,7/8] i40e: sysfs and debugfs interfaces

login
register
mail settings
Submitter Jeff Kirsher
Date Aug. 23, 2013, 2:15 a.m.
Message ID <1377224142-25160-8-git-send-email-jeffrey.t.kirsher@intel.com>
Download mbox | patch
Permalink /patch/269259/
State Changes Requested
Delegated to: David Miller
Headers show

Comments

Jeff Kirsher - Aug. 23, 2013, 2:15 a.m.
From: Jesse Brandeburg <jesse.brandeburg@intel.com>

This driver includes a debugfs interface for developers to get more hardware
information in real-time.

This patch also includes a sysfs interface for root users to use to help
configure/view some of the internal parameters of the device.

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Shannon Nelson <shannon.nelson@intel.com>
CC: PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com>
CC: e1000-devel@lists.sourceforge.net
Tested-by: Kavindya Deegala <kavindya.s.deegala@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
v1: this is the initial submittal
v2: address upstream comments
    remove memory allocation error messages
    remove block_tx_timeout
    use rntl_link_stats64
    32 bit fixes
    misc internally generated fixes
---
 drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 2234 ++++++++++++++++++++++++
 drivers/net/ethernet/intel/i40e/i40e_sysfs.c   |  627 +++++++
 2 files changed, 2861 insertions(+)
 create mode 100644 drivers/net/ethernet/intel/i40e/i40e_debugfs.c
 create mode 100644 drivers/net/ethernet/intel/i40e/i40e_sysfs.c

Patch

diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
new file mode 100644
index 0000000..d31b6bd
--- /dev/null
+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
@@ -0,0 +1,2234 @@ 
+/*******************************************************************************
+
+  Intel Ethernet Controller XL710 Family Linux Driver
+  Copyright(c) 2013 Intel Corporation.
+
+  This program is free software; you can redistribute it and/or modify it
+  under the terms and conditions of the GNU General Public License,
+  version 2, as published by the Free Software Foundation.
+
+  This program is distributed in the hope it will be useful, but WITHOUT
+  ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+  FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+  more details.
+
+  You should have received a copy of the GNU General Public License along with
+  this program; if not, write to the Free Software Foundation, Inc.,
+  51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
+
+  The full GNU General Public License is included in this distribution in
+  the file called "COPYING".
+
+  Contact Information:
+  e1000-devel Mailing List <e1000-devel@lists.sourceforge.net>
+  Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
+
+*******************************************************************************/
+
+
+#ifdef CONFIG_DEBUG_FS
+
+/****************************************************************
+ * debugfs support
+ *
+ * Experiments in exporting data
+ *
+ ****************************************************************/
+
+#include <linux/fs.h>
+#include <linux/debugfs.h>
+
+#include "i40e.h"
+
+static struct dentry *i40e_dbg_root;
+
+/**
+ * i40e_dbg_find_vsi - searches for the vsi with the given seid
+ * @pf - the pf structure to search for the vsi
+ * @seid - seid of the vsi it is searching for
+ **/
+static struct i40e_vsi *i40e_dbg_find_vsi(struct i40e_pf *pf, int seid)
+{
+	int i;
+	if (seid < 0)
+		dev_info(&pf->pdev->dev, "%s: %d: bad seid\n", __func__, seid);
+	else
+		for (i = 0; i < pf->hw.func_caps.num_vsis; i++)
+			if (pf->vsi[i] && (pf->vsi[i]->seid == seid))
+				return pf->vsi[i];
+
+	return NULL;
+}
+
+/**
+ * i40e_dbg_find_veb - searches for the veb with the given seid
+ * @pf - the pf structure to search for the veb
+ * @seid - seid of the veb it is searching for
+ **/
+static struct i40e_veb *i40e_dbg_find_veb(struct i40e_pf *pf, int seid)
+{
+	int i;
+
+	if ((seid < I40E_BASE_VEB_SEID) ||
+	    (seid > (I40E_BASE_VEB_SEID + I40E_MAX_VEB)))
+		dev_info(&pf->pdev->dev, "%s: %d: bad seid\n", __func__, seid);
+	else
+		for (i = 0; i < I40E_MAX_VEB; i++)
+			if (pf->veb[i] && pf->veb[i]->seid == seid)
+				return pf->veb[i];
+	return NULL;
+}
+
+
+/**************************************************************
+ * dump
+ * The dump entry in debugfs is for getting a data snapshow of
+ * the driver's current configuration and runtime details.
+ * When the filesystem entry is written, a snapshot is taken.
+ * When the entry is read, the most recent snapshot data is dumped.
+ **************************************************************/
+static char *i40e_dbg_dump_buf;
+static ssize_t i40e_dbg_dump_data_len;
+static ssize_t i40e_dbg_dump_buffer_len;
+
+/**
+ * i40e_dbg_dump_read - read the dump data
+ * @filp: the opened file
+ * @buffer: where to write the data for the user to read
+ * @count: the size of the user's buffer
+ * @ppos: file position offset
+ **/
+static ssize_t i40e_dbg_dump_read(struct file *filp, char __user *buffer,
+				    size_t count, loff_t *ppos)
+{
+	int bytes_not_copied;
+	int len;
+
+	/* is *ppos bigger than the available data? */
+	if (*ppos >= i40e_dbg_dump_data_len || i40e_dbg_dump_buf == NULL)
+		return 0;
+
+	/* be sure to not read beyond the end of available data */
+	len = min_t(int, count, (i40e_dbg_dump_data_len - *ppos));
+
+	bytes_not_copied = copy_to_user(buffer, &i40e_dbg_dump_buf[*ppos], len);
+	if (bytes_not_copied < 0)
+		return bytes_not_copied;
+
+	*ppos += len;
+	return len;
+}
+
+/**
+ * i40e_dbg_prep_dump_buf
+ * @pf: the pf we're working with
+ * @buflen: the desired buffer length
+ *
+ * Return positive if success, 0 if failed
+ **/
+static int i40e_dbg_prep_dump_buf(struct i40e_pf *pf, int buflen)
+{
+	/* if not already big enough, prep for re alloc */
+	if (i40e_dbg_dump_buffer_len && i40e_dbg_dump_buffer_len < buflen) {
+		kfree(i40e_dbg_dump_buf);
+		i40e_dbg_dump_buffer_len = 0;
+		i40e_dbg_dump_buf = NULL;
+	}
+
+	/* get a new buffer if needed */
+	if (i40e_dbg_dump_buf == NULL) {
+		i40e_dbg_dump_buf = kzalloc(buflen, GFP_KERNEL);
+		if (i40e_dbg_dump_buf != NULL) {
+			i40e_dbg_dump_buffer_len = buflen;
+			dev_info(&pf->pdev->dev,
+				 "%s: i40e_dbg_dump_buffer_len = %d\n",
+				 __func__, (int)i40e_dbg_dump_buffer_len);
+		}
+	}
+
+	return i40e_dbg_dump_buffer_len;
+}
+
+/**
+ * i40e_dbg_dump_write - trigger a datadump snapshot
+ * @filp: the opened file
+ * @buffer: where to find the user's data
+ * @count: the length of the user's data
+ * @ppos: file position offset
+ **/
+/* Any write clears the stats */
+static ssize_t i40e_dbg_dump_write(struct file *filp,
+				     const char __user *buffer,
+				     size_t count, loff_t *ppos)
+{
+	struct i40e_pf *pf = filp->private_data;
+	long seid = -1;
+	int i, ret;
+	int buflen = 0;
+	int bytes_not_copied;
+	char dump_request_buf[16];
+	bool seid_found = false;
+	int len;
+	u8 *p;
+
+	/* don't allow partial writes */
+	if (*ppos != 0)
+		return 0;
+	if (count >= sizeof(dump_request_buf))
+		return -ENOSPC;
+
+	bytes_not_copied = copy_from_user(dump_request_buf, buffer, count);
+	if (bytes_not_copied < 0)
+		return bytes_not_copied;
+	if (bytes_not_copied > 0)
+		count -= bytes_not_copied;
+	dump_request_buf[count] = '\0';
+
+	/* decode the SEID given to be dumped */
+	ret = kstrtol(dump_request_buf, 0, &seid);
+	if (ret < 0) {
+		dev_info(&pf->pdev->dev, "%s: bad seid value '%s'\n",
+			 __func__, dump_request_buf);
+	} else if (seid == 0) {
+		seid_found = true;
+
+		kfree(i40e_dbg_dump_buf);
+		i40e_dbg_dump_buffer_len = 0;
+		i40e_dbg_dump_data_len = 0;
+		i40e_dbg_dump_buf = NULL;
+		dev_info(&pf->pdev->dev, "%s: debug buffer freed\n", __func__);
+
+	} else if (seid == pf->pf_seid || seid == 1) {
+		seid_found = true;
+
+		buflen = sizeof(struct i40e_pf);
+		buflen += (sizeof(struct i40e_aq_desc)
+		     * (pf->hw.aq.num_arq_entries + pf->hw.aq.num_asq_entries));
+
+		if (i40e_dbg_prep_dump_buf(pf, buflen)) {
+			p = i40e_dbg_dump_buf;
+
+			len = sizeof(struct i40e_pf);
+			memcpy(p, pf, len);
+			p += len;
+
+			len = (sizeof(struct i40e_aq_desc)
+					* pf->hw.aq.num_asq_entries);
+			memcpy(p, pf->hw.aq.asq.desc, len);
+			p += len;
+
+			len = (sizeof(struct i40e_aq_desc)
+					* pf->hw.aq.num_arq_entries);
+			memcpy(p, pf->hw.aq.arq.desc, len);
+			p += len;
+
+			i40e_dbg_dump_data_len = buflen;
+			dev_info(&pf->pdev->dev,
+				 "%s: PF seid %ld dumped %d bytes\n",
+				 __func__, seid, (int)i40e_dbg_dump_data_len);
+		}
+	} else if (seid >= I40E_BASE_VSI_SEID) {
+		struct i40e_vsi *vsi = NULL;
+		struct i40e_mac_filter *f;
+		int filter_count = 0;
+
+		mutex_lock(&pf->switch_mutex);
+		vsi = i40e_dbg_find_vsi(pf, seid);
+		if (!vsi) {
+			mutex_unlock(&pf->switch_mutex);
+			goto write_exit;
+		}
+
+		buflen = sizeof(struct i40e_vsi);
+		buflen += sizeof(struct i40e_q_vector) * vsi->num_q_vectors;
+		buflen += sizeof(struct i40e_ring) * 2 * vsi->num_queue_pairs;
+		buflen += sizeof(struct i40e_tx_buffer) * vsi->num_queue_pairs;
+		buflen += sizeof(struct i40e_rx_buffer) * vsi->num_queue_pairs;
+		list_for_each_entry(f, &vsi->mac_filter_list, list)
+			filter_count++;
+		buflen += sizeof(struct i40e_mac_filter) * filter_count;
+
+		if (i40e_dbg_prep_dump_buf(pf, buflen)) {
+
+			p = i40e_dbg_dump_buf;
+			seid_found = true;
+
+			len = sizeof(struct i40e_vsi);
+			memcpy(p, vsi, len);
+			p += len;
+
+			len = (sizeof(struct i40e_q_vector)
+				* vsi->num_q_vectors);
+			memcpy(p, vsi->q_vectors, len);
+			p += len;
+
+			len = (sizeof(struct i40e_ring) * vsi->num_queue_pairs);
+			memcpy(p, vsi->tx_rings, len);
+			p += len;
+			memcpy(p, vsi->rx_rings, len);
+			p += len;
+
+			for (i = 0; i < vsi->num_queue_pairs; i++) {
+				len = sizeof(struct i40e_tx_buffer);
+				memcpy(p, vsi->tx_rings[i].tx_bi, len);
+				p += len;
+			}
+			for (i = 0; i < vsi->num_queue_pairs; i++) {
+				len = sizeof(struct i40e_rx_buffer);
+				memcpy(p, vsi->rx_rings[i].rx_bi, len);
+				p += len;
+			}
+
+			/* macvlan filter list */
+			len = sizeof(struct i40e_mac_filter);
+			list_for_each_entry(f, &vsi->mac_filter_list, list) {
+				memcpy(p, f, len);
+				p += len;
+			}
+
+			i40e_dbg_dump_data_len = buflen;
+			dev_info(&pf->pdev->dev,
+				 "%s: VSI seid %ld dumped %d bytes\n",
+				 __func__, seid, (int)i40e_dbg_dump_data_len);
+		}
+		mutex_unlock(&pf->switch_mutex);
+	} else if (seid >= I40E_BASE_VEB_SEID) {
+		struct i40e_veb *veb = NULL;
+
+		mutex_lock(&pf->switch_mutex);
+		veb = i40e_dbg_find_veb(pf, seid);
+		if (!veb) {
+			mutex_unlock(&pf->switch_mutex);
+			goto write_exit;
+		}
+
+		buflen = sizeof(struct i40e_veb);
+		if (i40e_dbg_prep_dump_buf(pf, buflen)) {
+			seid_found = true;
+			memcpy(i40e_dbg_dump_buf, veb, buflen);
+			i40e_dbg_dump_data_len = buflen;
+			dev_info(&pf->pdev->dev,
+				 "%s: VEB seid %ld dumped %d bytes\n",
+				 __func__, seid, (int)i40e_dbg_dump_data_len);
+		}
+		mutex_unlock(&pf->switch_mutex);
+	}
+
+write_exit:
+	if (!seid_found)
+		dev_info(&pf->pdev->dev, "%s: unknown seid %ld\n",
+			 __func__, seid);
+
+	return count;
+}
+
+static const struct file_operations i40e_dbg_dump_fops = {
+	.owner = THIS_MODULE,
+	.open =  simple_open,
+	.read =  i40e_dbg_dump_read,
+	.write = i40e_dbg_dump_write,
+};
+
+/**************************************************************
+ * command
+ * The command entry in debugfs is for giving the driver commands
+ * to be executed - these may be for changing the internal switch
+ * setup, adding or removing filters, or other things.  Many of
+ * these will be useful for some forms of unit testing.
+ **************************************************************/
+static char i40e_dbg_command_buf[256] = "hello world";
+
+/**
+ * i40e_dbg_command_read - read for command datum
+ * @filp: the opened file
+ * @buffer: where to write the data for the user to read
+ * @count: the size of the user's buffer
+ * @ppos: file position offset
+ **/
+static ssize_t i40e_dbg_command_read(struct file *filp, char __user *buffer,
+				    size_t count, loff_t *ppos)
+{
+	struct i40e_pf *pf = filp->private_data;
+	char *buf;
+	int bytes_not_copied;
+	int len;
+	int buf_size = 256;
+
+	/* don't allow partial reads */
+	if (*ppos != 0)
+		return 0;
+	if (count < buf_size)
+		return -ENOSPC;
+
+	buf = kzalloc(buf_size, GFP_KERNEL);
+	if (!buf)
+		return -ENOSPC;
+
+	len = snprintf(buf, buf_size, "%s: %s\n",
+		       pf->vsi[pf->lan_vsi]->netdev->name, i40e_dbg_command_buf);
+
+	bytes_not_copied = copy_to_user(buffer, buf, len);
+
+	kfree(buf);
+
+	if (bytes_not_copied < 0)
+		return bytes_not_copied;
+
+	*ppos = len;
+	return len;
+}
+
+/**
+ * i40e_dbg_dump_vsi_seid - handles dump vsi seid write into pokem datum
+ * @pf: the i40e_pf created in command write
+ * @seid: the seid the user put in
+ **/
+static void i40e_dbg_dump_vsi_seid(struct i40e_pf *pf, int seid)
+{
+	int i;
+	struct i40e_vsi *vsi;
+	struct i40e_mac_filter *f;
+	struct rtnl_link_stats64 *nstat;
+
+	vsi = i40e_dbg_find_vsi(pf, seid);
+	if (!vsi) {
+		dev_info(&pf->pdev->dev,
+			"%s: dump %d: seid not found\n", __func__, seid);
+		return;
+	}
+	dev_info(&pf->pdev->dev,
+		"%s: vsi seid %d\n", __func__, seid);
+	if (vsi->netdev)
+		dev_info(&pf->pdev->dev,
+			"    netdev: name = %s\n",
+			vsi->netdev->name);
+	if (vsi->active_vlans)
+		dev_info(&pf->pdev->dev,
+			"    vlgrp: & = %p\n", vsi->active_vlans);
+	dev_info(&pf->pdev->dev,
+		"    netdev_registered = %i, current_netdev_flags = 0x%04x, state = %li flags = 0x%08lx\n",
+		vsi->netdev_registered,
+		vsi->current_netdev_flags, vsi->state, vsi->flags);
+	list_for_each_entry(f, &vsi->mac_filter_list, list) {
+		dev_info(&pf->pdev->dev,
+			"    mac_filter_list: %pM vid=%d, is_netdev=%d is_vf=%d counter=%d\n",
+			f->macaddr, f->vlan, f->is_netdev, f->is_vf,
+			f->counter);
+	}
+	nstat = i40e_get_vsi_stats_struct(vsi);
+	dev_info(&pf->pdev->dev,
+		"    net_stats: rx_packets = %lu, rx_bytes = %lu, rx_errors = %lu, rx_dropped = %lu\n",
+		(long unsigned int)nstat->rx_packets,
+		(long unsigned int)nstat->rx_bytes,
+		(long unsigned int)nstat->rx_errors,
+		(long unsigned int)nstat->rx_dropped);
+	dev_info(&pf->pdev->dev,
+		"    net_stats: tx_packets = %lu, tx_bytes = %lu, tx_errors = %lu, tx_dropped = %lu\n",
+		(long unsigned int)nstat->tx_packets,
+		(long unsigned int)nstat->tx_bytes,
+		(long unsigned int)nstat->tx_errors,
+		(long unsigned int)nstat->tx_dropped);
+	dev_info(&pf->pdev->dev,
+		"    net_stats: multicast = %lu, collisions = %lu\n",
+		(long unsigned int)nstat->multicast,
+		(long unsigned int)nstat->collisions);
+	dev_info(&pf->pdev->dev,
+		"    net_stats: rx_length_errors = %lu, rx_over_errors = %lu, rx_crc_errors = %lu\n",
+		(long unsigned int)nstat->rx_length_errors,
+		(long unsigned int)nstat->rx_over_errors,
+		(long unsigned int)nstat->rx_crc_errors);
+	dev_info(&pf->pdev->dev,
+		"    net_stats: rx_frame_errors = %lu, rx_fifo_errors = %lu, rx_missed_errors = %lu\n",
+		(long unsigned int)nstat->rx_frame_errors,
+		(long unsigned int)nstat->rx_fifo_errors,
+		(long unsigned int)nstat->rx_missed_errors);
+	dev_info(&pf->pdev->dev,
+		"    net_stats: tx_aborted_errors = %lu, tx_carrier_errors = %lu, tx_fifo_errors = %lu\n",
+		(long unsigned int)nstat->tx_aborted_errors,
+		(long unsigned int)nstat->tx_carrier_errors,
+		(long unsigned int)nstat->tx_fifo_errors);
+	dev_info(&pf->pdev->dev,
+		"    net_stats: tx_heartbeat_errors = %lu, tx_window_errors = %lu\n",
+		(long unsigned int)nstat->tx_heartbeat_errors,
+		(long unsigned int)nstat->tx_window_errors);
+	dev_info(&pf->pdev->dev,
+		"    net_stats: rx_compressed = %lu, tx_compressed = %lu\n",
+		(long unsigned int)nstat->rx_compressed,
+		(long unsigned int)nstat->tx_compressed);
+	dev_info(&pf->pdev->dev,
+		"    net_stats_offsets: rx_packets = %lu, rx_bytes = %lu, rx_errors = %lu, rx_dropped = %lu\n",
+		(long unsigned int)vsi->net_stats_offsets.rx_packets,
+		(long unsigned int)vsi->net_stats_offsets.rx_bytes,
+		(long unsigned int)vsi->net_stats_offsets.rx_errors,
+		(long unsigned int)vsi->net_stats_offsets.rx_dropped);
+	dev_info(&pf->pdev->dev,
+		"    net_stats_offsets: tx_packets = %lu, tx_bytes = %lu, tx_errors = %lu, tx_dropped = %lu\n",
+		(long unsigned int)vsi->net_stats_offsets.tx_packets,
+		(long unsigned int)vsi->net_stats_offsets.tx_bytes,
+		(long unsigned int)vsi->net_stats_offsets.tx_errors,
+		(long unsigned int)vsi->net_stats_offsets.tx_dropped);
+	dev_info(&pf->pdev->dev,
+		"    net_stats_offsets: multicast = %lu, collisions = %lu\n",
+		(long unsigned int)vsi->net_stats_offsets.multicast,
+		(long unsigned int)vsi->net_stats_offsets.collisions);
+	dev_info(&pf->pdev->dev,
+		"    net_stats_offsets: rx_length_errors = %lu, rx_over_errors = %lu, rx_crc_errors = %lu\n",
+		(long unsigned int)vsi->net_stats_offsets.rx_length_errors,
+		(long unsigned int)vsi->net_stats_offsets.rx_over_errors,
+		(long unsigned int)vsi->net_stats_offsets.rx_crc_errors);
+	dev_info(&pf->pdev->dev,
+		"    net_stats_offsets: rx_frame_errors = %lu, rx_fifo_errors = %lu, rx_missed_errors = %lu\n",
+		(long unsigned int)vsi->net_stats_offsets.rx_frame_errors,
+		(long unsigned int)vsi->net_stats_offsets.rx_fifo_errors,
+		(long unsigned int)vsi->net_stats_offsets.rx_missed_errors);
+	dev_info(&pf->pdev->dev,
+		"    net_stats_offsets: tx_aborted_errors = %lu, tx_carrier_errors = %lu, tx_fifo_errors = %lu\n",
+		(long unsigned int)vsi->net_stats_offsets.tx_aborted_errors,
+		(long unsigned int)vsi->net_stats_offsets.tx_carrier_errors,
+		(long unsigned int)vsi->net_stats_offsets.tx_fifo_errors);
+	dev_info(&pf->pdev->dev,
+		"    net_stats_offsets: tx_heartbeat_errors = %lu, tx_window_errors = %lu\n",
+		(long unsigned int)vsi->net_stats_offsets.tx_heartbeat_errors,
+		(long unsigned int)vsi->net_stats_offsets.tx_window_errors);
+	dev_info(&pf->pdev->dev,
+		"    net_stats_offsets: rx_compressed = %lu, tx_compressed = %lu\n",
+		(long unsigned int)vsi->net_stats_offsets.rx_compressed,
+		(long unsigned int)vsi->net_stats_offsets.tx_compressed);
+	dev_info(&pf->pdev->dev,
+		"    tx_restart = %d, tx_busy = %d, rx_buf_failed = %d, rx_page_failed = %d\n",
+		vsi->tx_restart, vsi->tx_busy,
+		vsi->rx_buf_failed, vsi->rx_page_failed);
+	if (vsi->rx_rings) {
+		for (i = 0; i < vsi->num_queue_pairs; i++) {
+			dev_info(&pf->pdev->dev,
+				"    rx_rings[%i]: desc = %p\n",
+				i, vsi->rx_rings[i].desc);
+			dev_info(&pf->pdev->dev,
+				"    rx_rings[%i]: dev = %p, netdev = %p, rx_bi = %p\n",
+				i, vsi->rx_rings[i].dev,
+				vsi->rx_rings[i].netdev,
+				vsi->rx_rings[i].rx_bi);
+			dev_info(&pf->pdev->dev,
+				"    rx_rings[%i]: state = %li, queue_index = %d, reg_idx = %d\n",
+				i, vsi->rx_rings[i].state,
+				vsi->rx_rings[i].queue_index,
+				vsi->rx_rings[i].reg_idx);
+			dev_info(&pf->pdev->dev,
+				"    rx_rings[%i]: rx_hdr_len = %d, rx_buf_len = %d, dtype = %d\n",
+				i, vsi->rx_rings[i].rx_hdr_len,
+				vsi->rx_rings[i].rx_buf_len,
+				vsi->rx_rings[i].dtype);
+			dev_info(&pf->pdev->dev,
+				"    rx_rings[%i]: hsplit = %d, next_to_use = %d, next_to_clean = %d, ring_active = %i\n",
+				i, vsi->rx_rings[i].hsplit,
+				vsi->rx_rings[i].next_to_use,
+				vsi->rx_rings[i].next_to_clean,
+				vsi->rx_rings[i].ring_active);
+			dev_info(&pf->pdev->dev,
+				"    rx_rings[%i]: rx_stats: packets = %lld, bytes = %lld, non_eop_descs = %lld\n",
+				i, vsi->rx_rings[i].rx_stats.packets,
+				vsi->rx_rings[i].rx_stats.bytes,
+				vsi->rx_rings[i].rx_stats.non_eop_descs);
+			dev_info(&pf->pdev->dev,
+				"    rx_rings[%i]: rx_stats: alloc_rx_page_failed = %lld, alloc_rx_buff_failed = %lld\n",
+				i,
+				vsi->rx_rings[i].rx_stats.alloc_rx_page_failed,
+				vsi->rx_rings[i].rx_stats.alloc_rx_buff_failed);
+			dev_info(&pf->pdev->dev,
+				"    rx_rings[%i]: size = %i, dma = 0x%08lx\n",
+				i, vsi->rx_rings[i].size,
+				(long unsigned int)vsi->rx_rings[i].dma);
+			dev_info(&pf->pdev->dev,
+				"    rx_rings[%i]: vsi = %p, q_vector = %p\n",
+				i, vsi->rx_rings[i].vsi,
+				vsi->rx_rings[i].q_vector);
+		}
+	}
+	if (vsi->tx_rings) {
+		for (i = 0; i < vsi->num_queue_pairs; i++) {
+			dev_info(&pf->pdev->dev,
+				"    tx_rings[%i]: desc = %p\n",
+				i, vsi->tx_rings[i].desc);
+			dev_info(&pf->pdev->dev,
+				"    tx_rings[%i]: dev = %p, netdev = %p, tx_bi = %p\n",
+				i, vsi->tx_rings[i].dev,
+				vsi->tx_rings[i].netdev,
+				vsi->tx_rings[i].tx_bi);
+			dev_info(&pf->pdev->dev,
+				"    tx_rings[%i]: state = %li, queue_index = %d, reg_idx = %d\n",
+				i, vsi->tx_rings[i].state,
+				vsi->tx_rings[i].queue_index,
+				vsi->tx_rings[i].reg_idx);
+			dev_info(&pf->pdev->dev,
+				"    tx_rings[%i]: dtype = %d\n",
+				i, vsi->tx_rings[i].dtype);
+			dev_info(&pf->pdev->dev,
+				"    tx_rings[%i]: hsplit = %d, next_to_use = %d, next_to_clean = %d, ring_active = %i\n",
+				i, vsi->tx_rings[i].hsplit,
+				vsi->tx_rings[i].next_to_use,
+				vsi->tx_rings[i].next_to_clean,
+				vsi->tx_rings[i].ring_active);
+			dev_info(&pf->pdev->dev,
+				"    tx_rings[%i]: tx_stats: packets = %lld, bytes = %lld, restart_queue = %lld\n",
+				i, vsi->tx_rings[i].tx_stats.packets,
+				vsi->tx_rings[i].tx_stats.bytes,
+				vsi->tx_rings[i].tx_stats.restart_queue);
+			dev_info(&pf->pdev->dev,
+				"    tx_rings[%i]: tx_stats: tx_busy = %lld, completed = %lld, tx_done_old = %lld\n",
+				i,
+				vsi->tx_rings[i].tx_stats.tx_busy,
+				vsi->tx_rings[i].tx_stats.completed,
+				vsi->tx_rings[i].tx_stats.tx_done_old);
+			dev_info(&pf->pdev->dev,
+				"    tx_rings[%i]: size = %i, dma = 0x%08lx\n",
+				i, vsi->tx_rings[i].size,
+				(long unsigned int)vsi->tx_rings[i].dma);
+			dev_info(&pf->pdev->dev,
+				"    tx_rings[%i]: vsi = %p, q_vector = %p\n",
+				i, vsi->tx_rings[i].vsi,
+				vsi->tx_rings[i].q_vector);
+			dev_info(&pf->pdev->dev,
+				"    tx_rings[%i]: DCB tc = %d\n",
+				i, vsi->tx_rings[i].dcb_tc);
+		}
+	}
+	dev_info(&pf->pdev->dev,
+		"    work_limit = %d, rx_itr_setting = %d (%s), tx_itr_setting = %d (%s)\n",
+		vsi->work_limit, vsi->rx_itr_setting,
+		ITR_IS_DYNAMIC(vsi->rx_itr_setting) ? "dynamic" : "fixed",
+		vsi->tx_itr_setting,
+		ITR_IS_DYNAMIC(vsi->tx_itr_setting) ? "dynamic" : "fixed");
+	dev_info(&pf->pdev->dev,
+		"    max_frame = %d, rx_hdr_len = %d, rx_buf_len = %d dtype = %d\n",
+		vsi->max_frame, vsi->rx_hdr_len, vsi->rx_buf_len, vsi->dtype);
+	if (vsi->q_vectors) {
+		for (i = 0; i < vsi->num_q_vectors; i++) {
+			dev_info(&pf->pdev->dev,
+				"    q_vectors[%i]: base index = %ld\n",
+				i, ((long int)*vsi->q_vectors[i].rx.ring-
+					(long int)*vsi->q_vectors[0].rx.ring)/
+					sizeof(struct i40e_ring));
+		}
+	}
+	dev_info(&pf->pdev->dev,
+		"    num_q_vectors = %i, base_vector = %i\n",
+		vsi->num_q_vectors, vsi->base_vector);
+	dev_info(&pf->pdev->dev,
+		"    seid = %d, id = %d, uplink_seid = %d\n",
+		vsi->seid, vsi->id, vsi->uplink_seid);
+	dev_info(&pf->pdev->dev,
+		"    base_queue = %d, num_queue_pairs = %d, num_desc = %d\n",
+		vsi->base_queue, vsi->num_queue_pairs, vsi->num_desc);
+	dev_info(&pf->pdev->dev,
+		"    type = %i\n",
+		vsi->type);
+	dev_info(&pf->pdev->dev,
+		"    info: valid_sections = 0x%04x, switch_id = 0x%04x\n",
+		vsi->info.valid_sections, vsi->info.switch_id);
+	dev_info(&pf->pdev->dev,
+		"    info: sw_reserved[] = 0x%02x 0x%02x\n",
+		vsi->info.sw_reserved[0], vsi->info.sw_reserved[1]);
+	dev_info(&pf->pdev->dev,
+		"    info: sec_flags = 0x%02x, sec_reserved = 0x%02x\n",
+		vsi->info.sec_flags, vsi->info.sec_reserved);
+	dev_info(&pf->pdev->dev,
+		"    info: pvid = 0x%04x, fcoe_pvid = 0x%04x, port_vlan_flags = 0x%02x\n",
+		vsi->info.pvid, vsi->info.fcoe_pvid, vsi->info.port_vlan_flags);
+	dev_info(&pf->pdev->dev,
+		"    info: pvlan_reserved[] = 0x%02x 0x%02x 0x%02x\n",
+		vsi->info.pvlan_reserved[0], vsi->info.pvlan_reserved[1],
+		vsi->info.pvlan_reserved[2]);
+	dev_info(&pf->pdev->dev,
+		"    info: ingress_table = 0x%08x, egress_table = 0x%08x\n",
+		vsi->info.ingress_table, vsi->info.egress_table);
+	dev_info(&pf->pdev->dev,
+		"    info: cas_pv_stag = 0x%04x, cas_pv_flags= 0x%02x, cas_pv_reserved = 0x%02x\n",
+		vsi->info.cas_pv_tag, vsi->info.cas_pv_flags,
+		vsi->info.cas_pv_reserved);
+	dev_info(&pf->pdev->dev,
+		"    info: queue_mapping[0..7 ] = 0x%04x 0x%04x 0x%04x 0x%04x 0x%04x 0x%04x 0x%04x 0x%04x\n",
+		vsi->info.queue_mapping[0], vsi->info.queue_mapping[1],
+		vsi->info.queue_mapping[2], vsi->info.queue_mapping[3],
+		vsi->info.queue_mapping[4], vsi->info.queue_mapping[5],
+		vsi->info.queue_mapping[6], vsi->info.queue_mapping[7]);
+	dev_info(&pf->pdev->dev,
+		"    info: queue_mapping[8..15] = 0x%04x 0x%04x 0x%04x 0x%04x 0x%04x 0x%04x 0x%04x 0x%04x\n",
+		vsi->info.queue_mapping[8], vsi->info.queue_mapping[9],
+		vsi->info.queue_mapping[10], vsi->info.queue_mapping[11],
+		vsi->info.queue_mapping[12], vsi->info.queue_mapping[13],
+		vsi->info.queue_mapping[14], vsi->info.queue_mapping[15]);
+	dev_info(&pf->pdev->dev,
+		"    info: tc_mapping[] = 0x%04x 0x%04x 0x%04x 0x%04x 0x%04x 0x%04x 0x%04x 0x%04x\n",
+		vsi->info.tc_mapping[0], vsi->info.tc_mapping[1],
+		vsi->info.tc_mapping[2], vsi->info.tc_mapping[3],
+		vsi->info.tc_mapping[4], vsi->info.tc_mapping[5],
+		vsi->info.tc_mapping[6], vsi->info.tc_mapping[7]);
+	dev_info(&pf->pdev->dev,
+		"    info: queueing_opt_flags = 0x%02x  queueing_opt_reserved[0..2] = 0x%02x 0x%02x 0x%02x\n",
+		vsi->info.queueing_opt_flags,
+		vsi->info.queueing_opt_reserved[0],
+		vsi->info.queueing_opt_reserved[1],
+		vsi->info.queueing_opt_reserved[2]);
+	dev_info(&pf->pdev->dev,
+		"    info: up_enable_bits = 0x%02x\n",
+		vsi->info.up_enable_bits);
+	dev_info(&pf->pdev->dev,
+		"    info: sched_reserved = 0x%02x, outer_up_table = 0x%04x\n",
+		vsi->info.sched_reserved, vsi->info.outer_up_table);
+	dev_info(&pf->pdev->dev,
+		"    info: cmd_reserved[] = 0x%02x 0x%02x 0x%02x 0x0%02x 0x%02x 0x%02x 0x%02x 0x0%02x\n",
+		vsi->info.cmd_reserved[0], vsi->info.cmd_reserved[1],
+		vsi->info.cmd_reserved[2], vsi->info.cmd_reserved[3],
+		vsi->info.cmd_reserved[4], vsi->info.cmd_reserved[5],
+		vsi->info.cmd_reserved[6], vsi->info.cmd_reserved[7]);
+	dev_info(&pf->pdev->dev,
+		"    info: qs_handle[] = 0x%04x 0x%04x 0x%04x 0x%04x 0x%04x 0x%04x 0x%04x 0x%04x\n",
+		vsi->info.qs_handle[0], vsi->info.qs_handle[1],
+		vsi->info.qs_handle[2], vsi->info.qs_handle[3],
+		vsi->info.qs_handle[4], vsi->info.qs_handle[5],
+		vsi->info.qs_handle[6], vsi->info.qs_handle[7]);
+	dev_info(&pf->pdev->dev,
+		"    info: stat_counter_idx = 0x%04x, sched_id = 0x%04x\n",
+		vsi->info.stat_counter_idx, vsi->info.sched_id);
+	dev_info(&pf->pdev->dev,
+		"    info: resp_reserved[] = 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x\n",
+		vsi->info.resp_reserved[0], vsi->info.resp_reserved[1],
+		vsi->info.resp_reserved[2], vsi->info.resp_reserved[3],
+		vsi->info.resp_reserved[4], vsi->info.resp_reserved[5],
+		vsi->info.resp_reserved[6], vsi->info.resp_reserved[7],
+		vsi->info.resp_reserved[8], vsi->info.resp_reserved[9],
+		vsi->info.resp_reserved[10], vsi->info.resp_reserved[11]);
+	if (vsi->back)
+		dev_info(&pf->pdev->dev,
+			"    pf = %p\n", vsi->back);
+	dev_info(&pf->pdev->dev,
+		"    idx = %d\n", vsi->idx);
+	dev_info(&pf->pdev->dev,
+		"    tc_config: numtc = %d, enabled_tc = 0x%x\n",
+		vsi->tc_config.numtc, vsi->tc_config.enabled_tc);
+	for (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) {
+		dev_info(&pf->pdev->dev,
+			 "    tc_config: tc = %d, qoffset = %d, qcount = %d, netdev_tc = %d\n",
+			 i, vsi->tc_config.tc_info[i].qoffset,
+			 vsi->tc_config.tc_info[i].qcount,
+			 vsi->tc_config.tc_info[i].netdev_tc);
+	}
+	dev_info(&pf->pdev->dev,
+		"    bw: bw_limit = %d, bw_max_quanta = %d\n",
+		vsi->bw_limit, vsi->bw_max_quanta);
+	for (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) {
+		dev_info(&pf->pdev->dev,
+			 "    bw[%d]: ets_share_credits = %d, ets_limit_credits = %d, max_quanta = %d\n",
+			 i, vsi->bw_ets_share_credits[i],
+			 vsi->bw_ets_limit_credits[i],
+			 vsi->bw_ets_max_quanta[i]);
+	}
+
+}
+
+/**
+ * i40e_dbg_dump_aq_desc - handles dump aq_desc write into command datum
+ * @pf: the i40e_pf created in command write
+ **/
+static void i40e_dbg_dump_aq_desc(struct i40e_pf *pf)
+{
+	struct i40e_hw *hw = &pf->hw;
+	struct i40e_adminq_ring *ring;
+	int i;
+
+	/* first the send (command) ring, then the receive (event) ring */
+	dev_info(&pf->pdev->dev, "%s: AdminQ Tx Ring\n", __func__);
+	ring = &(hw->aq.asq);
+	for (i = 0; i < ring->count; i++) {
+		struct i40e_aq_desc *d = I40E_ADMINQ_DESC(*ring, i);
+		dev_info(&pf->pdev->dev,
+			"   at[%02d] flags=0x%04x op=0x%04x dlen=0x%04x ret=0x%04x cookie_h=0x%08x cookie_l=0x%08x\n",
+			i, d->flags, d->opcode, d->datalen, d->retval,
+			d->cookie_high, d->cookie_low);
+		dev_info(&pf->pdev->dev,
+			"            %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x\n",
+			d->params.raw[0], d->params.raw[1], d->params.raw[2],
+			d->params.raw[3], d->params.raw[4], d->params.raw[5],
+			d->params.raw[6], d->params.raw[7], d->params.raw[8],
+			d->params.raw[9], d->params.raw[10], d->params.raw[11],
+			d->params.raw[12], d->params.raw[13], d->params.raw[14],
+			d->params.raw[15]);
+	}
+
+	dev_info(&pf->pdev->dev, "%s: AdminQ Rx Ring\n", __func__);
+	ring = &(hw->aq.arq);
+	for (i = 0; i < ring->count; i++) {
+		struct i40e_aq_desc *d = I40E_ADMINQ_DESC(*ring, i);
+		dev_info(&pf->pdev->dev,
+			"   ar[%02d] flags=0x%04x op=0x%04x dlen=0x%04x ret=0x%04x cookie_h=0x%08x cookie_l=0x%08x\n",
+			i, d->flags, d->opcode, d->datalen, d->retval,
+			d->cookie_high, d->cookie_low);
+		dev_info(&pf->pdev->dev,
+			"            %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x\n",
+			d->params.raw[0], d->params.raw[1], d->params.raw[2],
+			d->params.raw[3], d->params.raw[4], d->params.raw[5],
+			d->params.raw[6], d->params.raw[7], d->params.raw[8],
+			d->params.raw[9], d->params.raw[10], d->params.raw[11],
+			d->params.raw[12], d->params.raw[13], d->params.raw[14],
+			d->params.raw[15]);
+	}
+}
+
+/**
+ * i40e_dbg_dump_desc - handles dump desc write into command datum
+ * @cnt: number of arguments that the user supplied
+ * @vsi_seid: vsi id entered by user
+ * @ring_id: ring id entered by user
+ * @desc_n: descriptor number entered by user
+ * @pf: the i40e_pf created in command write
+ * @is_rx_ring: true if rx, false if tx
+ **/
+static void i40e_dbg_dump_desc(int cnt, int vsi_seid, int ring_id, int desc_n,
+					struct i40e_pf *pf, bool is_rx_ring)
+{
+	int i;
+	union i40e_rx_desc *ds;
+	struct i40e_vsi *vsi;
+	struct i40e_ring ring;
+	vsi = i40e_dbg_find_vsi(pf, vsi_seid);
+	if (!vsi) {
+		dev_info(&pf->pdev->dev,
+			"%s: vsi %d not found\n", __func__, vsi_seid);
+		if (is_rx_ring)
+			dev_info(&pf->pdev->dev,
+				"%s: dump desc rx <vsi_seid> <ring_id> [<desc_n>]\n",
+				__func__);
+		else
+			dev_info(&pf->pdev->dev,
+				"%s: dump desc tx <vsi_seid> <ring_id> [<desc_n>]\n",
+				__func__);
+		return;
+	}
+	if (ring_id >= vsi->num_queue_pairs || ring_id < 0) {
+		dev_info(&pf->pdev->dev,
+			"%s: ring %d not found\n", __func__, ring_id);
+		if (is_rx_ring)
+			dev_info(&pf->pdev->dev,
+				"%s: dump desc rx <vsi_seid> <ring_id> [<desc_n>]\n",
+				__func__);
+		else
+			dev_info(&pf->pdev->dev,
+				"%s: dump desc tx <vsi_seid> <ring_id> [<desc_n>]\n",
+				__func__);
+		return;
+	}
+	if (is_rx_ring)
+		ring = vsi->rx_rings[ring_id];
+	else
+		ring = vsi->tx_rings[ring_id];
+	if (cnt == 2) {
+		dev_info(&pf->pdev->dev, "%s: vsi = %02i %s ring = %02i\n",
+			__func__, vsi_seid, is_rx_ring ? "rx" : "tx", ring_id);
+		for (i = 0; i < ring.count; i++) {
+			if (is_rx_ring)
+				ds = I40E_RX_DESC(&ring, i);
+			else
+				ds = (union i40e_rx_desc *)
+					I40E_TX_DESC(&ring, i);
+			if ((sizeof(union i40e_rx_desc) ==
+			    sizeof(union i40e_16byte_rx_desc)) || (!is_rx_ring))
+				dev_info(&pf->pdev->dev,
+					"   d[%03i] = 0x%016llx 0x%016llx\n", i,
+					ds->read.pkt_addr, ds->read.hdr_addr);
+			else
+				dev_info(&pf->pdev->dev,
+					"   d[%03i] = 0x%016llx 0x%016llx 0x%016llx 0x%016llx\n",
+					i, ds->read.pkt_addr, ds->read.hdr_addr,
+					ds->read.rsvd1, ds->read.rsvd2);
+		}
+	} else if (cnt == 3) {
+		if (desc_n >= ring.count || desc_n < 0) {
+			dev_info(&pf->pdev->dev,
+				"%s: descriptor %d not found\n",
+				__func__, desc_n);
+			return;
+		}
+		if (is_rx_ring)
+			ds = I40E_RX_DESC(&ring, desc_n);
+		else
+			ds = (union i40e_rx_desc *) I40E_TX_DESC(&ring, desc_n);
+		if ((sizeof(union i40e_rx_desc) ==
+		    sizeof(union i40e_16byte_rx_desc)) || (!is_rx_ring))
+			dev_info(&pf->pdev->dev,
+				"%s: vsi = %02i %s ring = %02i d[%03i] = 0x%016llx 0x%016llx\n",
+				__func__, vsi_seid,
+				is_rx_ring ? "rx" : "tx", ring_id,
+				desc_n, ds->read.pkt_addr, ds->read.hdr_addr);
+		else
+			dev_info(&pf->pdev->dev,
+				"%s: vsi = %02i rx ring = %02i d[%03i] = 0x%016llx 0x%016llx 0x%016llx 0x%016llx\n",
+				__func__, vsi_seid, ring_id,
+				desc_n, ds->read.pkt_addr, ds->read.hdr_addr,
+				ds->read.rsvd1, ds->read.rsvd2);
+	} else {
+		if (is_rx_ring)
+			dev_info(&pf->pdev->dev,
+				"%s: dump desc rx <vsi_seid> <ring_id> [<desc_n>]\n",
+				__func__);
+		else
+			dev_info(&pf->pdev->dev,
+				"%s: dump desc tx <vsi_seid> <ring_id> [<desc_n>]\n",
+				__func__);
+	}
+}
+
+/**
+ * i40e_dbg_dump_vsi_no_seid - handles dump vsi write into command datum
+ * @pf: the i40e_pf created in command write
+ **/
+static void i40e_dbg_dump_vsi_no_seid(struct i40e_pf *pf)
+{
+	int i;
+	for (i = 0; i < pf->hw.func_caps.num_vsis; i++)
+		if (pf->vsi[i])
+			dev_info(&pf->pdev->dev, "%s: dump vsi[%d]: %d\n",
+				__func__, i, pf->vsi[i]->seid);
+}
+
+/**
+ * i40e_dbg_dump_stats - handles dump stats write into command datum
+ * @pf: the i40e_pf created in command write
+ * @estats: the eth stats structure to be dumped
+ **/
+static void i40e_dbg_dump_eth_stats(struct i40e_pf *pf,
+				    struct i40e_eth_stats *estats)
+{
+	dev_info(&pf->pdev->dev, "  ethstats:\n");
+	dev_info(&pf->pdev->dev,
+		"    rx_bytes = \t%lld \trx_unicast = \t\t%lld \trx_multicast = \t%lld\n",
+		estats->rx_bytes, estats->rx_unicast, estats->rx_multicast);
+	dev_info(&pf->pdev->dev,
+		"    rx_broadcast = \t%lld \trx_discards = \t\t%lld \trx_errors = \t%lld\n",
+		estats->rx_broadcast, estats->rx_discards, estats->rx_errors);
+	dev_info(&pf->pdev->dev,
+		"    rx_missed = \t%lld \trx_unknown_protocol = \t%lld \ttx_bytes = \t%lld\n",
+		estats->rx_missed, estats->rx_unknown_protocol,
+		estats->tx_bytes);
+	dev_info(&pf->pdev->dev,
+		"    tx_unicast = \t%lld \ttx_multicast = \t\t%lld \ttx_broadcast = \t%lld\n",
+		estats->tx_unicast, estats->tx_multicast, estats->tx_broadcast);
+	dev_info(&pf->pdev->dev,
+		"    tx_discards = \t%lld \ttx_errors = \t\t%lld\n",
+		estats->tx_discards, estats->tx_errors);
+}
+
+/**
+ * i40e_dbg_dump_stats - handles dump stats write into command datum
+ * @pf: the i40e_pf created in command write
+ * @stats: the stats structure to be dumped
+ **/
+static void i40e_dbg_dump_stats(struct i40e_pf *pf,
+				struct i40e_hw_port_stats *stats)
+{
+	int i;
+
+	dev_info(&pf->pdev->dev, "  stats:\n");
+	dev_info(&pf->pdev->dev,
+		"    crc_errors = \t\t%lld \tillegal_bytes = \t%lld \terror_bytes = \t\t%lld\n",
+		stats->crc_errors, stats->illegal_bytes, stats->error_bytes);
+	dev_info(&pf->pdev->dev,
+		"    mac_local_faults = \t%lld \tmac_remote_faults = \t%lld \trx_length_errors = \t%lld\n",
+		stats->mac_local_faults, stats->mac_remote_faults,
+		stats->rx_length_errors);
+	dev_info(&pf->pdev->dev,
+		"    link_xon_rx = \t\t%lld \tlink_xoff_rx = \t\t%lld \tlink_xon_tx = \t\t%lld\n",
+		stats->link_xon_rx, stats->link_xoff_rx, stats->link_xon_tx);
+	dev_info(&pf->pdev->dev,
+		"    link_xoff_tx = \t\t%lld \trx_size_64 = \t\t%lld \trx_size_127 = \t\t%lld\n",
+		stats->link_xoff_tx, stats->rx_size_64, stats->rx_size_127);
+	dev_info(&pf->pdev->dev,
+		"    rx_size_255 = \t\t%lld \trx_size_511 = \t\t%lld \trx_size_1023 = \t\t%lld\n",
+		stats->rx_size_255, stats->rx_size_511, stats->rx_size_1023);
+	dev_info(&pf->pdev->dev,
+		"    rx_size_big = \t\t%lld \trx_undersize = \t\t%lld \trx_jabber = \t\t%lld\n",
+		stats->rx_size_big, stats->rx_undersize, stats->rx_jabber);
+	dev_info(&pf->pdev->dev,
+		"    rx_fragments = \t\t%lld \trx_oversize = \t\t%lld \ttx_size_64 = \t\t%lld\n",
+		stats->rx_fragments, stats->rx_oversize, stats->tx_size_64);
+	dev_info(&pf->pdev->dev,
+	"    tx_size_127 = \t\t%lld \ttx_size_255 = \t\t%lld \ttx_size_511 = \t\t%lld\n",
+		stats->tx_size_127, stats->tx_size_255, stats->tx_size_511);
+	dev_info(&pf->pdev->dev,
+	"    tx_size_1023 = \t\t%lld \ttx_size_big = \t\t%lld \tmac_short_packet_dropped = \t%lld\n",
+		stats->tx_size_1023, stats->tx_size_big,
+		stats->mac_short_packet_dropped);
+	for (i = 0; i < 8; i += 4) {
+		dev_info(&pf->pdev->dev,
+			"    priority_xon_rx[%d] = \t%lld \t[%d] = \t%lld \t[%d] = \t%lld \t[%d] = \t%lld\n",
+			i, stats->priority_xon_rx[i],
+			i+1, stats->priority_xon_rx[i+1],
+			i+2, stats->priority_xon_rx[i+2],
+			i+3, stats->priority_xon_rx[i+3]);
+	}
+	for (i = 0; i < 8; i += 4) {
+		dev_info(&pf->pdev->dev,
+			"    priority_xoff_rx[%d] = \t%lld \t[%d] = \t%lld \t[%d] = \t%lld \t[%d] = \t%lld\n",
+			i, stats->priority_xoff_rx[i],
+			i+1, stats->priority_xoff_rx[i+1],
+			i+2, stats->priority_xoff_rx[i+2],
+			i+3, stats->priority_xoff_rx[i+3]);
+	}
+	for (i = 0; i < 8; i += 4) {
+		dev_info(&pf->pdev->dev,
+			"    priority_xon_tx[%d] = \t%lld \t[%d] = \t%lld \t[%d] = \t%lld \t[%d] = \t%lld\n",
+			i, stats->priority_xon_tx[i],
+			i+1, stats->priority_xon_tx[i+1],
+			i+2, stats->priority_xon_tx[i+2],
+			i+3, stats->priority_xon_rx[i+3]);
+	}
+	for (i = 0; i < 8; i += 4) {
+		dev_info(&pf->pdev->dev,
+		"    priority_xoff_tx[%d] = \t%lld \t[%d] = \t%lld \t[%d] = \t%lld \t[%d] = \t%lld\n",
+			i, stats->priority_xoff_tx[i],
+			i+1, stats->priority_xoff_tx[i+1],
+			i+2, stats->priority_xoff_tx[i+2],
+			i+3, stats->priority_xoff_tx[i+3]);
+	}
+	for (i = 0; i < 8; i += 4) {
+		dev_info(&pf->pdev->dev,
+			"    priority_xon_2_xoff[%d] = \t%lld \t[%d] = \t%lld \t[%d] = \t%lld \t[%d] = \t%lld\n",
+			i, stats->priority_xon_2_xoff[i],
+			i+1, stats->priority_xon_2_xoff[i+1],
+			i+2, stats->priority_xon_2_xoff[i+2],
+			i+3, stats->priority_xon_2_xoff[i+3]);
+	}
+
+	i40e_dbg_dump_eth_stats(pf, &stats->eth);
+}
+
+/**
+ * i40e_dbg_dump_veb_seid - handles dump stats of a single given veb
+ * @pf: the i40e_pf created in command write
+ * @seid: the seid the user put in
+ **/
+static void i40e_dbg_dump_veb_seid(struct i40e_pf *pf, int seid)
+{
+	struct i40e_veb *veb;
+
+	if ((seid < I40E_BASE_VEB_SEID) ||
+	    (seid >= (I40E_MAX_VEB + I40E_BASE_VEB_SEID))) {
+		dev_info(&pf->pdev->dev, "%s: %d: bad seid\n", __func__, seid);
+		return;
+	}
+
+	veb = i40e_dbg_find_veb(pf, seid);
+	if (!veb) {
+		dev_info(&pf->pdev->dev,
+			 "%s: %d: can't find veb\n", __func__, seid);
+		return;
+	}
+	dev_info(&pf->pdev->dev,
+		 "veb idx=%d,%d stats_ic=%d  seid=%d uplink=%d\n",
+		 veb->idx, veb->veb_idx, veb->stats_idx, veb->seid,
+		 veb->uplink_seid);
+	i40e_dbg_dump_eth_stats(pf, &veb->stats);
+}
+
+/**
+ * i40e_dbg_dump_veb_all - dumps all known veb's stats
+ * @pf: the i40e_pf created in command write
+ **/
+static void i40e_dbg_dump_veb_all(struct i40e_pf *pf)
+{
+	int i;
+	struct i40e_veb *veb;
+
+	for (i = 0; i < I40E_MAX_VEB; i++) {
+		veb = pf->veb[i];
+		if (veb)
+			i40e_dbg_dump_veb_seid(pf, veb->seid);
+	}
+}
+
+#define I40E_MAX_DEBUG_OUT_BUFFER (4096*4)
+/**
+ * i40e_dbg_command_write - write into command datum
+ * @filp: the opened file
+ * @buffer: where to find the user's data
+ * @count: the length of the user's data
+ * @ppos: file position offset
+ **/
+static ssize_t i40e_dbg_command_write(struct file *filp,
+				     const char __user *buffer,
+				     size_t count, loff_t *ppos)
+{
+	char *cmd_buf;
+	struct i40e_pf *pf = filp->private_data;
+	int bytes_not_copied;
+	struct i40e_vsi *vsi;
+	int vsi_seid, veb_seid;
+	int cnt;
+	u8 *print_buf, *print_buf_start;
+
+	/* don't allow partial writes */
+	if (*ppos != 0)
+		return 0;
+
+	cmd_buf = kzalloc(count + 1, GFP_KERNEL);
+	if (!cmd_buf)
+		return count;
+	bytes_not_copied = copy_from_user(cmd_buf, buffer, count);
+	if (bytes_not_copied < 0)
+		return bytes_not_copied;
+	if (bytes_not_copied > 0)
+		count -= bytes_not_copied;
+	cmd_buf[count] = '\0';
+
+	print_buf_start = kzalloc(I40E_MAX_DEBUG_OUT_BUFFER, GFP_KERNEL);
+	if (!print_buf_start)
+		goto command_write_done;
+	print_buf = print_buf_start;
+
+	if (strncmp(cmd_buf, "add vsi", 7) == 0) {
+		vsi_seid = -1;
+		cnt = sscanf(&cmd_buf[7], "%i", &vsi_seid);
+		if (cnt == 0) {
+			/* default to PF VSI */
+			vsi_seid = pf->vsi[pf->lan_vsi]->seid;
+		} else if (vsi_seid < 0) {
+			dev_info(&pf->pdev->dev,
+				 "%s: add VSI %d: bad vsi seid\n",
+				 __func__, vsi_seid);
+			goto command_write_done;
+		}
+
+		vsi = i40e_vsi_setup(pf, I40E_VSI_VMDQ2, vsi_seid, 0);
+		if (vsi)
+			dev_info(&pf->pdev->dev, "%s: added VSI %d to relay %d\n",
+				 __func__, vsi->seid, vsi->uplink_seid);
+		else
+			dev_info(&pf->pdev->dev, "%s: '%s' failed\n",
+				 __func__, cmd_buf);
+
+	} else if (strncmp(cmd_buf, "del vsi", 7) == 0) {
+		sscanf(&cmd_buf[7], "%i", &vsi_seid);
+		vsi = i40e_dbg_find_vsi(pf, vsi_seid);
+		if (!vsi) {
+			dev_info(&pf->pdev->dev,
+				 "%s: del VSI %d: seid not found\n",
+				 __func__, vsi_seid);
+			goto command_write_done;
+		}
+
+		dev_info(&pf->pdev->dev, "%s: deleting VSI %d\n",
+			 __func__, vsi_seid);
+		i40e_vsi_release(vsi);
+
+	} else if (strncmp(cmd_buf, "add relay", 9) == 0) {
+		struct i40e_veb *veb;
+		int uplink_seid, i;
+
+		cnt = sscanf(&cmd_buf[9], "%i %i",
+			     &uplink_seid, &vsi_seid);
+		if (cnt != 2) {
+			dev_info(&pf->pdev->dev,
+				 "%s: add relay: bad command string, cnt=%d\n",
+				 __func__, cnt);
+			goto command_write_done;
+		} else if (uplink_seid < 0) {
+			dev_info(&pf->pdev->dev,
+				 "%s: add relay %d: bad uplink seid\n",
+				 __func__, uplink_seid);
+			goto command_write_done;
+		}
+
+		vsi = i40e_dbg_find_vsi(pf, vsi_seid);
+		if (!vsi) {
+			dev_info(&pf->pdev->dev,
+				 "%s: add relay: vsi VSI %d not found\n",
+				 __func__, vsi_seid);
+			goto command_write_done;
+		}
+
+		for (i = 0; i < I40E_MAX_VEB; i++)
+			if (pf->veb[i] && pf->veb[i]->seid == uplink_seid)
+				break;
+		if (i >= I40E_MAX_VEB && uplink_seid != 0 &&
+		    uplink_seid != pf->mac_seid) {
+			dev_info(&pf->pdev->dev,
+				 "%s: add relay: relay uplink %d not found\n",
+				 __func__, uplink_seid);
+			goto command_write_done;
+		}
+
+		veb = i40e_veb_setup(pf, 0, uplink_seid, vsi_seid,
+				     vsi->tc_config.enabled_tc);
+		if (veb)
+			dev_info(&pf->pdev->dev, "%s: added relay %d\n",
+				 __func__, veb->seid);
+		else
+			dev_info(&pf->pdev->dev, "%s: add relay failed\n",
+				 __func__);
+
+	} else if (strncmp(cmd_buf, "del relay", 9) == 0) {
+		int i;
+		cnt = sscanf(&cmd_buf[9], "%i", &veb_seid);
+		if (cnt != 1) {
+			dev_info(&pf->pdev->dev,
+				 "%s: del relay: bad command string, cnt=%d\n",
+				 __func__, cnt);
+			goto command_write_done;
+		} else if (veb_seid < 0) {
+			dev_info(&pf->pdev->dev,
+				 "%s: del relay %d: bad relay seid\n",
+				 __func__, veb_seid);
+			goto command_write_done;
+		}
+
+		/* find the veb */
+		for (i = 0; i < I40E_MAX_VEB; i++)
+			if (pf->veb[i] && pf->veb[i]->seid == veb_seid)
+				break;
+		if (i >= I40E_MAX_VEB) {
+			dev_info(&pf->pdev->dev,
+				 "%s: del relay: relay %d not found\n",
+				 __func__, veb_seid);
+			goto command_write_done;
+		}
+
+		dev_info(&pf->pdev->dev, "%s: deleting relay %d\n",
+			 __func__, veb_seid);
+		i40e_veb_release(pf->veb[i]);
+
+	} else if (strncmp(cmd_buf, "add macaddr", 11) == 0) {
+		u8 ma[6];
+		int vlan = 0;
+		struct i40e_mac_filter *f;
+		enum i40e_status_code ret;
+
+		cnt = sscanf(&cmd_buf[11],
+			     "%i %hhx:%hhx:%hhx:%hhx:%hhx:%hhx %i",
+			     &vsi_seid,
+			     &ma[0], &ma[1], &ma[2], &ma[3], &ma[4], &ma[5],
+			     &vlan);
+		if (cnt == 7) {
+			vlan = 0;
+		} else if (cnt != 8) {
+			dev_info(&pf->pdev->dev,
+				 "%s: add macaddr: bad command string, cnt=%d\n",
+				 __func__, cnt);
+			goto command_write_done;
+		}
+
+		vsi = i40e_dbg_find_vsi(pf, vsi_seid);
+		if (!vsi) {
+			dev_info(&pf->pdev->dev,
+				 "%s: add macaddr: VSI %d not found\n",
+				 __func__, vsi_seid);
+			goto command_write_done;
+		}
+
+		f = i40e_add_filter(vsi, ma, vlan, false, false);
+		ret = i40e_sync_vsi_filters(vsi);
+		if (f && !ret)
+			dev_info(&pf->pdev->dev,
+				 "%s: add macaddr: %pM vlan=%d added to VSI %d\n",
+				 __func__, ma, vlan, vsi_seid);
+		else
+			dev_info(&pf->pdev->dev,
+				 "%s: add macaddr: %pM vlan=%d to VSI %d failed, f=%p ret=%d\n",
+				 __func__, ma, vlan, vsi_seid, f, ret);
+
+	} else if (strncmp(cmd_buf, "del macaddr", 11) == 0) {
+		u8 ma[6];
+		int vlan = 0;
+		enum i40e_status_code ret;
+
+		cnt = sscanf(&cmd_buf[11],
+			     "%i %hhx:%hhx:%hhx:%hhx:%hhx:%hhx %i",
+			     &vsi_seid,
+			     &ma[0], &ma[1], &ma[2], &ma[3], &ma[4], &ma[5],
+			     &vlan);
+		if (cnt == 7) {
+			vlan = 0;
+		} else if (cnt != 8) {
+			dev_info(&pf->pdev->dev,
+				 "%s: del macaddr: bad command string, cnt=%d\n",
+				 __func__, cnt);
+			goto command_write_done;
+		}
+
+		vsi = i40e_dbg_find_vsi(pf, vsi_seid);
+		if (!vsi) {
+			dev_info(&pf->pdev->dev,
+				 "%s: del macaddr: VSI %d not found\n",
+				 __func__, vsi_seid);
+			goto command_write_done;
+		}
+
+		i40e_del_filter(vsi, ma, vlan, false, false);
+		ret = i40e_sync_vsi_filters(vsi);
+		if (!ret)
+			dev_info(&pf->pdev->dev,
+				 "%s: del macaddr: %pM vlan=%d removed from VSI %d\n",
+				 __func__, ma, vlan, vsi_seid);
+		else
+			dev_info(&pf->pdev->dev,
+				 "%s: del macaddr: %pM vlan=%d from VSI %d failed, ret=%d\n",
+				 __func__, ma, vlan, vsi_seid, ret);
+
+	} else if (strncmp(cmd_buf, "add pvid", 8) == 0) {
+		int v;
+		u16 vid;
+		enum i40e_status_code ret;
+
+		cnt = sscanf(&cmd_buf[8], "%i %u", &vsi_seid, &v);
+		if (cnt != 2) {
+			dev_info(&pf->pdev->dev,
+				 "%s: add pvid: bad command string, cnt=%d\n",
+				 __func__, cnt);
+			goto command_write_done;
+		}
+
+		vsi = i40e_dbg_find_vsi(pf, vsi_seid);
+		if (!vsi) {
+			dev_info(&pf->pdev->dev,
+				 "%s: add pvid: VSI %d not found\n",
+				 __func__, vsi_seid);
+			goto command_write_done;
+		}
+
+		vid = (unsigned)v;
+		ret = i40e_vsi_add_pvid(vsi, vid);
+		if (!ret)
+			dev_info(&pf->pdev->dev,
+				 "%s: add pvid: %d added to VSI %d\n",
+				 __func__, vid, vsi_seid);
+		else
+			dev_info(&pf->pdev->dev,
+				 "%s: add pvid: %d to VSI %d failed, ret=%d\n",
+				 __func__, vid, vsi_seid, ret);
+
+	} else if (strncmp(cmd_buf, "del pvid", 8) == 0) {
+		enum i40e_status_code ret;
+
+		cnt = sscanf(&cmd_buf[8], "%i", &vsi_seid);
+		if (cnt != 1) {
+			dev_info(&pf->pdev->dev,
+				 "%s: del pvid: bad command string, cnt=%d\n",
+				 __func__, cnt);
+			goto command_write_done;
+		}
+
+		vsi = i40e_dbg_find_vsi(pf, vsi_seid);
+		if (!vsi) {
+			dev_info(&pf->pdev->dev,
+				 "%s: del pvid: VSI %d not found\n",
+				 __func__, vsi_seid);
+			goto command_write_done;
+		}
+
+		ret = i40e_vsi_remove_pvid(vsi);
+		if (!ret)
+			dev_info(&pf->pdev->dev,
+				 "%s: del pvid: removed from VSI %d\n",
+				 __func__, vsi_seid);
+		else
+			dev_info(&pf->pdev->dev,
+				 "%s: del pvid: VSI %d failed, ret=%d\n",
+				 __func__, vsi_seid, ret);
+
+	} else if (strncmp(cmd_buf, "dump", 4) == 0) {
+		if (strncmp(&cmd_buf[5], "switch", 6) == 0) {
+			i40e_fetch_switch_configuration(pf, true);
+		} else if (strncmp(&cmd_buf[5], "vsi", 3) == 0) {
+			cnt = sscanf(&cmd_buf[8], "%i", &vsi_seid);
+			if (cnt > 0)
+				i40e_dbg_dump_vsi_seid(pf, vsi_seid);
+			else
+				i40e_dbg_dump_vsi_no_seid(pf);
+		} else if (strncmp(&cmd_buf[5], "veb", 3) == 0) {
+			cnt = sscanf(&cmd_buf[8], "%i", &vsi_seid);
+			if (cnt > 0)
+				i40e_dbg_dump_veb_seid(pf, vsi_seid);
+			else
+				i40e_dbg_dump_veb_all(pf);
+		} else if (strncmp(&cmd_buf[5], "desc", 4) == 0) {
+			int ring_id, desc_n;
+			if (strncmp(&cmd_buf[10], "rx", 2) == 0) {
+				cnt = sscanf(&cmd_buf[12],
+						"%i %i %i", &vsi_seid,
+						&ring_id, &desc_n);
+				i40e_dbg_dump_desc(cnt, vsi_seid, ring_id,
+						   desc_n, pf, true);
+			} else if (strncmp(&cmd_buf[10], "tx", 2)
+					== 0) {
+				cnt = sscanf(&cmd_buf[12],
+						"%i %i %i", &vsi_seid,
+						&ring_id, &desc_n);
+				i40e_dbg_dump_desc(cnt, vsi_seid, ring_id,
+						   desc_n, pf, false);
+			} else if (strncmp(&cmd_buf[10], "aq", 2)
+					== 0) {
+				i40e_dbg_dump_aq_desc(pf);
+			} else {
+				dev_info(&pf->pdev->dev,
+					"%s: dump desc tx <vsi_seid> <ring_id> [<desc_n>]\n",
+					__func__);
+				dev_info(&pf->pdev->dev,
+					"%s: dump desc rx <vsi_seid> <ring_id> [<desc_n>]\n",
+					__func__);
+				dev_info(&pf->pdev->dev,
+					"%s: dump desc aq\n", __func__);
+			}
+		} else if (strncmp(&cmd_buf[5], "stats", 5) == 0) {
+			dev_info(&pf->pdev->dev, "pf stats:\n");
+			i40e_dbg_dump_stats(pf, &pf->stats);
+			dev_info(&pf->pdev->dev, "pf stats_offsets:\n");
+			i40e_dbg_dump_stats(pf, &pf->stats_offsets);
+		} else if (strncmp(&cmd_buf[5], "reset stats", 11) == 0) {
+			dev_info(&pf->pdev->dev,
+				 "core reset count: %d\n", pf->corer_count);
+			dev_info(&pf->pdev->dev,
+				 "global reset count: %d\n", pf->globr_count);
+			dev_info(&pf->pdev->dev,
+				 "emp reset count: %d\n", pf->empr_count);
+			dev_info(&pf->pdev->dev,
+				 "pf reset count: %d\n", pf->pfr_count);
+		} else if (strncmp(&cmd_buf[5], "port", 4) == 0) {
+			struct i40e_aqc_query_port_ets_config_resp *bw_data;
+			struct i40e_dcbx_config *cfg =
+						&pf->hw.local_dcbx_config;
+			struct i40e_dcbx_config *r_cfg =
+						&pf->hw.remote_dcbx_config;
+			int i, ret;
+
+			bw_data = kzalloc(sizeof(
+				    struct i40e_aqc_query_port_ets_config_resp),
+					  GFP_KERNEL);
+			if (!bw_data) {
+				ret = -ENOMEM;
+				goto command_write_done;
+			}
+
+			ret = i40e_aq_query_port_ets_config(&pf->hw,
+							    pf->mac_seid,
+							    bw_data, NULL);
+			if (ret) {
+				dev_info(&pf->pdev->dev,
+					 "%s: Query Port ETS Config AQ command failed =0x%x\n",
+					 __func__, pf->hw.aq.asq_last_status);
+				kfree(bw_data);
+				bw_data = NULL;
+				goto command_write_done;
+			}
+			dev_info(&pf->pdev->dev,
+				 "%s: port bw: tc_valid=0x%x tc_strict_prio=0x%x, tc_bw_max=0x%04x,0x%04x\n",
+				 __func__, bw_data->tc_valid_bits,
+				 bw_data->tc_strict_priority_bits,
+				 le16_to_cpu(bw_data->tc_bw_max[0]),
+				 le16_to_cpu(bw_data->tc_bw_max[1]));
+			for (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) {
+				dev_info(&pf->pdev->dev, "%s: port bw: tc_bw_share=%d tc_bw_limit=%d\n",
+					 __func__,
+					 bw_data->tc_bw_share_credits[i],
+					 le16_to_cpu(bw_data->tc_bw_limits[i]));
+			}
+
+			kfree(bw_data);
+			bw_data = NULL;
+
+			dev_info(&pf->pdev->dev,
+				 "%s: port ets_cfg: willing=%d cbs=%d, maxtcs=%d\n",
+				 __func__, cfg->etscfg.willing, cfg->etscfg.cbs,
+				 cfg->etscfg.maxtcs);
+			for (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) {
+				dev_info(&pf->pdev->dev, "%s: port ets_cfg: %d prio_tc=%d tcbw=%d tctsa=%d\n",
+					 __func__, i,
+					 cfg->etscfg.prioritytable[i],
+					 cfg->etscfg.tcbwtable[i],
+					 cfg->etscfg.tsatable[i]);
+			}
+			for (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) {
+				dev_info(&pf->pdev->dev, "%s: port ets_rec: %d prio_tc=%d tcbw=%d tctsa=%d\n",
+					 __func__, i,
+					 cfg->etsrec.prioritytable[i],
+					 cfg->etsrec.tcbwtable[i],
+					 cfg->etsrec.tsatable[i]);
+			}
+			dev_info(&pf->pdev->dev,
+				 "%s: port pfc_cfg: willing=%d mbc=%d, pfccap=%d pfcenable=0x%x\n",
+				 __func__, cfg->pfc.willing, cfg->pfc.mbc,
+				 cfg->pfc.pfccap, cfg->pfc.pfcenable);
+			dev_info(&pf->pdev->dev,
+				 "%s: port app_table: num_apps=%d\n",
+				 __func__, cfg->numapps);
+			for (i = 0; i < cfg->numapps; i++) {
+				dev_info(&pf->pdev->dev, "%s: port app_table: %d prio=%d selector=%d protocol=0x%x\n",
+					 __func__, i, cfg->app[i].priority,
+					 cfg->app[i].selector,
+					 cfg->app[i].protocolid);
+			}
+			/* Peer TLV DCBX data */
+			dev_info(&pf->pdev->dev,
+				 "%s: remote port ets_cfg: willing=%d cbs=%d, maxtcs=%d\n",
+				 __func__, r_cfg->etscfg.willing,
+				 r_cfg->etscfg.cbs,
+				 r_cfg->etscfg.maxtcs);
+			for (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) {
+				dev_info(&pf->pdev->dev, "%s: remote port ets_cfg: %d prio_tc=%d tcbw=%d tctsa=%d\n",
+					 __func__, i,
+					 r_cfg->etscfg.prioritytable[i],
+					 r_cfg->etscfg.tcbwtable[i],
+					 r_cfg->etscfg.tsatable[i]);
+			}
+			for (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) {
+				dev_info(&pf->pdev->dev, "%s: remote port ets_rec: %d prio_tc=%d tcbw=%d tctsa=%d\n",
+					 __func__, i,
+					 r_cfg->etsrec.prioritytable[i],
+					 r_cfg->etsrec.tcbwtable[i],
+					 r_cfg->etsrec.tsatable[i]);
+			}
+			dev_info(&pf->pdev->dev,
+				 "%s: remote port pfc_cfg: willing=%d mbc=%d, pfccap=%d pfcenable=0x%x\n",
+				 __func__, r_cfg->pfc.willing,
+				 r_cfg->pfc.mbc,
+				 r_cfg->pfc.pfccap,
+				 r_cfg->pfc.pfcenable);
+			dev_info(&pf->pdev->dev,
+				 "%s: remote port app_table: num_apps=%d\n",
+				 __func__, r_cfg->numapps);
+			for (i = 0; i < r_cfg->numapps; i++) {
+				dev_info(&pf->pdev->dev, "%s: remote port app_table: %d prio=%d selector=%d protocol=0x%x\n",
+					 __func__, i,
+					 r_cfg->app[i].priority,
+					 r_cfg->app[i].selector,
+					 r_cfg->app[i].protocolid);
+			}
+		} else {
+			dev_info(&pf->pdev->dev,
+				"%s: dump desc tx <vsi_seid> <ring_id> [<desc_n>], dump desc rx <vsi_seid> <ring_id> [<desc_n>],\n",
+				__func__);
+			dev_info(&pf->pdev->dev,
+				"%s: dump switch, dump vsi [seid] or\n",
+				__func__);
+			dev_info(&pf->pdev->dev,
+				"%s: dump stats\n",
+				__func__);
+			dev_info(&pf->pdev->dev,
+				"%s: dump reset stats\n",
+				__func__);
+			dev_info(&pf->pdev->dev,
+				"%s: dump port\n",
+				__func__);
+			dev_info(&pf->pdev->dev,
+				 "%s:   dump debug fwdata <cluster_id> <table_id> <index>\n",
+				 __func__);
+		}
+
+	} else if (strncmp(cmd_buf, "msg_enable", 10) == 0) {
+		u32 level;
+		cnt = sscanf(&cmd_buf[10], "%i", &level);
+		if (cnt) {
+			if (I40E_DEBUG_USER & level) {
+				pf->hw.debug_mask = level;
+				dev_info(&pf->pdev->dev,
+					"%s: set hw.debug_mask = 0x%08x\n",
+					__func__, pf->hw.debug_mask);
+			}
+			pf->msg_enable = level;
+			dev_info(&pf->pdev->dev,
+				"%s: set msg_enable = 0x%08x\n",
+				__func__, pf->msg_enable);
+		} else {
+			dev_info(&pf->pdev->dev,
+				"%s: msg_enable = 0x%08x\n",
+				__func__, pf->msg_enable);
+		}
+	} else if (strncmp(cmd_buf, "pfr", 3) == 0) {
+		dev_info(&pf->pdev->dev, "%s: forcing PFR\n", __func__);
+		i40e_do_reset(pf, (1 << __I40E_PF_RESET_REQUESTED));
+
+	} else if (strncmp(cmd_buf, "corer", 5) == 0) {
+		dev_info(&pf->pdev->dev, "%s: forcing CoreR\n", __func__);
+		i40e_do_reset(pf, (1 << __I40E_CORE_RESET_REQUESTED));
+
+	} else if (strncmp(cmd_buf, "globr", 5) == 0) {
+		dev_info(&pf->pdev->dev, "%s: forcing GlobR\n", __func__);
+		i40e_do_reset(pf, (1 << __I40E_GLOBAL_RESET_REQUESTED));
+
+	} else if (strncmp(cmd_buf, "read", 4) == 0) {
+		u32 address;
+		u32 value;
+		cnt = sscanf(&cmd_buf[4], "%x", &address);
+		if (cnt != 1) {
+			dev_info(&pf->pdev->dev, "%s: read <reg>\n", __func__);
+			goto command_write_done;
+		}
+
+		/* check the range on address */
+		if (address >= I40E_MAX_REGISTER) {
+			dev_info(&pf->pdev->dev, "%s: read reg address 0x%08x too large\n",
+				 __func__, address);
+			goto command_write_done;
+		}
+
+		value = rd32(&pf->hw, address);
+		dev_info(&pf->pdev->dev, "%s: read: 0x%08x = 0x%08x\n",
+			 __func__, address, value);
+
+	} else if (strncmp(cmd_buf, "write", 5) == 0) {
+		u32 address, value;
+		cnt = sscanf(&cmd_buf[5], "%x %x",
+			&address, &value);
+		if (cnt != 2) {
+			dev_info(&pf->pdev->dev, "%s: write <reg> <value>\n",
+				__func__);
+			goto command_write_done;
+		}
+
+		/* check the range on address */
+		if (address >= I40E_MAX_REGISTER) {
+			dev_info(&pf->pdev->dev, "%s: write reg address 0x%08x too large\n",
+				 __func__, address);
+			goto command_write_done;
+		}
+		wr32(&pf->hw, address, value);
+		value = rd32(&pf->hw, address);
+		dev_info(&pf->pdev->dev, "%s: write: 0x%08x = 0x%08x\n",
+			 __func__, address, value);
+	} else if (strncmp(cmd_buf, "clear_stats", 11) == 0) {
+		if (strncmp(&cmd_buf[12], "vsi", 3) == 0) {
+			cnt = sscanf(&cmd_buf[15], "%d", &vsi_seid);
+			if (cnt == 0) {
+				int i;
+				for (i = 0; i < pf->hw.func_caps.num_vsis; i++)
+					i40e_vsi_reset_stats(pf->vsi[i]);
+				dev_info(&pf->pdev->dev,
+					"%s: vsi clear stats called for all vsi's\n",
+					__func__);
+			} else if (cnt == 1) {
+				vsi = i40e_dbg_find_vsi(pf, vsi_seid);
+				if (!vsi) {
+					dev_info(&pf->pdev->dev,
+						"%s: clear_stats vsi: bad vsi %d\n",
+						__func__, vsi_seid);
+					goto command_write_done;
+				}
+				i40e_vsi_reset_stats(vsi);
+				dev_info(&pf->pdev->dev,
+					"%s: vsi clear stats called for vsi %d\n",
+					__func__, vsi_seid);
+			} else {
+				dev_info(&pf->pdev->dev,
+					"%s: clear_stats vsi [seid]\n",
+					__func__);
+			}
+		} else if (strncmp(&cmd_buf[12], "pf", 2) == 0) {
+			i40e_pf_reset_stats(pf);
+			dev_info(&pf->pdev->dev,
+				"%s: pf clear stats called\n", __func__);
+		} else {
+			dev_info(&pf->pdev->dev,
+				"%s: clear_stats vsi [seid] or clear_stats pf\n",
+				__func__);
+		}
+	} else if ((strncmp(cmd_buf, "add fd_filter", 13) == 0) ||
+		   (strncmp(cmd_buf, "rem fd_filter", 13) == 0)) {
+		struct i40e_fdir_data fd_data;
+		enum i40e_status_code ret;
+		u16 packet_len, i, j = 0;
+		char *asc_packet;
+		bool add = false;
+
+		asc_packet = kzalloc(I40E_FDIR_MAX_RAW_PACKET_LOOKUP,
+				     GFP_KERNEL);
+		if (!asc_packet)
+			goto command_write_done;
+
+		fd_data.raw_packet = kzalloc(I40E_FDIR_MAX_RAW_PACKET_LOOKUP,
+					     GFP_KERNEL);
+
+		if (!fd_data.raw_packet) {
+			kfree(asc_packet);
+			asc_packet = NULL;
+			goto command_write_done;
+		}
+
+		if (strncmp(cmd_buf, "add", 3) == 0)
+			add = true;
+		cnt = sscanf(&cmd_buf[13],
+			     "%hx %2hhx %2hhx %hx %2hhx %2hhx %hx %x %hd %512s",
+			     &fd_data.q_index,
+			     &fd_data.flex_off, &fd_data.pctype,
+			     &fd_data.dest_vsi, &fd_data.dest_ctl,
+			     &fd_data.fd_status, &fd_data.cnt_index,
+			     &fd_data.fd_id, &packet_len, asc_packet);
+		if (cnt != 10) {
+			dev_info(&pf->pdev->dev,
+				 "%s: program fd_filter: bad command string, cnt=%d\n",
+				 __func__, cnt);
+			kfree(asc_packet);
+			asc_packet = NULL;
+			kfree(fd_data.raw_packet);
+			goto command_write_done;
+		}
+
+		/* fix packet length if user entered 0 */
+		if (packet_len == 0)
+			packet_len = I40E_FDIR_MAX_RAW_PACKET_LOOKUP;
+
+		/* make sure to check the max as well */
+		packet_len = min_t(u16,
+				   packet_len, I40E_FDIR_MAX_RAW_PACKET_LOOKUP);
+
+		dev_info(&pf->pdev->dev,
+			 "%s: FD raw packet:\n", __func__);
+		for (i = 0; i < packet_len; i++) {
+			sscanf(&asc_packet[j], "%2hhx ",
+			       &fd_data.raw_packet[i]);
+			j += 3;
+			snprintf(print_buf, 3, "%02x ", fd_data.raw_packet[i]);
+			print_buf += 3;
+			if ((i % 16) == 15) {
+				snprintf(print_buf, 1, "\n");
+				print_buf++;
+			}
+		}
+		dev_info(&pf->pdev->dev, "%s\n", print_buf_start);
+		ret = i40e_program_fdir_filter(&fd_data, pf, add);
+		if (!ret) {
+			dev_info(&pf->pdev->dev,
+				 "%s: Filter command send Status : Success\n",
+				 __func__);
+		} else {
+			dev_info(&pf->pdev->dev,
+				 "%s: Filter command send failed %d\n",
+				 __func__, ret);
+		}
+		kfree(fd_data.raw_packet);
+		fd_data.raw_packet = NULL;
+		kfree(asc_packet);
+		asc_packet = NULL;
+	} else if (strncmp(cmd_buf, "lldp", 4) == 0) {
+		if (strncmp(&cmd_buf[5], "stop", 4) == 0) {
+			int ret;
+			ret = i40e_aq_stop_lldp(&pf->hw, false, NULL);
+			if (ret) {
+				dev_info(&pf->pdev->dev,
+					 "%s: Stop LLDP AQ command failed =0x%x\n",
+					 __func__, pf->hw.aq.asq_last_status);
+				goto command_write_done;
+			}
+		} else if (strncmp(&cmd_buf[5], "start", 5) == 0) {
+			int ret;
+			ret = i40e_aq_start_lldp(&pf->hw, NULL);
+			if (ret) {
+				dev_info(&pf->pdev->dev,
+					 "%s: Start LLDP AQ command failed =0x%x\n",
+					 __func__, pf->hw.aq.asq_last_status);
+				goto command_write_done;
+			}
+		} else if (strncmp(&cmd_buf[5],
+			   "get local", 9) == 0) {
+			int ret, i;
+			u8 *buff;
+			u16 llen, rlen;
+			buff = kzalloc(I40E_LLDPDU_SIZE, GFP_KERNEL);
+			if (!buff)
+				goto command_write_done;
+
+			ret = i40e_aq_get_lldp_mib(&pf->hw, 0,
+						   I40E_AQ_LLDP_MIB_LOCAL,
+						   buff, I40E_LLDPDU_SIZE,
+						   &llen, &rlen, NULL);
+			if (ret) {
+				dev_info(&pf->pdev->dev,
+					 "%s: Get LLDP MIB (local) AQ command failed =0x%x\n",
+					 __func__, pf->hw.aq.asq_last_status);
+				kfree(buff);
+				buff = NULL;
+				goto command_write_done;
+			}
+			dev_info(&pf->pdev->dev,
+				 "%s: Get LLDP MIB (local) AQ buffer written back:\n",
+				 __func__);
+			for (i = 0; i < I40E_LLDPDU_SIZE; i++) {
+				snprintf(print_buf, 3, "%02x ", buff[i]);
+				print_buf += 3;
+				if ((i % 16) == 15) {
+					snprintf(print_buf, 1, "\n");
+					print_buf++;
+				}
+			}
+			dev_info(&pf->pdev->dev, "%s\n", print_buf_start);
+			kfree(buff);
+			buff = NULL;
+		} else if (strncmp(&cmd_buf[5],
+			   "get remote", 10) == 0) {
+			int ret, i;
+			u8 *buff;
+			u16 llen, rlen;
+			buff = kzalloc(I40E_LLDPDU_SIZE, GFP_KERNEL);
+			if (!buff)
+				goto command_write_done;
+
+			ret = i40e_aq_get_lldp_mib(&pf->hw,
+					I40E_AQ_LLDP_BRIDGE_TYPE_NEAREST_BRIDGE,
+					I40E_AQ_LLDP_MIB_LOCAL,
+					buff, I40E_LLDPDU_SIZE,
+					&llen, &rlen, NULL);
+			if (ret) {
+				dev_info(&pf->pdev->dev,
+					 "%s: Get LLDP MIB (remote) AQ command failed =0x%x\n",
+					 __func__, pf->hw.aq.asq_last_status);
+				kfree(buff);
+				buff = NULL;
+				goto command_write_done;
+			}
+			dev_info(&pf->pdev->dev,
+				 "%s: Get LLDP MIB (remote) AQ buffer written back:\n",
+				 __func__);
+			for (i = 0; i < I40E_LLDPDU_SIZE; i++) {
+				snprintf(print_buf, 3, "%02x ", buff[i]);
+				print_buf += 3;
+				if ((i % 16) == 15) {
+					snprintf(print_buf, 1, "\n");
+					print_buf++;
+				}
+			}
+			dev_info(&pf->pdev->dev, "%s\n", print_buf_start);
+			kfree(buff);
+			buff = NULL;
+		} else if (strncmp(&cmd_buf[5],
+			   "event on", 8) == 0) {
+			int ret;
+			ret = i40e_aq_cfg_lldp_mib_change_event(&pf->hw,
+								true, NULL);
+			if (ret) {
+				dev_info(&pf->pdev->dev,
+					 "%s: Config LLDP MIB Change Event (on) AQ command failed =0x%x\n",
+					 __func__, pf->hw.aq.asq_last_status);
+				goto command_write_done;
+			}
+		} else if (strncmp(&cmd_buf[5],
+			   "event off", 9) == 0) {
+			int ret;
+			ret = i40e_aq_cfg_lldp_mib_change_event(&pf->hw,
+								false, NULL);
+			if (ret) {
+				dev_info(&pf->pdev->dev,
+					 "%s: Config LLDP MIB Change Event (off) AQ command failed =0x%x\n",
+					 __func__, pf->hw.aq.asq_last_status);
+				goto command_write_done;
+			}
+		}
+	} else if (strncmp(cmd_buf, "nvm read", 8) == 0) {
+		u16 buffer_len, i, bytes;
+		u16 module;
+		u32 offset;
+		u16 *buff;
+		int ret;
+
+		cnt = sscanf(&cmd_buf[8], "%hx %x %hx",
+			     &module, &offset, &buffer_len);
+		if (cnt == 0) {
+			module = 0;
+			offset = 0;
+			buffer_len = 0;
+		} else if (cnt == 1) {
+			offset = 0;
+			buffer_len = 0;
+		} else if (cnt == 2) {
+			buffer_len = 0;
+		} else if (cnt > 3) {
+			dev_info(&pf->pdev->dev,
+				 "%s: nvm read: bad command string, cnt=%d\n",
+				 __func__, cnt);
+			goto command_write_done;
+		}
+
+		/* Read at least 512 words */
+		if (buffer_len == 0)
+			buffer_len = 512;
+
+		bytes = 2 * buffer_len;
+		buff = kzalloc(bytes, GFP_KERNEL);
+		if (!buff)
+			goto command_write_done;
+
+		ret = i40e_acquire_nvm(&pf->hw, I40E_RESOURCE_READ);
+		if (ret) {
+			dev_info(&pf->pdev->dev,
+				 "%s: Failed Acquiring NVM resource for read err=%d status=0x%x\n",
+				 __func__, ret, pf->hw.aq.asq_last_status);
+			kfree(buff);
+			goto command_write_done;
+		}
+
+		ret = i40e_aq_read_nvm(&pf->hw, module, (2 * offset),
+				       bytes, (u8 *)buff, true, NULL);
+		i40e_release_nvm(&pf->hw);
+		if (ret) {
+			dev_info(&pf->pdev->dev,
+				 "%s: Read NVM AQ failed err=%d status=0x%x\n",
+				 __func__, ret, pf->hw.aq.asq_last_status);
+		} else {
+			dev_info(&pf->pdev->dev,
+				 "%s: Read NVM module=0x%x offset=0x%x words=%d\n",
+				 __func__, module, offset, buffer_len);
+			for (i = 0; i < buffer_len; i++) {
+				if ((i % 16) == 0) {
+					snprintf(print_buf, 11, "\n0x%08x: ",
+								    offset + i);
+					print_buf += 11;
+				}
+				snprintf(print_buf, 5, "%04x ", buff[i]);
+				print_buf += 5;
+			}
+			dev_info(&pf->pdev->dev, "%s\n", print_buf_start);
+		}
+		kfree(buff);
+		buff = NULL;
+	} else {
+		dev_info(&pf->pdev->dev, "%s: unknown command '%s'\n",
+			 __func__, cmd_buf);
+		dev_info(&pf->pdev->dev,
+			"%s: available commands\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   add vsi [relay_seid]\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   del vsi [vsi_seid]\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   add relay <uplink_seid> <vsi_seid>\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   del relay <relay_seid>\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   add macaddr <vsi_seid> <aa:bb:cc:dd:ee:ff> [vlan]\n",
+			__func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   del macaddr <vsi_seid> <aa:bb:cc:dd:ee:ff> [vlan]\n",
+			__func__);
+		dev_info(&pf->pdev->dev, "%s:   add pvid <vsi_seid> <vid>\n",
+			__func__);
+		dev_info(&pf->pdev->dev, "%s:   del pvid <vsi_seid>\n",
+			__func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   dump switch\n",
+			__func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   dump vsi [seid]\n",
+			__func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   dump desc tx <vsi_seid> <ring_id> [<desc_n>]\n",
+			__func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   dump desc rx <vsi_seid> <ring_id> [<desc_n>]\n",
+			__func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   dump desc aq\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   dump stats\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   dump reset stats\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   msg_enable [level]\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   read <reg>\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   write <reg> <value>\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   clear_stats vsi [seid]\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   clear_stats pf\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   pfr\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   corer\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   globr\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   add fd_filter <dest q_index> <flex_off> <pctype> <dest_vsi> <dest_ctl> <fd_status> <cnt_index> <fd_id> <packet_len> <packet>\n",
+			__func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   rem fd_filter <dest q_index> <flex_off> <pctype> <dest_vsi> <dest_ctl> <fd_status> <cnt_index> <fd_id> <packet_len> <packet>\n",
+			__func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   lldp start\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   lldp stop\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   lldp get local\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   lldp get remote\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   lldp event on\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:   lldp event off\n", __func__);
+		dev_info(&pf->pdev->dev,
+			 "%s:   nvm read [module] [word_offset] [word_count]\n",
+			 __func__);
+	}
+
+command_write_done:
+	kfree(cmd_buf);
+	cmd_buf = NULL;
+	kfree(print_buf_start);
+	print_buf = NULL;
+	print_buf_start = NULL;
+	return count;
+}
+
+static const struct file_operations i40e_dbg_command_fops = {
+	.owner = THIS_MODULE,
+	.open =  simple_open,
+	.read =  i40e_dbg_command_read,
+	.write = i40e_dbg_command_write,
+};
+
+/**************************************************************
+ * netdev_ops
+ * The netdev_ops entry in debugfs is for giving the driver commands
+ * to be executed from the netdev operations.
+ **************************************************************/
+static char i40e_dbg_netdev_ops_buf[256] = "hello world";
+
+/**
+ * i40e_dbg_netdev_ops - read for netdev_ops datum
+ * @filp: the opened file
+ * @buffer: where to write the data for the user to read
+ * @count: the size of the user's buffer
+ * @ppos: file position offset
+ **/
+static ssize_t i40e_dbg_netdev_ops_read(struct file *filp, char __user *buffer,
+					size_t count, loff_t *ppos)
+{
+	struct i40e_pf *pf = filp->private_data;
+	char *buf;
+	int bytes_not_copied;
+	int len;
+	int buf_size = 256;
+
+	/* don't allow partal reads */
+	if (*ppos != 0)
+		return 0;
+	if (count < buf_size)
+		return -ENOSPC;
+
+	buf = kzalloc(buf_size, GFP_KERNEL);
+	if (!buf)
+		return -ENOSPC;
+
+	len = snprintf(buf, buf_size, "%s: %s\n",
+			pf->vsi[pf->lan_vsi]->netdev->name,
+			i40e_dbg_netdev_ops_buf);
+
+	bytes_not_copied = copy_to_user(buffer, buf, len);
+	kfree(buf);
+
+	if (bytes_not_copied < 0)
+		return bytes_not_copied;
+
+	*ppos = len;
+	return len;
+}
+
+/**
+ * i40e_dbg_netdev_ops_write - write into netdev_ops datum
+ * @filp: the opened file
+ * @buffer: where to find the user's data
+ * @count: the length of the user's data
+ * @ppos: file position offset
+ **/
+static ssize_t i40e_dbg_netdev_ops_write(struct file *filp,
+					const char __user *buffer,
+					size_t count, loff_t *ppos)
+{
+	struct i40e_pf *pf = filp->private_data;
+	int bytes_not_copied;
+	struct i40e_vsi *vsi;
+	int vsi_seid;
+	int i, cnt;
+
+	/* don't allow partial writes */
+	if (*ppos != 0)
+		return 0;
+	if (count >= sizeof(i40e_dbg_netdev_ops_buf))
+		return -ENOSPC;
+
+	memset(i40e_dbg_netdev_ops_buf, 0, sizeof(i40e_dbg_netdev_ops_buf));
+	bytes_not_copied = copy_from_user(i40e_dbg_netdev_ops_buf,
+					buffer, count);
+	if (bytes_not_copied < 0)
+		return bytes_not_copied;
+	else if (bytes_not_copied > 0)
+		count -= bytes_not_copied;
+	i40e_dbg_netdev_ops_buf[count] = '\0';
+
+	if (strncmp(i40e_dbg_netdev_ops_buf, "tx_timeout", 10) == 0) {
+		cnt = sscanf(&i40e_dbg_netdev_ops_buf[11], "%i", &vsi_seid);
+		if (cnt != 1) {
+			dev_info(&pf->pdev->dev,
+				"%s: tx_timeout <vsi_seid>\n", __func__);
+			goto netdev_ops_write_done;
+		}
+		vsi = i40e_dbg_find_vsi(pf, vsi_seid);
+		if (!vsi) {
+			dev_info(&pf->pdev->dev,
+				"%s: tx_timeout: VSI %d not found\n",
+				__func__, vsi_seid);
+			goto netdev_ops_write_done;
+		}
+		if (rtnl_trylock()) {
+			vsi->netdev->netdev_ops->ndo_tx_timeout(vsi->netdev);
+			rtnl_unlock();
+			dev_info(&pf->pdev->dev, "%s: tx_timeout called\n",
+				 __func__);
+		} else {
+			dev_info(&pf->pdev->dev, "%s: Could not acquire RTNL - please try again\n",
+				 __func__);
+		}
+	} else if (strncmp(i40e_dbg_netdev_ops_buf, "change_mtu", 10) == 0) {
+		int mtu;
+		cnt = sscanf(&i40e_dbg_netdev_ops_buf[11], "%i %i",
+			     &vsi_seid, &mtu);
+		if (cnt != 2) {
+			dev_info(&pf->pdev->dev,
+				"%s: change_mtu <vsi_seid> <mtu>\n", __func__);
+			goto netdev_ops_write_done;
+		}
+		vsi = i40e_dbg_find_vsi(pf, vsi_seid);
+		if (!vsi) {
+			dev_info(&pf->pdev->dev,
+				"%s: change_mtu: VSI %d not found\n",
+				__func__, vsi_seid);
+			goto netdev_ops_write_done;
+		}
+		if (rtnl_trylock()) {
+			vsi->netdev->netdev_ops->ndo_change_mtu(vsi->netdev,
+								mtu);
+			rtnl_unlock();
+			dev_info(&pf->pdev->dev, "%s: change_mtu called\n",
+				 __func__);
+		} else {
+			dev_info(&pf->pdev->dev, "%s: Could not acquire RTNL - please try again\n",
+				 __func__);
+		}
+
+	} else if (strncmp(i40e_dbg_netdev_ops_buf, "set_rx_mode", 11) == 0) {
+		cnt = sscanf(&i40e_dbg_netdev_ops_buf[11], "%i", &vsi_seid);
+		if (cnt != 1) {
+			dev_info(&pf->pdev->dev,
+				"%s: set_rx_mode <vsi_seid>\n", __func__);
+			goto netdev_ops_write_done;
+		}
+		vsi = i40e_dbg_find_vsi(pf, vsi_seid);
+		if (!vsi) {
+			dev_info(&pf->pdev->dev,
+				"%s: set_rx_mode: VSI %d not found\n",
+				__func__, vsi_seid);
+			goto netdev_ops_write_done;
+		}
+		if (rtnl_trylock()) {
+			vsi->netdev->netdev_ops->ndo_set_rx_mode(vsi->netdev);
+			rtnl_unlock();
+			dev_info(&pf->pdev->dev, "%s: set_rx_mode called\n",
+				 __func__);
+		} else {
+			dev_info(&pf->pdev->dev, "%s: Could not acquire RTNL - please try again\n",
+				 __func__);
+		}
+
+	} else if (strncmp(i40e_dbg_netdev_ops_buf, "napi", 4) == 0) {
+		cnt = sscanf(&i40e_dbg_netdev_ops_buf[4], "%i", &vsi_seid);
+		if (cnt != 1) {
+			dev_info(&pf->pdev->dev,
+				"%s: napi <vsi_seid>\n", __func__);
+			goto netdev_ops_write_done;
+		}
+		vsi = i40e_dbg_find_vsi(pf, vsi_seid);
+		if (!vsi) {
+			dev_info(&pf->pdev->dev,
+				"%s: napi: VSI %d not found\n",
+				__func__, vsi_seid);
+			goto netdev_ops_write_done;
+		}
+		for (i = 0; i < vsi->num_q_vectors; i++)
+			napi_schedule(&vsi->q_vectors[i].napi);
+		dev_info(&pf->pdev->dev, "%s: napi called\n", __func__);
+	} else {
+		dev_info(&pf->pdev->dev, "%s: unknown command '%s'\n",
+			__func__, i40e_dbg_netdev_ops_buf);
+		dev_info(&pf->pdev->dev,
+			"%s: available commands\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:    tx_timeout <vsi_seid>\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:    change_mtu <vsi_seid> <mtu>\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:    set_rx_mode <vsi_seid>\n", __func__);
+		dev_info(&pf->pdev->dev,
+			"%s:    napi <vsi_seid>\n", __func__);
+	}
+netdev_ops_write_done:
+	return count;
+}
+
+static const struct file_operations i40e_dbg_netdev_ops_fops = {
+	.owner = THIS_MODULE,
+	.open = simple_open,
+	.read = i40e_dbg_netdev_ops_read,
+	.write = i40e_dbg_netdev_ops_write,
+};
+
+/**
+ * i40e_dbg_pf_init - setup the debugfs directory for the pf
+ * @pf: the pf that is starting up
+ **/
+void i40e_dbg_pf_init(struct i40e_pf *pf)
+{
+	const char *name = pci_name(pf->pdev);
+	struct dentry *pfile __attribute__((unused));
+
+	pf->i40e_dbg_pf = debugfs_create_dir(name, i40e_dbg_root);
+	if (pf->i40e_dbg_pf) {
+		pfile = debugfs_create_file("command", 0600, pf->i40e_dbg_pf,
+					    pf, &i40e_dbg_command_fops);
+		pfile = debugfs_create_file("dump", 0600, pf->i40e_dbg_pf, pf,
+					    &i40e_dbg_dump_fops);
+		pfile = debugfs_create_file("netdev_ops", 0600, pf->i40e_dbg_pf,
+					    pf, &i40e_dbg_netdev_ops_fops);
+	} else {
+		dev_info(&pf->pdev->dev,
+			 "%s: debugfs entry for %s failed\n", __func__, name);
+	}
+}
+
+/**
+ * i40e_dbg_pf_exit - clear out the pf's debugfs entries
+ * @pf: the pf that is stopping
+ **/
+void i40e_dbg_pf_exit(struct i40e_pf *pf)
+{
+	debugfs_remove_recursive(pf->i40e_dbg_pf);
+	pf->i40e_dbg_pf = NULL;
+
+	kfree(i40e_dbg_dump_buf);
+	i40e_dbg_dump_buf = NULL;
+}
+
+/**
+ * i40e_dbg_init - start up debugfs for the driver
+ **/
+void i40e_dbg_init(void)
+{
+	i40e_dbg_root = debugfs_create_dir(i40e_driver_name, NULL);
+	if (i40e_dbg_root == NULL)
+		pr_info("%s: init of debugfs failed\n", __func__);
+}
+
+/**
+ * i40e_dbg_exit - clean out the driver's debugfs entries
+ **/
+void i40e_dbg_exit(void)
+{
+	debugfs_remove_recursive(i40e_dbg_root);
+	i40e_dbg_root = NULL;
+}
+
+#endif /* CONFIG_DEBUG_FS */
diff --git a/drivers/net/ethernet/intel/i40e/i40e_sysfs.c b/drivers/net/ethernet/intel/i40e/i40e_sysfs.c
new file mode 100644
index 0000000..401ef5f
--- /dev/null
+++ b/drivers/net/ethernet/intel/i40e/i40e_sysfs.c
@@ -0,0 +1,627 @@ 
+/*******************************************************************************
+
+  Intel Ethernet Controller XL710 Family Linux Driver
+  Copyright(c) 2013 Intel Corporation.
+
+  This program is free software; you can redistribute it and/or modify it
+  under the terms and conditions of the GNU General Public License,
+  version 2, as published by the Free Software Foundation.
+
+  This program is distributed in the hope it will be useful, but WITHOUT
+  ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+  FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+  more details.
+
+  You should have received a copy of the GNU General Public License along with
+  this program; if not, write to the Free Software Foundation, Inc.,
+  51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
+
+  The full GNU General Public License is included in this distribution in
+  the file called "COPYING".
+
+  Contact Information:
+  e1000-devel Mailing List <e1000-devel@lists.sourceforge.net>
+  Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
+
+*******************************************************************************/
+
+
+/* sysfs support for i40e */
+
+#include "i40e.h"
+
+#include <linux/module.h>
+#include <linux/types.h>
+#include <linux/sysfs.h>
+#include <linux/kobject.h>
+#include <linux/device.h>
+#include <linux/netdevice.h>
+
+
+/**
+ * i40e_sys_seid_from_name - parse out the number from the name
+ * @name: the name to be parsed
+ *
+ * returns a positive integer seid, or negative for error
+ **/
+static int i40e_sys_seid_from_name(const char *name)
+{
+	const char *cp = name;
+	long val;
+	int ret;
+
+	if (!cp)
+		return -1;
+
+	while (*cp && !(*cp >= '0' && *cp <= '9'))
+		cp++;
+
+	ret = kstrtol(cp, 10, &val);
+	if (ret == 0)
+		ret = val;
+
+	return ret;
+}
+
+/**
+ * i40e_sys_find_pf - find the pf for the kobj given
+ * @kobj: a sysfs object in the hw_switch
+ **/
+static struct i40e_pf *i40e_sys_find_pf(struct kobject *kobj)
+{
+	struct i40e_pf *pf = NULL;
+	struct i40e_netdev_priv *np;
+	struct net_device *netdev;
+	struct device *dev_kobj;
+
+	/* traverse up the model tree to find the root "hw_switch"
+	 * get the parent of "hw_switch" which is the main ethernet port
+	 * get it's netdev
+	 * convert the netdev to pf through it's VSI
+	 */
+	while (kobj) {
+		if (!strcmp(kobj->name, "hw_switch"))
+			break;  /* found it */
+		else
+			kobj = kobj->parent;
+	}
+	if (kobj) {
+		kobj = kobj->parent;
+		dev_kobj = container_of(kobj, struct device, kobj);
+		netdev = container_of(dev_kobj, struct net_device, dev);
+		np = netdev_priv(netdev);
+		pf = np->vsi->back;
+	}
+
+	return pf;
+}
+
+/**
+ * i40e_sys_store_ro - callback for readonly attributes in sysfs
+ * @kobj: object in the sysfs model
+ * @attr: attribute being read
+ * @buf: buffer to put data
+ * @count: buffer size
+ **/
+static ssize_t i40e_sys_store_ro(struct kobject *kobj,
+				 struct kobj_attribute *attr,
+				 const char *buf, size_t count)
+{
+	return -1;
+}
+
+/**
+ * i40e_sys_seid_read - read the VSI seid
+ **/
+static ssize_t i40e_sys_seid_read(struct kobject *kobj,
+				  struct kobj_attribute *attr,
+				  char *buf)
+{
+	int seid;
+
+	seid = i40e_sys_seid_from_name(kobj->name);
+	if (seid < 0)
+		return snprintf(buf, PAGE_SIZE,
+				"error: invalid VSI name %s\n", kobj->name);
+
+	return snprintf(buf, PAGE_SIZE, "%d\n", seid);
+}
+
+/**
+ * i40e_sys_vsi_type_read - read the VSI type
+ **/
+static ssize_t i40e_sys_vsi_type_read(struct kobject *kobj,
+				      struct kobj_attribute *attr,
+				      char *buf)
+{
+	struct i40e_pf *pf = i40e_sys_find_pf(kobj);
+	struct i40e_vsi *vsi = NULL;
+	char *type_str = NULL;
+	int seid;
+	int i;
+
+	if (!pf)
+		return snprintf(buf, PAGE_SIZE, "error: no adapter\n");
+
+	seid = i40e_sys_seid_from_name(kobj->name);
+	if (seid < 0)
+		return snprintf(buf, PAGE_SIZE,
+				"error: invalid VSI name %s\n", kobj->name);
+
+	for (i = 0; i < pf->hw.func_caps.num_vsis; i++) {
+		if (pf->vsi[i] && pf->vsi[i]->seid == seid) {
+			vsi = pf->vsi[i];
+			break;
+		}
+	}
+	if (vsi) {
+		switch (vsi->type) {
+		case I40E_VSI_MAIN:
+			type_str = "main";
+			break;
+		case I40E_VSI_VMDQ2:
+			type_str = "vmdq2";
+			break;
+		case I40E_VSI_SRIOV:
+			type_str = "sriov";
+			break;
+		case I40E_VSI_CTRL:
+			type_str = "crtl";
+			break;
+		case I40E_VSI_MIRROR:
+			type_str = "mirror";
+			break;
+		default:
+			type_str = "unknown";
+			break;
+		}
+	} else {
+		type_str = "(no vsi found)";
+	}
+
+	return snprintf(buf, PAGE_SIZE, "%s\n", type_str);
+}
+
+/**
+ * i40e_sys_veb_mode_read - read the VEB mode
+ **/
+static ssize_t i40e_sys_veb_mode_read(struct kobject *kobj,
+				      struct kobj_attribute *attr,
+				      char *buf)
+{
+	struct i40e_pf *pf = i40e_sys_find_pf(kobj);
+	struct i40e_veb *veb = NULL;
+	char *type_str = NULL;
+	int seid;
+	int i;
+
+	if (!pf)
+		return snprintf(buf, PAGE_SIZE, "error: no adapter\n");
+
+	seid = i40e_sys_seid_from_name(kobj->name);
+	if (seid < 0)
+		return snprintf(buf, PAGE_SIZE,
+				"error: invalid veb name %s\n", kobj->name);
+
+	for (i = 0; i < I40E_MAX_VEB; i++) {
+		if (pf->veb[i] && pf->veb[i]->seid == seid) {
+			veb = pf->veb[i];
+			break;
+		}
+	}
+	if (veb)
+		type_str = "veb";
+	else
+		type_str = "unknown";
+
+	return snprintf(buf, PAGE_SIZE, "%s\n", type_str);
+}
+
+/**
+ * i40e_sys_veb_svlan_read - read the VEB svlan
+ **/
+static ssize_t i40e_sys_veb_svlan_read(struct kobject *kobj,
+				       struct kobj_attribute *attr,
+				       char *buf)
+{
+	return snprintf(buf, PAGE_SIZE, "(not implemented)\n");
+}
+
+/**
+ * i40e_sys_veb_cvlan_read - read the VEB cvlan
+ **/
+static ssize_t i40e_sys_veb_cvlan_read(struct kobject *kobj,
+				       struct kobj_attribute *attr,
+				       char *buf)
+{
+	return snprintf(buf, PAGE_SIZE, "(not implemented)\n");
+}
+
+/**
+ * i40e_sys_hw_switch_hash_ptypes_read - read Hash Ptype Enabled bitmask
+ **/
+static ssize_t i40e_sys_hw_switch_hash_ptypes_read(struct kobject *kobj,
+						  struct kobj_attribute *attr,
+						  char *buf)
+{
+	struct i40e_pf *pf = i40e_sys_find_pf(kobj);
+	u64 hena;
+
+	if (!pf)
+		return snprintf(buf, PAGE_SIZE, "error: no adapter\n");
+	hena = rd32(&pf->hw, I40E_PFQF_HENA(0));
+	hena |= ((u64)rd32(&pf->hw, I40E_PFQF_HENA(1)) << 32);
+
+	return snprintf(buf, PAGE_SIZE, "%016llX\n", hena);
+}
+
+static int match_str(const char *cmd, const char *str)
+{
+	while (*cmd && *str && *cmd == *str) {
+		cmd++;
+		str++;
+	}
+	if (*cmd == '\n')
+		cmd++;
+	if (*str || *cmd)
+		return 0;
+	return 1;
+}
+
+/**
+ * i40e_sys_hw_switch_hash_ptypes_write - Write to Hash Ptype Enabled bitmask
+ **/
+static ssize_t i40e_sys_hw_switch_hash_ptypes_write(struct kobject *kobj,
+						  struct kobj_attribute *attr,
+						  const char *buf, size_t count)
+{
+	struct i40e_pf *pf = i40e_sys_find_pf(kobj);
+	char tmp_buf[80];
+	u64 hena;
+	int ret;
+
+	if (!pf)
+		return snprintf(tmp_buf, sizeof(tmp_buf), "error: no adapter\n");
+	ret = kstrtoull(buf, 16, &hena);
+	if (ret == 0) {
+		wr32(&pf->hw, I40E_PFQF_HENA(0), (u32)hena);
+		wr32(&pf->hw, I40E_PFQF_HENA(1), (u32)(hena >> 32));
+		hena = rd32(&pf->hw, I40E_PFQF_HENA(0));
+		hena |= ((u64)rd32(&pf->hw, I40E_PFQF_HENA(1)) << 32);
+		return snprintf(tmp_buf, sizeof(tmp_buf), "%016llX\n", hena);
+	}
+	return snprintf(tmp_buf, sizeof(tmp_buf), "(error: invalid value)\n");
+}
+
+/**
+ * i40e_sys_hw_switch_hash_type_read - read Hash Type set for now
+ **/
+static ssize_t i40e_sys_hw_switch_hash_type_read(struct kobject *kobj,
+						  struct kobj_attribute *attr,
+						  char *buf)
+{
+	struct i40e_pf *pf = i40e_sys_find_pf(kobj);
+	u32 reg;
+	bool symmetric;
+
+	if (!pf)
+		return snprintf(buf, PAGE_SIZE, "error: no adapter\n");
+
+	reg = rd32(&pf->hw, I40E_PRTQF_CTL_0);
+	if (reg & I40E_PRTQF_CTL_0_HSYM_ENA_MASK)
+		symmetric = true;
+	else
+		symmetric = false;
+
+	return snprintf(buf, PAGE_SIZE, "%s\n",
+			(symmetric ? "symmetric" : "nonsymmetric"));
+}
+
+/**
+ * i40e_sys_hw_switch_hash_type_write - Set a new Hash type for pf
+ **/
+static ssize_t i40e_sys_hw_switch_hash_type_write(struct kobject *kobj,
+						  struct kobj_attribute *attr,
+						  const char *buf, size_t count)
+{
+	struct i40e_pf *pf = i40e_sys_find_pf(kobj);
+	u32 reg;
+	char tmp_buf[80];
+	u64 hena;
+	int i;
+
+	if (!pf)
+		return snprintf(tmp_buf, sizeof(tmp_buf), "error: no adapter\n");
+
+	reg = rd32(&pf->hw, I40E_PRTQF_CTL_0);
+
+	if (match_str(buf, "symmetric"))
+		reg |= I40E_PRTQF_CTL_0_HSYM_ENA_MASK;
+	else if (match_str(buf, "nonsymmetric"))
+		reg &= ~I40E_PRTQF_CTL_0_HSYM_ENA_MASK;
+	else
+		return snprintf(tmp_buf, sizeof(tmp_buf), "error: invalid value\n");
+
+	wr32(&pf->hw, I40E_PRTQF_CTL_0, reg);
+
+	/* Enable the symmetric hash for each of the enabled packet types */
+	hena = rd32(&pf->hw, I40E_PFQF_HENA(0));
+	hena |= ((u64)rd32(&pf->hw, I40E_PFQF_HENA(1)) << 32);
+	for (i = 0; i < sizeof(u64); i++) {
+		if (hena & ((u64)0x1 << i))
+			wr32(&pf->hw, I40E_GLQF_HSYM(i), 0x1);
+	}
+
+	return snprintf(tmp_buf, sizeof(tmp_buf), buf);
+}
+
+/* VSI attributes */
+static struct kobj_attribute i40e_sys_vsi_seid_attr =
+	__ATTR(seid, 0444, i40e_sys_seid_read, i40e_sys_store_ro);
+static struct kobj_attribute i40e_sys_vsi_type_attr =
+	__ATTR(type, 0444, i40e_sys_vsi_type_read, i40e_sys_store_ro);
+
+static struct attribute *i40e_sys_vsi_attrs[] = {
+	&i40e_sys_vsi_seid_attr.attr,
+	&i40e_sys_vsi_type_attr.attr,
+	NULL
+};
+
+static struct attribute_group i40e_sys_vsi_attr_group = {
+	.attrs = i40e_sys_vsi_attrs,
+};
+
+/* VEB (relay) attributes */
+static struct kobj_attribute i40e_sys_veb_seid_attr =
+	__ATTR(seid, 0444, i40e_sys_seid_read, i40e_sys_store_ro);
+static struct kobj_attribute i40e_sys_veb_mode_attr =
+	__ATTR(mode, 0444, i40e_sys_veb_mode_read, i40e_sys_store_ro);
+static struct kobj_attribute i40e_sys_veb_svlan_attr =
+	__ATTR(svlan, 0444, i40e_sys_veb_svlan_read, i40e_sys_store_ro);
+static struct kobj_attribute i40e_sys_veb_cvlan_attr =
+	__ATTR(cvlan, 0444, i40e_sys_veb_cvlan_read, i40e_sys_store_ro);
+
+static struct attribute *i40e_sys_veb_attrs[] = {
+	&i40e_sys_veb_seid_attr.attr,
+	&i40e_sys_veb_mode_attr.attr,
+	&i40e_sys_veb_svlan_attr.attr,
+	&i40e_sys_veb_cvlan_attr.attr,
+	NULL
+};
+
+static struct attribute_group i40e_sys_veb_attr_group = {
+	.attrs = i40e_sys_veb_attrs,
+};
+
+/* hw-switch attributes */
+static struct kobj_attribute i40e_sys_hw_switch_hash_ptypes_attr =
+	__ATTR(hash_ptypes, 0644, i40e_sys_hw_switch_hash_ptypes_read,
+	i40e_sys_hw_switch_hash_ptypes_write);
+static struct kobj_attribute i40e_sys_hw_switch_hash_type_attr =
+	__ATTR(hash_type, S_IWUSR | S_IRUGO, i40e_sys_hw_switch_hash_type_read,
+	i40e_sys_hw_switch_hash_type_write);
+
+static struct attribute *i40e_sys_hw_switch_attrs[] = {
+	&i40e_sys_hw_switch_hash_ptypes_attr.attr,
+	&i40e_sys_hw_switch_hash_type_attr.attr,
+	NULL
+};
+
+static struct attribute_group i40e_sys_hw_switch_attr_group = {
+	.attrs = i40e_sys_hw_switch_attrs,
+};
+
+/**
+ * i40e_sys_add_vsi - add a VSI to the sysfs model
+ * @vsi: the VSI to be added
+ *
+ * Add the VSI into the sysfs model under the uplinked VEB
+ **/
+enum i40e_status_code i40e_sys_add_vsi(struct i40e_vsi *vsi)
+{
+	struct i40e_pf *pf;
+	char name[16];
+	u16 parent_veb;
+	int ret;
+
+	if (!vsi || !vsi->back->switch_kobj)
+		return I40E_ERR_PARAM;
+
+	/* don't reveal the FDIR VSI in sysfs */
+	if (vsi->type == I40E_VSI_FDIR)
+		return I40E_SUCCESS;
+
+	pf = vsi->back;
+	snprintf(name, sizeof(name), "vsi_%03d", vsi->seid);
+
+	if (vsi->uplink_seid == pf->mac_seid) {
+		/* no VEB involved, this is a loner VSI */
+		vsi->kobj = kobject_create_and_add(name, pf->switch_kobj);
+	} else {
+		/* find the parent kobj */
+		for (parent_veb = 0; parent_veb < I40E_MAX_VEB; parent_veb++) {
+			if (pf->veb[parent_veb]
+			    && pf->veb[parent_veb]->seid == vsi->uplink_seid)
+				break;
+		}
+		if ((parent_veb == I40E_MAX_VEB) ||
+		    (pf->veb[parent_veb]->kobj == NULL))
+			return I40E_ERR_DEVICE_NOT_SUPPORTED;
+		vsi->kobj = kobject_create_and_add(name,
+						   pf->veb[parent_veb]->kobj);
+	}
+	if (!vsi->kobj)
+		return I40E_ERR_CONFIG;
+
+	ret = sysfs_create_group(vsi->kobj, &i40e_sys_vsi_attr_group);
+	if (ret < 0)
+		dev_info(&pf->pdev->dev, "%s: create_group failed: %d\n",
+			 __func__, ret);
+	if (vsi->netdev) {
+		ret = sysfs_create_link(vsi->kobj,
+					&vsi->netdev->dev.kobj, "net");
+		if (ret < 0)
+			dev_info(&pf->pdev->dev, "%s: create_link failed: %d\n",
+				 __func__, ret);
+	}
+
+	return I40E_SUCCESS;
+}
+
+/**
+ * i40e_sys_del_vsi - remove a VSI from the sysfs model
+ * @vsi: the VSI to remove
+ **/
+void i40e_sys_del_vsi(struct i40e_vsi *vsi)
+{
+	if (vsi && vsi->kobj) {
+		sysfs_remove_link(vsi->kobj, "net");
+		sysfs_remove_group(vsi->kobj, &i40e_sys_vsi_attr_group);
+		kobject_put(vsi->kobj);
+		vsi->kobj = NULL;
+	}
+}
+
+/**
+ * i40e_sys_add_veb - add a VEB to the sysfs model
+ * @vsi: the VSI to be added
+ *
+ * Add the VEB into the sysfs model under the uplink VEB, or under the
+ * top-of-tree for the switch model
+ **/
+enum i40e_status_code i40e_sys_add_veb(struct i40e_veb *veb)
+{
+	struct i40e_pf *pf;
+	char name[16];
+	u16 parent_veb;
+	struct kobject *kobj = NULL;
+	int ret;
+
+	if (!veb)
+		return I40E_ERR_PARAM;
+	if (veb->kobj)
+		return I40E_SUCCESS;
+
+	/* find the parent kobj */
+	pf = veb->pf;
+	if (veb->uplink_seid == pf->mac_seid) {
+		/* top-of-tree, primary switch */
+		kobj = pf->switch_kobj;
+	} else if (veb->uplink_seid == 0) {
+		/* floater, put near top-of-tree */
+		kobj = pf->switch_kobj;
+	} else {
+		for (parent_veb = 0; parent_veb < I40E_MAX_VEB; parent_veb++) {
+			if (pf->veb[parent_veb]
+			    && pf->veb[parent_veb]->seid == veb->uplink_seid)
+				break;
+		}
+		if ((parent_veb != I40E_MAX_VEB) &&
+		    (pf->veb[parent_veb]->kobj != NULL))
+			kobj = pf->veb[parent_veb]->kobj;
+	}
+
+	if (!kobj)
+		return I40E_ERR_DEVICE_NOT_SUPPORTED;
+
+	/* link it up */
+	if (veb->uplink_seid)
+		snprintf(name, sizeof(name), "relay_%03d", veb->seid);
+	else
+		snprintf(name, sizeof(name), "floating_relay_%03d", veb->seid);
+
+	veb->kobj = kobject_create_and_add(name, kobj);
+	if (!veb->kobj)
+		return I40E_ERR_CONFIG;
+
+	ret = sysfs_create_group(veb->kobj, &i40e_sys_veb_attr_group);
+	if (ret < 0)
+		dev_info(&pf->pdev->dev, "%s: create_group failed: %d\n",
+			 __func__, ret);
+
+	return I40E_SUCCESS;
+}
+
+/**
+ * i40e_sys_del_veb - remove a VEB from the sysfs model
+ * @vsi: the VSI to remove
+ **/
+void i40e_sys_del_veb(struct i40e_veb *veb)
+{
+	if (veb && veb->kobj) {
+		sysfs_remove_group(veb->kobj, &i40e_sys_veb_attr_group);
+		kobject_put(veb->kobj);
+		veb->kobj = NULL;
+	}
+}
+
+/**
+ * i40e_sys_add_switch - add the top-of-tree for the device switch model
+ * @pf: the device
+ **/
+static enum i40e_status_code i40e_sys_add_switch(struct i40e_pf *pf)
+{
+	struct net_device *netdev;
+	int ret = I40E_SUCCESS;
+
+	if (!pf || !pf->vsi[pf->lan_vsi])
+		return I40E_ERR_NO_AVAILABLE_VSI;
+
+	netdev = pf->vsi[pf->lan_vsi]->netdev;
+	if (!netdev)
+		return I40E_ERR_ADAPTER_STOPPED;
+
+	pf->switch_kobj = kobject_create_and_add("hw_switch",
+						 &(netdev->dev.kobj));
+	if (!pf->switch_kobj)
+		return I40E_ERR_CONFIG;
+
+	ret = sysfs_create_group(pf->switch_kobj,
+				 &i40e_sys_hw_switch_attr_group);
+	if (ret < 0)
+		dev_info(&pf->pdev->dev, "%s: create_group failed: %d\n",
+			 __func__, ret);
+
+	i40e_sys_add_vsi(pf->vsi[pf->lan_vsi]);
+
+	return ret;
+}
+
+/**
+ * i40e_sys_del_switch - remove the switch model top-of-tree
+ * @pf: the device
+ **/
+static void i40e_sys_del_switch(struct i40e_pf *pf)
+{
+	if (pf->switch_kobj) {
+		int v;
+
+		for (v = 0; v < pf->hw.func_caps.num_vsis; v++)
+			i40e_sys_del_vsi(pf->vsi[v]);
+		for (v = 0; v < I40E_MAX_VEB; v++)
+			i40e_sys_del_veb(pf->veb[v]);
+
+		sysfs_remove_group(pf->switch_kobj,
+				   &i40e_sys_hw_switch_attr_group);
+		kobject_put(pf->switch_kobj);
+		pf->switch_kobj = NULL;
+	}
+}
+
+/**
+ * i40e_sys_init - fire up the sysfs model for the switch
+ * @pf: the device
+ **/
+enum i40e_status_code i40e_sys_init(struct i40e_pf *pf)
+{
+	return i40e_sys_add_switch(pf);
+}
+
+/**
+ * i40e_sys_exit - shut down the sysfs model for the switch
+ * @pf: the device
+ **/
+void i40e_sys_exit(struct i40e_pf *pf)
+{
+	i40e_sys_del_switch(pf);
+}