Patchwork [PULL,04/42] block: better error message for read only format name

login
register
mail settings
Submitter Stefan Hajnoczi
Date Aug. 22, 2013, 8:11 p.m.
Message ID <1377202298-22896-5-git-send-email-stefanha@redhat.com>
Download mbox | patch
Permalink /patch/269212/
State New
Headers show

Comments

Stefan Hajnoczi - Aug. 22, 2013, 8:11 p.m.
From: Fam Zheng <famz@redhat.com>

When user tries to use read-only whitelist format in the command line
option, failure message was "'foo' invalid format". It might be invalid
only for writable, but valid for read-only, so it is confusing. Give the
user easier to understand information.

Signed-off-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 blockdev.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Patch

diff --git a/blockdev.c b/blockdev.c
index bc7016a..d3500c6 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -487,7 +487,11 @@  static DriveInfo *blockdev_init(QemuOpts *all_opts,
 
         drv = bdrv_find_whitelisted_format(buf, ro);
         if (!drv) {
-            error_report("'%s' invalid format", buf);
+            if (!ro && bdrv_find_whitelisted_format(buf, !ro)) {
+                error_report("'%s' can be only used as read-only device.", buf);
+            } else {
+                error_report("'%s' invalid format", buf);
+            }
             return NULL;
         }
     }