Patchwork [AArch64] Fix configure test for AArch64 dwarf2 debug_line

login
register
mail settings
Submitter Julian Brown
Date Aug. 22, 2013, 2:26 p.m.
Message ID <20130822152615.64e0f360@octopus>
Download mbox | patch
Permalink /patch/269086/
State New
Headers show

Comments

Julian Brown - Aug. 22, 2013, 2:26 p.m.
Hi,

This patch fixes what I assume to be a simple omission from the
configure test for debug_line assembler support in gcc/configure. This
tripped an obscure corner-case test in our build infrastructure, which
is fixed by the attached patch, but I don't otherwise have a way of
testing the patch at present.

OK to apply?

Thanks,

Julian

ChangeLog

    gcc/
    * configure.ac: Add aarch64 to list of arches which use "nop" in
    debug_line test.
    * configure: Regenerate.
Richard Earnshaw - Aug. 22, 2013, 3:02 p.m.
On 22/08/13 15:26, Julian Brown wrote:
> Hi,
> 
> This patch fixes what I assume to be a simple omission from the
> configure test for debug_line assembler support in gcc/configure. This
> tripped an obscure corner-case test in our build infrastructure, which
> is fixed by the attached patch, but I don't otherwise have a way of
> testing the patch at present.
> 
> OK to apply?
> 
> Thanks,
> 
> Julian
> 
> ChangeLog
> 
>     gcc/
>     * configure.ac: Add aarch64 to list of arches which use "nop" in
>     debug_line test.
>     * configure: Regenerate.
> 
> 

This is OK, though it seems to me that, given how old gas 2.11 is now,
it might be better to have a 'default' for this test and then catch the
systems that are different.

R.

> aarch64-debug-linux-configure-fix-1.diff
> 
> 
> Index: gcc/configure.ac
> ===================================================================
> --- gcc/configure.ac	(revision 201919)
> +++ gcc/configure.ac	(working copy)
> @@ -4219,8 +4219,9 @@ esac
>  # ??? Once 2.11 is released, probably need to add first known working
>  # version to the per-target configury.
>  case "$cpu_type" in
> -  alpha | arm | avr | bfin | cris | i386 | m32c | m68k | microblaze | mips \
> -  | pa | rs6000 | score | sparc | spu | tilegx | tilepro | xstormy16 | xtensa)
> +  aarch64 | alpha | arm | avr | bfin | cris | i386 | m32c | m68k | microblaze
> +  | mips | pa | rs6000 | score | sparc | spu | tilegx | tilepro | xstormy16
> +  | xtensa)
>      insn="nop"
>      ;;
>    ia64 | s390)
>
Paolo Carlini - Aug. 22, 2013, 4:23 p.m.
.. I'm double checking, but I think that this commit broke the 
bootstrap. I'm seeing:

/scratch/Gcc/svn-dirs/trunk/gcc/configure: line 26121: syntax error near 
unexpected token `newline'
/scratch/Gcc/svn-dirs/trunk/gcc/configure: line 26121: `  aarch64 | 
alpha | arm | avr | bfin | cris | i386 | m32c | m68k | microblaze'
make[1]: *** [configure-gcc] Error 1

Paolo.
Paolo Carlini - Aug. 22, 2013, 4:26 p.m.
.. missing backslashes I would say.

Paolo.

Patch

Index: gcc/configure.ac
===================================================================
--- gcc/configure.ac	(revision 201919)
+++ gcc/configure.ac	(working copy)
@@ -4219,8 +4219,9 @@  esac
 # ??? Once 2.11 is released, probably need to add first known working
 # version to the per-target configury.
 case "$cpu_type" in
-  alpha | arm | avr | bfin | cris | i386 | m32c | m68k | microblaze | mips \
-  | pa | rs6000 | score | sparc | spu | tilegx | tilepro | xstormy16 | xtensa)
+  aarch64 | alpha | arm | avr | bfin | cris | i386 | m32c | m68k | microblaze
+  | mips | pa | rs6000 | score | sparc | spu | tilegx | tilepro | xstormy16
+  | xtensa)
     insn="nop"
     ;;
   ia64 | s390)