| Message ID | 1377165637-8116-1-git-send-email-B38611@freescale.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
> diff --git a/drivers/net/ethernet/freescale/fec_main.c > b/drivers/net/ethernet/freescale/fec_main.c > index 77ea0db..4ea1555 100644 > --- a/drivers/net/ethernet/freescale/fec_main.c > +++ b/drivers/net/ethernet/freescale/fec_main.c > @@ -835,7 +835,7 @@ fec_enet_rx(struct net_device *ndev, int budget) > int pkt_received = 0; > struct bufdesc_ex *ebdp = NULL; > bool vlan_packet_rcvd = false; > - u16 vlan_tag; > + u16 vlan_tag = 0; > > #ifdef CONFIG_M532x > flush_cache_all(); Acked > -- > 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Ping... > -----Original Message----- > From: Li Frank-B20596 > Sent: Thursday, August 22, 2013 10:16 PM > To: Duan Fugang-B38611; Zhou Luwei-B45643; davem@davemloft.net > Cc: netdev@vger.kernel.org; shawn.guo@linaro.org; > bhutchings@solarflare.com; Estevam Fabio-R49496; > stephen@networkplumber.org > Subject: RE: [PATCH] net: fec: fix build warning of used uninitialized > variable > > > diff --git a/drivers/net/ethernet/freescale/fec_main.c > > b/drivers/net/ethernet/freescale/fec_main.c > > index 77ea0db..4ea1555 100644 > > --- a/drivers/net/ethernet/freescale/fec_main.c > > +++ b/drivers/net/ethernet/freescale/fec_main.c > > @@ -835,7 +835,7 @@ fec_enet_rx(struct net_device *ndev, int budget) > > int pkt_received = 0; > > struct bufdesc_ex *ebdp = NULL; > > bool vlan_packet_rcvd = false; > > - u16 vlan_tag; > > + u16 vlan_tag = 0; > > > > #ifdef CONFIG_M532x > > flush_cache_all(); > > Acked > > > -- > > 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, David, Please don't ignore the patch too. Thanks, Andy > -----Original Message----- > From: Duan Fugang-B38611 > Sent: Friday, August 30, 2013 10:48 AM > To: davem@davemloft.net > Cc: netdev@vger.kernel.org; shawn.guo@linaro.org; > bhutchings@solarflare.com; Estevam Fabio-R49496; > stephen@networkplumber.org; Li Frank-B20596 > Subject: RE: [PATCH] net: fec: fix build warning of used uninitialized > variable > > Ping... > > > -----Original Message----- > > From: Li Frank-B20596 > > Sent: Thursday, August 22, 2013 10:16 PM > > To: Duan Fugang-B38611; Zhou Luwei-B45643; davem@davemloft.net > > Cc: netdev@vger.kernel.org; shawn.guo@linaro.org; > > bhutchings@solarflare.com; Estevam Fabio-R49496; > > stephen@networkplumber.org > > Subject: RE: [PATCH] net: fec: fix build warning of used uninitialized > > variable > > > > > diff --git a/drivers/net/ethernet/freescale/fec_main.c > > > b/drivers/net/ethernet/freescale/fec_main.c > > > index 77ea0db..4ea1555 100644 > > > --- a/drivers/net/ethernet/freescale/fec_main.c > > > +++ b/drivers/net/ethernet/freescale/fec_main.c > > > @@ -835,7 +835,7 @@ fec_enet_rx(struct net_device *ndev, int budget) > > > int pkt_received = 0; > > > struct bufdesc_ex *ebdp = NULL; > > > bool vlan_packet_rcvd = false; > > > - u16 vlan_tag; > > > + u16 vlan_tag = 0; > > > > > > #ifdef CONFIG_M532x > > > flush_cache_all(); > > > > Acked > > > > > -- > > > 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 77ea0db..4ea1555 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -835,7 +835,7 @@ fec_enet_rx(struct net_device *ndev, int budget) int pkt_received = 0; struct bufdesc_ex *ebdp = NULL; bool vlan_packet_rcvd = false; - u16 vlan_tag; + u16 vlan_tag = 0; #ifdef CONFIG_M532x flush_cache_all();
drivers/net/ethernet/freescale/fec_main.c:838 warning: 'vlan_tag' may be used uninitialized in this function note: 'vlan_tag' was declared here Compiler with the warning option: -Wuninitialized, the warning will be reported. Signed-off-by: Fugang Duan <B38611@freescale.com> --- drivers/net/ethernet/freescale/fec_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)