| Message ID | 1377103771-1590-2-git-send-email-mschmidt@redhat.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 08/21/2013 08:49 PM, Michal Schmidt wrote: > Since commit 82dc3c63 netif_napi_add() produces an error message if Please also specify that commit's summary line in parens. > a NAPI poll weight greater than 64 is requested. > jme requests a quarter of the rx ring size as the NAPI weight. > jme's rx ring size is 1 << 9 = 512. > Use the standard NAPI weight. > Signed-off-by: Michal Schmidt <mschmidt@redhat.com> > CC: Guo-Fu Tseng <cooldavid@cooldavid.org> WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c index 7fbe6ab..23de82a 100644 --- a/drivers/net/ethernet/jme.c +++ b/drivers/net/ethernet/jme.c @@ -3069,7 +3069,7 @@ jme_init_one(struct pci_dev *pdev, jwrite32(jme, JME_APMC, apmc); } - NETIF_NAPI_SET(netdev, &jme->napi, jme_poll, jme->rx_ring_size >> 2) + NETIF_NAPI_SET(netdev, &jme->napi, jme_poll, NAPI_POLL_WEIGHT) spin_lock_init(&jme->phy_lock); spin_lock_init(&jme->macaddr_lock);
Since commit 82dc3c63 netif_napi_add() produces an error message if a NAPI poll weight greater than 64 is requested. jme requests a quarter of the rx ring size as the NAPI weight. jme's rx ring size is 1 << 9 = 512. Use the standard NAPI weight. Signed-off-by: Michal Schmidt <mschmidt@redhat.com> CC: Guo-Fu Tseng <cooldavid@cooldavid.org> --- drivers/net/ethernet/jme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)