From patchwork Wed Aug 21 14:28:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 268818 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 1D3142C0090 for ; Thu, 22 Aug 2013 00:29:00 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; q=dns; s=default; b=qKAVuTEHnPL+TETY q16RxhhsJWg98WGVVfbzSHSJddWbIIg6swhI1vg1/nx6Hmjfc8yYTPYoLbTtY3+j fsL3iTPq6v74Z8h6hzTMFmtwFPtz8X19DI6/dF70crgCasKuPOfxIp28Ri3IIttE BjRp2krOjqjgSfW8vsLVV+0Uz0M= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; s=default; bh=Orse0PrYita6jq46Xv7L19 auvJM=; b=samfSqYl/FFFwYZPYF/SN2akrBMtnH7oiU/S8zIeA38u/Ej9jO125n tkd2QCttb9FNXJfYeDPQ33A4OzkG7htGH0OgJ54xSz3Sw+Wye4YLKaMl6BYL7WiM XGyBRGsmFdn17AlUJNhCmbOR4/3yBrBm1jOTkr5n7/slybFwOnFds= Received: (qmail 32498 invoked by alias); 21 Aug 2013 14:28:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 32488 invoked by uid 89); 21 Aug 2013 14:28:52 -0000 X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD autolearn=ham version=3.3.2 Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 21 Aug 2013 14:28:50 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id EAD33225; Wed, 21 Aug 2013 16:28:47 +0200 (CEST) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id nEcT89kWHxnR; Wed, 21 Aug 2013 16:28:45 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.110]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id A5E26224; Wed, 21 Aug 2013 16:28:45 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.14.5+Sun/8.14.5/Submit) id r7LESiw3004783; Wed, 21 Aug 2013 16:28:44 +0200 (MEST) From: Rainer Orth To: Alexander Ivchenko Cc: "Joseph S. Myers" , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Enable non-complex math builtins from C99 for Bionic References: Date: Wed, 21 Aug 2013 16:28:44 +0200 In-Reply-To: (Alexander Ivchenko's message of "Sun, 28 Jul 2013 02:18:19 +0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (usg-unix-v) MIME-Version: 1.0 X-Virus-Found: No Alexander Ivchenko writes: > Hi Joseph, thanks for your comments. > > I updated the patch: > > 1) The function name as a second argument in libc_has_function target > hook was removed - was not usefull so far. > 2) By using contrib/config-list.mk (thanks for the hint - great tool!) > and analysing tm.h files and what is included in them I have checked > 197 targets. That analysis includes all issues that you raised in your > comments - everything is fixed now. I don't like that sometimes we > have to redefine the version of the hook back to the default one due > to a poisoning of including elfos.h, but I couldn't find a better > solution - I commented all those cases. > > Regtesting is in progress now. I have already tested the patch before, > so I don't expect to see any new problems. > > If all the tests pass, is the patch OK for trunk? Unfortunately, this patch broke Solaris 10+ bootstrap; it cannot have been tested properly there: In file included from ./tm.h:27:0, from /vol/gcc/src/hg/trunk/local/gcc/gencheck.c:23: /vol/gcc/src/hg/trunk/local/gcc/config/sol2-10.h:21:4: error: "/*" within comment [-Werror=comment] /* /* Solaris 10 has the float and long double forms of math functions. ^ cc1plus: all warnings being treated as errors make[3]: *** [build/gencheck.o] Error 1 Fixed as follows; bootstrapped without regressions on i386-pc-solaris2.10, installed on mainline. Rainer 2013-08-21 Rainer Orth * config/sol2-10.h (TARGET_LIBC_HAS_FUNCTION): Don't nest comment. diff --git a/gcc/config/sol2-10.h b/gcc/config/sol2-10.h --- a/gcc/config/sol2-10.h +++ b/gcc/config/sol2-10.h @@ -18,7 +18,7 @@ You should have received a copy of the G along with GCC; see the file COPYING3. If not see . */ -/* /* Solaris 10 has the float and long double forms of math functions. +/* Solaris 10 has the float and long double forms of math functions. We redefine this hook so the version from elfos.h header won't be used. */ #undef TARGET_LIBC_HAS_FUNCTION #define TARGET_LIBC_HAS_FUNCTION default_libc_has_function