diff mbox

q35: fix GPE method for cpu hotplug

Message ID d6a33f933ffb550152656e5c7f5b54d43d1c627c.1377075587.git.hutao@cn.fujitsu.com
State New
Headers show

Commit Message

Hu Tao Aug. 21, 2013, 9:04 a.m. UTC 
cpu hotplug uses bit 2 of GPE instead of bit 1.

Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
---
 src/q35-acpi-dsdt.dsl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Gerd Hoffmann Aug. 21, 2013, 11:05 a.m. UTC | #1 
Hi,

>          Method(_L01) {
> +        }
> +        Method(_E02) {
>              // CPU hotplug event
>              \_SB.PRSC()
>          }
> -        Method(_L02) {
> -        }

E02?  Typo?

cheers,
  Gerd
Igor Mammedov Sept. 10, 2013, 12:34 p.m. UTC | #2 
On Wed, 21 Aug 2013 13:05:27 +0200
Gerd Hoffmann <kraxel@redhat.com> wrote:

>   Hi,
> 
> >          Method(_L01) {
> > +        }
> > +        Method(_E02) {
> >              // CPU hotplug event
> >              \_SB.PRSC()
> >          }
> > -        Method(_L02) {
> > -        }
> 
> E02?  Typo?

_E02 is correct. see commit 9c6635bd4 for reasoning.
Perhaps commit message should be more verbose and contain
a reference to that commit.

> 
> cheers,
>   Gerd
> 
> 
>
diff mbox

Patch

diff --git a/src/q35-acpi-dsdt.dsl b/src/q35-acpi-dsdt.dsl
index c031d83..417ac48 100644
--- a/src/q35-acpi-dsdt.dsl
+++ b/src/q35-acpi-dsdt.dsl
@@ -415,11 +415,11 @@  DefinitionBlock (
         Method(_L00) {
         }
         Method(_L01) {
+        }
+        Method(_E02) {
             // CPU hotplug event
             \_SB.PRSC()
         }
-        Method(_L02) {
-        }
         Method(_L03) {
         }
         Method(_L04) {