| Message ID | 1377068556-51316-1-git-send-email-libo.chen@huawei.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On 08/21/2013 09:02 AM, Libo Chen wrote: > Unnecessary dev_set_drvdata() is removed, because the driver core > clears the driver data to NULL after device_release or on probe failure. > > Signed-off-by: Libo Chen <libo.chen@huawei.com> > --- > drivers/net/ethernet/xilinx/xilinx_emaclite.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c > index 7c1ccbc..4c619ea 100644 > --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c > +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c > @@ -1249,7 +1249,6 @@ static int xemaclite_of_remove(struct platform_device *of_dev) > lp->phy_node = NULL; > > xemaclite_remove_ndev(ndev, of_dev); > - dev_set_drvdata(dev, NULL); > > return 0; > } > Acked-by: Michal Simek <monstr@monstr.eu> Thanks, Michal
diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 7c1ccbc..4c619ea 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -1249,7 +1249,6 @@ static int xemaclite_of_remove(struct platform_device *of_dev) lp->phy_node = NULL; xemaclite_remove_ndev(ndev, of_dev); - dev_set_drvdata(dev, NULL); return 0; }
Unnecessary dev_set_drvdata() is removed, because the driver core clears the driver data to NULL after device_release or on probe failure. Signed-off-by: Libo Chen <libo.chen@huawei.com> --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)