Patchwork [v2,tegra-cbootimage] Add automake option subdir-objects to prevent warnings

login
register
mail settings
Submitter Stefan Agner
Date Aug. 19, 2013, 8:10 p.m.
Message ID <c0f44202ad8a959b1bd4c93f43c1dc42@agner.ch>
Download mbox | patch
Permalink /patch/268301/
State Accepted, archived
Headers show

Comments

Stefan Agner - Aug. 19, 2013, 8:10 p.m.
The SoC specific code is in subdirectories which leads to warnings in
newer
automake versions. The option subdir-objects prevents those warnings.

Signed-off-by: Stefan Agner <stefan@agner.ch>
---

Sorry, was in vacation. I could not reproduce the message Thierry sees
on
my automake 1.14 installation, however, the option make sense as far as
I 
understand its meaning.

 configure.ac    | 1 +
 src/Makefile.am | 2 ++
 2 files changed, 3 insertions(+)
Thierry Reding - Aug. 19, 2013, 8:33 p.m.
On Mon, Aug 19, 2013 at 10:10:20PM +0200, Stefan Agner wrote:
> The SoC specific code is in subdirectories which leads to warnings in
> newer
> automake versions. The option subdir-objects prevents those warnings.
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> 
> Sorry, was in vacation. I could not reproduce the message Thierry sees
> on
> my automake 1.14 installation, however, the option make sense as far as
> I 
> understand its meaning.

Yes, automake 1.14 doesn't warn about it, presumably because it makes
sure to select AM_PROG_CC_C_O if subdir-objects is enabled. I can
reproduce the warning by downgrading to 1.13.4, though.

>  configure.ac    | 1 +
>  src/Makefile.am | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index ccd0a55..9b83a21 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -10,6 +10,7 @@ AC_CONFIG_HEADERS([config.h])
>  # Checks for programs.
>  AC_PROG_CXX
>  AC_PROG_CC
> +AM_PROG_CC_C_O
>  PKG_PROG_PKG_CONFIG
>  
>  # Checks for libraries.
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 6fcc0d8..6fecfc7 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -1,3 +1,5 @@
> +AUTOMAKE_OPTIONS = subdir-objects
> +

I don't remember if I mentioned it before, but I've seen a lot of
projects that keep these options in the configure.ac file (in the
AM_INIT_AUTOMAKE command). The GNU documentation isn't specific
about which variant is preferred, so either way:

Reviewed-by: Thierry Reding <thierry.reding@gmail.com>
Stephen Warren - Aug. 19, 2013, 9:01 p.m.
On 08/19/2013 02:10 PM, Stefan Agner wrote:
> The SoC specific code is in subdirectories which leads to warnings in newer
> automake versions. The option subdir-objects prevents those warnings.

Everything still works fine in my evidently archaic automake-1.11.x, so,
Tested-by: Stephen Warren <swarren@nvidia.com>

Allen, do you intend to apply this? If not, I'm happy to.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Stephen Warren - Aug. 23, 2013, 4:50 p.m.
On 08/19/2013 02:10 PM, Stefan Agner wrote:
> The SoC specific code is in subdirectories which leads to warnings in
> newer
> automake versions. The option subdir-objects prevents those warnings.

I've applied this.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/configure.ac b/configure.ac
index ccd0a55..9b83a21 100644
--- a/configure.ac
+++ b/configure.ac
@@ -10,6 +10,7 @@  AC_CONFIG_HEADERS([config.h])
 # Checks for programs.
 AC_PROG_CXX
 AC_PROG_CC
+AM_PROG_CC_C_O
 PKG_PROG_PKG_CONFIG
 
 # Checks for libraries.
diff --git a/src/Makefile.am b/src/Makefile.am
index 6fcc0d8..6fecfc7 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1,3 +1,5 @@ 
+AUTOMAKE_OPTIONS = subdir-objects
+
 AM_CFLAGS = -Wall -std=c99
 
 bin_PROGRAMS = cbootimage bct_dump