From patchwork Mon Aug 19 17:21:24 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 268274 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 1F0572C0102 for ; Tue, 20 Aug 2013 03:21:36 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=AX2T8uQE/Nop2tNjV lOmE/+Ku2GWjxrEFyiRKTiR+qPT4Q7PfydqFdIaOdHigVa8991aYfFcG/g29ClRK 4qMysgHXyCfG7o31W/6i4Puegp0HTO2s7YD81+eZZjBVqyO1QWqYWFJ397essDBV pMp1vxax4w5Y9asoPrsW6GgJX4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=NKLfZOsmTDqJZRC2qp18ob4 HV6Q=; b=L6smxy1rMxVXsvoblC4vvC2nmLEJTEFEgei2MZl5xFSQib2MmITXOpD lUDhmTx3fqku4L3W51LtezjSqci0/mRHkbSGFnWX9z9baN7+qyj2O3LYCrI+UO2K SDnG06wBjQx6BLN5YIsf/UzzYrnbp/o3z3Y/6x58DlgypsCNR4LE= Received: (qmail 28280 invoked by alias); 19 Aug 2013 17:21:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 28206 invoked by uid 89); 19 Aug 2013 17:21:28 -0000 X-Spam-SWARE-Status: No, score=-8.4 required=5.0 tests=AWL, BAYES_00, KHOP_THREADED, RCVD_IN_HOSTKARMA_W, RCVD_IN_HOSTKARMA_WL, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 19 Aug 2013 17:21:27 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7JHLQLl016977 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 19 Aug 2013 13:21:26 -0400 Received: from reynosa.quesejoda.com (vpn-56-67.rdu2.redhat.com [10.10.56.67]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7JHLOTJ000429; Mon, 19 Aug 2013 13:21:25 -0400 Message-ID: <52125414.8070906@redhat.com> Date: Mon, 19 Aug 2013 12:21:24 -0500 From: Aldy Hernandez User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Gerald Pfeifer CC: gcc-patches , Nick Clifton Subject: Re: [patch] documentation: clarify that Cilk Plus implementation is incomplete References: <51CAEC8F.9010508@redhat.com> In-Reply-To: X-Virus-Found: No On 08/18/13 05:21, Gerald Pfeifer wrote: > On Wed, 26 Jun 2013, Aldy Hernandez wrote: >> This is a small cleanup to the Cilk Plus mention in our documentation, >> but more importantly, it clarifies that the Cilk Plus implementation >> in GCC is only partial. >> >> OK for trunk? > > * doc/invoke.texi (-fcilkplus): Clarify that implementation is > incomplete. > > diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi > index dd82880..3150c8d 100644 > --- a/gcc/doc/invoke.texi > +++ b/gcc/doc/invoke.texi > @@ -1804,13 +1804,17 @@ have support for @option{-pthread}. > @item -fcilkplus > @opindex fcilkplus > @cindex Enable Cilk Plus > -Enable the usage of Cilk Language extension features for C/C++. When > the flag > -@option{-fcilkplus} is specified, all the Cilk Plus components are > converted -to the appropriate C/C++ code. The present implementation > follows ABI version -0.9. There are four major parts to Cilk Plus > language -extension: Array Notations, Cilk Keywords, SIMD annotations > and elemental -functions. Detailed information about Cilk Plus can be > found at -@w{@uref{http://www.cilkplus.org}}. +When the option > @option{-fcilkplus} is specified, enable the usage of > +the Cilk Plus Language extension features for C/C++. The present > +implementation follows ABI version 0.9. This is an experimental > +feature that is only partially complete, and whose interface may > +change in future versions of GCC, as the official specification > +changes. Currently only the array notation feature of the language > +specification has been implemented. More features will be implemented > +in subsequent release cycles. > + > +Detailed information about Cilk Plus can be found at > +@w{@uref{http://www.cilkplus.org}}. > > I would keep the first sentence as is, which is more in line how > we generally describe options. Done (fixed capitalization problems in original sentence though). > > No comma before "as the official". Fixed. > > And personally I would omit the last sentence, but it's fine to > keep if you really want to leave it. Agreed. I have committed the attached patch. Thanks. commit d73291f1eb8feee7a2f6b91af11e1e00de401a42 Author: Aldy Hernandez Date: Mon Aug 19 12:18:31 2013 -0500 * doc/invoke.texi (-fcilkplus): Clarify that implementation is incomplete. diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 6645df9..dd6559d 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2013-08-19 Aldy Hernandez + + * doc/invoke.texi (-fcilkplus): Clarify that implementation is + incomplete. + 2013-08-19 Alexander Ivchenko * target.def (TARGET_LIBC_HAS_FUNCTION): New target hook. diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index f6a4ec4..dae7605 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -1811,13 +1811,15 @@ have support for @option{-pthread}. @item -fcilkplus @opindex fcilkplus @cindex Enable Cilk Plus -Enable the usage of Cilk Language extension features for C/C++. When the flag -@option{-fcilkplus} is specified, all the Cilk Plus components are converted -to the appropriate C/C++ code. The present implementation follows ABI version -0.9. There are four major parts to Cilk Plus language -extension: Array Notations, Cilk Keywords, SIMD annotations and elemental -functions. Detailed information about Cilk Plus can be found at -@w{@uref{http://www.cilkplus.org}}. +Enable the usage of Cilk Plus language extension features for C/C++. +When the option @option{-fcilkplus} is specified, enable the usage of +the Cilk Plus Language extension features for C/C++. The present +implementation follows ABI version 0.9. This is an experimental +feature that is only partially complete, and whose interface may +change in future versions of GCC as the official specification +changes. Currently only the array notation feature of the language +specification has been implemented. More features will be implemented +in subsequent release cycles. @item -fgnu-tm @opindex fgnu-tm