Patchwork [RESEND] mtd: MTD_NAND_DENALI should depend on HAS_DMA

login
register
mail settings
Submitter Geert Uytterhoeven
Date Aug. 18, 2013, 11:03 a.m.
Message ID <1376823839-5853-1-git-send-email-geert@linux-m68k.org>
Download mbox | patch
Permalink /patch/268029/
State New
Headers show

Comments

Geert Uytterhoeven - Aug. 18, 2013, 11:03 a.m.
If NO_DMA=y:

drivers/built-in.o: In function `denali_remove':
drivers/mtd/nand/denali.c:1605: undefined reference to `dma_unmap_single'
drivers/built-in.o: In function `denali_read_page_raw':
drivers/mtd/nand/denali.c:1190: undefined reference to `dma_sync_single_for_cpu'
drivers/built-in.o: In function `denali_read_page':
drivers/mtd/nand/denali.c:1140: undefined reference to `dma_sync_single_for_cpu'
drivers/built-in.o: In function `write_page':
drivers/mtd/nand/denali.c:1051: undefined reference to `dma_sync_single_for_cpu'
drivers/built-in.o: In function `denali_init':
drivers/mtd/nand/denali.c:1433: undefined reference to `dma_set_mask'
drivers/mtd/nand/denali.c:1438: undefined reference to `dma_map_single'
drivers/mtd/nand/denali.c:1442: undefined reference to `dma_mapping_error'

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/mtd/nand/Kconfig |    1 +
 1 file changed, 1 insertion(+)
Artem Bityutskiy - Aug. 19, 2013, 3:17 p.m.
On Sun, 2013-08-18 at 13:03 +0200, Geert Uytterhoeven wrote:
> If NO_DMA=y:
> 
> drivers/built-in.o: In function `denali_remove':
> drivers/mtd/nand/denali.c:1605: undefined reference to `dma_unmap_single'
> drivers/built-in.o: In function `denali_read_page_raw':
> drivers/mtd/nand/denali.c:1190: undefined reference to `dma_sync_single_for_cpu'
> drivers/built-in.o: In function `denali_read_page':
> drivers/mtd/nand/denali.c:1140: undefined reference to `dma_sync_single_for_cpu'
> drivers/built-in.o: In function `write_page':
> drivers/mtd/nand/denali.c:1051: undefined reference to `dma_sync_single_for_cpu'
> drivers/built-in.o: In function `denali_init':
> drivers/mtd/nand/denali.c:1433: undefined reference to `dma_set_mask'
> drivers/mtd/nand/denali.c:1438: undefined reference to `dma_map_single'
> drivers/mtd/nand/denali.c:1442: undefined reference to `dma_mapping_error'
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Pushed to l2-mtd.git, thanks!

Patch

diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index 50543f1..25b8a91 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -43,6 +43,7 @@  config MTD_SM_COMMON
 
 config MTD_NAND_DENALI
         tristate "Support Denali NAND controller"
+	depends on HAS_DMA
         help
 	  Enable support for the Denali NAND controller.  This should be
 	  combined with either the PCI or platform drivers to provide device