| Message ID | 1376786376.21329.20.camel@edumazet-glaptop |
|---|---|
| State | RFC, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Sat, 17 Aug 2013 17:39:36 -0700 > Because of gmail.com problems, I missed lot of netdev traffic > > Related to : > > http://patchwork.ozlabs.org/patch/267678/ > > > diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c > index 5423223..b2f6c74 100644 > --- a/net/ipv4/tcp.c > +++ b/net/ipv4/tcp.c > @@ -1121,6 +1121,13 @@ new_segment: > goto wait_for_memory; > > /* > + * All packets are restored as if they have > + * already been sent. > + */ > + if (tp->repair) > + TCP_SKB_CB(skb)->when = tcp_time_stamp; > + > > The test could be removed. > > Setting @when for regular sends seems harmless I applied this before reading this, sorry. It can be cleaned up in net-next eventually. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2013-08-20 at 13:08 -0700, David Miller wrote: > > I applied this before reading this, sorry. > > It can be cleaned up in net-next eventually. No worries, this was a minor comment, thanks ;) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 5423223..b2f6c74 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -1121,6 +1121,13 @@ new_segment: goto wait_for_memory; /* + * All packets are restored as if they have + * already been sent. + */ + if (tp->repair) + TCP_SKB_CB(skb)->when = tcp_time_stamp; + The test could be removed. Setting @when for regular sends seems harmless