diff mbox

[U-Boot] ARM: mxs: Add mx28evk_auart_console target

Message ID 1376670277-5724-1-git-send-email-andreas.wass@dalelven.com
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Commit Message

Andreas Wass Aug. 16, 2013, 4:24 p.m. UTC
The target uses AUART 3 instead of the DUART for console output.

Signed-off-by: Andreas Wass <andreas.wass@dalelven.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Marek Vasut <marex@denx.de>
---
 boards.cfg            | 1 +
 include/configs/mxs.h | 7 ++++++-
 2 files changed, 7 insertions(+), 1 deletion(-)

Comments

Otavio Salvador Aug. 16, 2013, 5 p.m. UTC | #1
On Fri, Aug 16, 2013 at 1:24 PM, Andreas Wass <andreas.wass@dalelven.com> wrote:
> The target uses AUART 3 instead of the DUART for console output.
>
> Signed-off-by: Andreas Wass <andreas.wass@dalelven.com>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Marek Vasut <marex@denx.de>

Why to use AUART for console? can you elaborate it a little more?
Andreas Wass Aug. 16, 2013, 5:06 p.m. UTC | #2
Dear Otavio,

Some boards don't have the DUART easily available (see STKa28 by TQ-group for instance) while a regular rs232 port is easily accessed. 

The purpose of this patch is more of a demonstration how to use the AUART driver and was requested by Fabio during the submission of the AUART driver. 

Best regards
Andreas Wass

16 aug 2013 kl. 19:00 skrev "Otavio Salvador" <otavio@ossystems.com.br>:

> On Fri, Aug 16, 2013 at 1:24 PM, Andreas Wass <andreas.wass@dalelven.com> wrote:
>> The target uses AUART 3 instead of the DUART for console output.
>> 
>> Signed-off-by: Andreas Wass <andreas.wass@dalelven.com>
>> Cc: Fabio Estevam <fabio.estevam@freescale.com>
>> Cc: Marek Vasut <marex@denx.de>
> 
> Why to use AUART for console? can you elaborate it a little more?
> 
> -- 
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://projetos.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Fabio Estevam Aug. 16, 2013, 5:10 p.m. UTC | #3
On Fri, Aug 16, 2013 at 2:06 PM, Andreas Wass <Andreas.Wass@dalelven.com> wrote:
> Dear Otavio,
>
> Some boards don't have the DUART easily available (see STKa28 by TQ-group for instance) while a regular rs232 port is easily accessed.
>
> The purpose of this patch is more of a demonstration how to use the AUART driver and was requested by Fabio during the submission of the AUART driver.

Yes, correct.

With this target in place, we can have a user of the mxs auart driver
that Andreas submitted recently.

Regards,

Fabio Estevam
Otavio Salvador Aug. 16, 2013, 5:13 p.m. UTC | #4
On Fri, Aug 16, 2013 at 2:10 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Fri, Aug 16, 2013 at 2:06 PM, Andreas Wass <Andreas.Wass@dalelven.com> wrote:
>> Dear Otavio,
>>
>> Some boards don't have the DUART easily available (see STKa28 by TQ-group for instance) while a regular rs232 port is easily accessed.
>>
>> The purpose of this patch is more of a demonstration how to use the AUART driver and was requested by Fabio during the submission of the AUART driver.
>
> Yes, correct.
>
> With this target in place, we can have a user of the mxs auart driver
> that Andreas submitted recently.

I see.

Good :-)
Marek Vasut Aug. 16, 2013, 11:28 p.m. UTC | #5
Dear Andreas Wass,

> The target uses AUART 3 instead of the DUART for console output.
> 
> Signed-off-by: Andreas Wass <andreas.wass@dalelven.com>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Marek Vasut <marex@denx.de>
> ---

I wonder, why dont you add support for the TQ SoM in the first place?

Best regards,
Marek Vasut
Andreas Wass Aug. 17, 2013, 8:07 a.m. UTC | #6
Dear Marek

> I wonder, why dont you add support for the TQ SoM in the first place?

I have plans to do it but I only have access to the board at work and
I currently am very busy so have limited time testing the board setup, so I don't
know when in time I will be able to submit such a patch.

Regards
Andreas
Marek Vasut Aug. 18, 2013, 8:20 p.m. UTC | #7
Hi Andreas,

> Dear Marek
> 
> > I wonder, why dont you add support for the TQ SoM in the first place?
> 
> I have plans to do it but I only have access to the board at work and
> I currently am very busy so have limited time testing the board setup, so I
> don't know when in time I will be able to submit such a patch.

Sucks, but ok.

Best regards,
Marek Vasut
diff mbox

Patch

diff --git a/boards.cfg b/boards.cfg
index 454da7f..79d6cd8 100644
--- a/boards.cfg
+++ b/boards.cfg
@@ -203,6 +203,7 @@  mx23evk                      arm         arm926ejs   mx23evk             freesca
 m28evk                       arm         arm926ejs   m28evk              denx           mxs		m28evk
 mx28evk                      arm         arm926ejs   mx28evk             freescale      mxs		mx28evk:ENV_IS_IN_MMC
 mx28evk_nand                 arm         arm926ejs   mx28evk             freescale      mxs		mx28evk:ENV_IS_IN_NAND
+mx28evk_auart_console        arm         arm926ejs   mx28evk             freescale      mxs		mx28evk:MXS_AUART,MXS_AUART_BASE=MXS_UARTAPP3_BASE,ENV_IS_IN_MMC
 sc_sps_1                     arm         arm926ejs   sc_sps_1            schulercontrol mxs
 nhk8815                      arm         arm926ejs   nhk8815             st             nomadik
 nhk8815_onenand              arm         arm926ejs   nhk8815             st             nomadik       nhk8815:BOOT_ONENAND
diff --git a/include/configs/mxs.h b/include/configs/mxs.h
index a684166..124dc1e 100644
--- a/include/configs/mxs.h
+++ b/include/configs/mxs.h
@@ -119,11 +119,16 @@ 
 /* GPIO */
 #define CONFIG_MXS_GPIO
 
-/* DUART Serial Driver */
+/*
+ * DUART Serial Driver.
+ * Conflicts with AUART driver which can be set by board.
+ */
+#ifndef CONFIG_MXS_AUART
 #define CONFIG_PL011_SERIAL
 #define CONFIG_PL011_CLOCK		24000000
 #define CONFIG_PL01x_PORTS		{ (void *)MXS_UARTDBG_BASE }
 #define CONFIG_CONS_INDEX		0
+#endif
 /* Default baudrate can be overriden by board! */
 #ifndef CONFIG_BAUDRATE
 #define CONFIG_BAUDRATE			115200