From patchwork Fri Aug 16 14:46:49 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony PERARD X-Patchwork-Id: 267671 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id D89352C027E for ; Sat, 17 Aug 2013 00:48:13 +1000 (EST) Received: from localhost ([::1]:59458 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VALJz-0004sC-LY for incoming@patchwork.ozlabs.org; Fri, 16 Aug 2013 10:48:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VALJg-0004mH-0V for qemu-devel@nongnu.org; Fri, 16 Aug 2013 10:47:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VALJb-0001O6-Bu for qemu-devel@nongnu.org; Fri, 16 Aug 2013 10:47:51 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:19495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VALJR-0001Lm-QE; Fri, 16 Aug 2013 10:47:37 -0400 X-IronPort-AV: E=Sophos;i="4.89,895,1367971200"; d="scan'208";a="42791516" Received: from accessns.citrite.net (HELO FTLPEX01CL02.citrite.net) ([10.9.154.239]) by FTLPIPO02.CITRIX.COM with ESMTP/TLS/AES128-SHA; 16 Aug 2013 14:47:36 +0000 Received: from ukmail1.uk.xensource.com (10.80.16.128) by smtprelay.citrix.com (10.13.107.79) with Microsoft SMTP Server id 14.2.342.4; Fri, 16 Aug 2013 10:47:35 -0400 Received: from perard.uk.xensource.com ([10.80.2.84]) by ukmail1.uk.xensource.com with esmtp (Exim 4.69) (envelope-from ) id 1VALJP-0005k6-IM; Fri, 16 Aug 2013 15:47:35 +0100 From: Anthony PERARD To: QEMU-devel Date: Fri, 16 Aug 2013 15:46:49 +0100 Message-ID: <1376664409-2695-1-git-send-email-anthony.perard@citrix.com> X-Mailer: git-send-email 1.8.3.4 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 66.165.176.63 Cc: qemu-trivial@nongnu.org, Anthony PERARD , Stefano Stabellini , Xen Devel Subject: [Qemu-devel] [PATCH for v1.6] pc: Fix initialization of the ram_memory variable. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org In some cases (Xen), it will not be initialized before to be used. This leads to segv. Signed-off-by: Anthony PERARD Tested-by: Fabio Fantoni --- It works with this simple initialization to NULL, but would it be necessary (or better) to assign a proper value to this variables ? --- hw/i386/pc_piix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 6e1e654..596d433 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -86,7 +86,7 @@ static void pc_init1(MemoryRegion *system_memory, BusState *idebus[MAX_IDE_BUS]; ISADevice *rtc_state; ISADevice *floppy; - MemoryRegion *ram_memory; + MemoryRegion *ram_memory = NULL; MemoryRegion *pci_memory; MemoryRegion *rom_memory; DeviceState *icc_bridge;