Patchwork ACPICA:enable 64bit build for aarch64 architecture

login
register
mail settings
Submitter Naresh Bhat
Date Aug. 14, 2013, 4:46 p.m.
Message ID <1376498808-23664-1-git-send-email-naresh.bhat@linaro.org>
Download mbox | patch
Permalink /patch/267151/
State Accepted
Headers show

Comments

Naresh Bhat - Aug. 14, 2013, 4:46 p.m.
From: Naresh Bhat <naresh.bhat@linaro.org>

Signed-off-by: Naresh Bhat <naresh.bhat@linaro.org>

Enable 64 bit build for aarch64 architecture in ACPICA Linux
platform specific defines.
---
 src/acpica/source/include/platform/aclinux.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Ivan Hu - Aug. 18, 2013, 11:09 p.m.
On 08/15/2013 12:46 AM, naresh.bhat@linaro.org wrote:
> From: Naresh Bhat <naresh.bhat@linaro.org>
>
> Signed-off-by: Naresh Bhat <naresh.bhat@linaro.org>
>
> Enable 64 bit build for aarch64 architecture in ACPICA Linux
> platform specific defines.
> ---
>   src/acpica/source/include/platform/aclinux.h |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acpica/source/include/platform/aclinux.h b/src/acpica/source/include/platform/aclinux.h
> index e561292..6b8b1ab 100644
> --- a/src/acpica/source/include/platform/aclinux.h
> +++ b/src/acpica/source/include/platform/aclinux.h
> @@ -159,7 +159,7 @@
>   #define ACPI_FLUSH_CPU_CACHE()
>   #define ACPI_CAST_PTHREAD_T(pthread) ((ACPI_THREAD_ID) (pthread))
>
> -#if defined(__ia64__) || defined(__x86_64__)
> +#if defined(__ia64__) || defined(__x86_64__) || defined(__aarch64__)
>   #define ACPI_MACHINE_WIDTH          64
>   #define COMPILER_DEPENDENT_INT64    long
>   #define COMPILER_DEPENDENT_UINT64   unsigned long
>

Hi Naresh,

Thanks for working on this.
I don't have the arm 64-bits platform could test.:)
But checking with x86 64 and 32 bits, arm 32 bit, the patch doesn't 
break these builds.

Acked-by: Ivan Hu <ivan.hu@canonical.com>
Colin King - Aug. 23, 2013, 8:25 p.m.
On 14/08/13 17:46, naresh.bhat@linaro.org wrote:
> From: Naresh Bhat <naresh.bhat@linaro.org>
> 
> Signed-off-by: Naresh Bhat <naresh.bhat@linaro.org>
> 
> Enable 64 bit build for aarch64 architecture in ACPICA Linux
> platform specific defines.
> ---
>  src/acpica/source/include/platform/aclinux.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/acpica/source/include/platform/aclinux.h b/src/acpica/source/include/platform/aclinux.h
> index e561292..6b8b1ab 100644
> --- a/src/acpica/source/include/platform/aclinux.h
> +++ b/src/acpica/source/include/platform/aclinux.h
> @@ -159,7 +159,7 @@
>  #define ACPI_FLUSH_CPU_CACHE()
>  #define ACPI_CAST_PTHREAD_T(pthread) ((ACPI_THREAD_ID) (pthread))
>  
> -#if defined(__ia64__) || defined(__x86_64__)
> +#if defined(__ia64__) || defined(__x86_64__) || defined(__aarch64__)
>  #define ACPI_MACHINE_WIDTH          64
>  #define COMPILER_DEPENDENT_INT64    long
>  #define COMPILER_DEPENDENT_UINT64   unsigned long
> 
Acked-by: Colin Ian King <colin.king@canonical.com>

Patch

diff --git a/src/acpica/source/include/platform/aclinux.h b/src/acpica/source/include/platform/aclinux.h
index e561292..6b8b1ab 100644
--- a/src/acpica/source/include/platform/aclinux.h
+++ b/src/acpica/source/include/platform/aclinux.h
@@ -159,7 +159,7 @@ 
 #define ACPI_FLUSH_CPU_CACHE()
 #define ACPI_CAST_PTHREAD_T(pthread) ((ACPI_THREAD_ID) (pthread))
 
-#if defined(__ia64__) || defined(__x86_64__)
+#if defined(__ia64__) || defined(__x86_64__) || defined(__aarch64__)
 #define ACPI_MACHINE_WIDTH          64
 #define COMPILER_DEPENDENT_INT64    long
 #define COMPILER_DEPENDENT_UINT64   unsigned long