From patchwork Thu Apr 30 06:06:16 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sergey Senozhatsky X-Patchwork-Id: 26701 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 2D024B7063 for ; Fri, 1 May 2009 05:29:30 +1000 (EST) Received: by ozlabs.org (Postfix) id 1C362DDFC2; Fri, 1 May 2009 05:29:30 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id B725ADDFC1 for ; Fri, 1 May 2009 05:29:29 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751139AbZD3T3X (ORCPT ); Thu, 30 Apr 2009 15:29:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750909AbZD3T3X (ORCPT ); Thu, 30 Apr 2009 15:29:23 -0400 Received: from [212.98.175.89] ([212.98.175.89]:50298 "EHLO localhost.localdomain" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750736AbZD3T3W (ORCPT ); Thu, 30 Apr 2009 15:29:22 -0400 X-Greylist: delayed 48117 seconds by postgrey-1.27 at vger.kernel.org; Thu, 30 Apr 2009 15:29:22 EDT Received: from localhost.localdomain (localhost [127.0.0.1]) by localhost.localdomain (8.14.3/8.14.3/Debian-5) with ESMTP id n3U66G1A006090; Thu, 30 Apr 2009 09:06:16 +0300 Received: (from bender@localhost) by localhost.localdomain (8.14.3/8.14.3/Submit) id n3U66GAY006089; Thu, 30 Apr 2009 09:06:16 +0300 X-Authentication-Warning: localhost.localdomain: bender set sender to sergey.senozhatsky@mail.by using -f Date: Thu, 30 Apr 2009 09:06:16 +0300 From: Sergey Senozhatsky To: Andrew Morton Cc: netdev@vger.kernel.org Subject: [PATCH]: fixing gcc 4.4 =?utf-8?Q?compiler?= =?utf-8?Q?_warning=3A_suggest_parentheses_around_operand_of_=E2=80=98!?= =?utf-8?B?4oCZ?= Message-ID: <20090430060616.GB6040@localhost> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Trivial: fixing gcc 4.4 compiler warning: drivers/net/cxgb3/t3_hw.c: In function ‘t3_prep_adapter’: drivers/net/cxgb3/t3_hw.c:3782: warning: suggest parentheses around operand of ‘!’ or change ‘|’ to ‘||’ or ‘!’ to ‘~’ Signed-off-by: Sergey Senozhatsky --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/cxgb3/t3_hw.c b/drivers/net/cxgb3/t3_hw.c index e1bd690..4f68aeb 100644 --- a/drivers/net/cxgb3/t3_hw.c +++ b/drivers/net/cxgb3/t3_hw.c @@ -3779,7 +3779,7 @@ int t3_prep_adapter(struct adapter *adapter, const struct adapter_info *ai, adapter->params.info = ai; adapter->params.nports = ai->nports0 + ai->nports1; - adapter->params.chan_map = !!ai->nports0 | (!!ai->nports1 << 1); + adapter->params.chan_map = (!!ai->nports0) | (!!ai->nports1 << 1); adapter->params.rev = t3_read_reg(adapter, A_PL_REV); /* * We used to only run the "adapter check task" once a second if