diff mbox

[U-Boot,v3] SPL: Makefile: Build a separate autoconf.mk for SPL

Message ID 1376460089-19562-1-git-send-email-ying.zhang@freescale.com
State Superseded
Delegated to: Tom Rini
Headers show

Commit Message

ying.zhang@freescale.com Aug. 14, 2013, 6:01 a.m. UTC 
From: Zhang Ying <rock.ap.freescale.net>

SPL defines CONFIG_SPL_BUILD but this does not percolate to the autoconf.mk Makefile.
As a result the build breaks when CONFIG_SPL_BUILD is used in the board-specific include
header file. With this, there is a possibility of having a CONFIG option defined in the
header file but not defined in the Makefile causing all kinds of build failure and problems.

It also messes things for up, for example, when one might want to undefine options to
keep the SPL small and doesn't want to be stuck with the CONFIG options used for U-boot.
Lastly, this also avoids defining special CONFIG_SPL_ variables for cases where some
options are required in U-boot but not in SPL.

We add a spl-autoconf.mk rule that is generated for SPL with the CONFIG_SPL_BUILD flag
and conditionally include it for SPL builds.

Signed-off-by: Zhang Ying <rock.ap.freescale.net>
---
Change from v2:
- Fixed the reported build breakage of am335x_evm_usbspl.
Change from v1:
- Fixed issue where builds in a different directory were failing.

 Makefile     | 19 +++++++++++++++++--
 config.mk    |  6 ++++++
 spl/Makefile |  1 +
 3 files changed, 24 insertions(+), 2 deletions(-)

Comments

York Sun Aug. 15, 2013, 5:27 p.m. UTC | #1 
On 08/13/2013 11:01 PM, ying.zhang@freescale.com wrote:
> From: Zhang Ying <rock.ap.freescale.net>
> 
> SPL defines CONFIG_SPL_BUILD but this does not percolate to the autoconf.mk Makefile.
> As a result the build breaks when CONFIG_SPL_BUILD is used in the board-specific include
> header file. With this, there is a possibility of having a CONFIG option defined in the
> header file but not defined in the Makefile causing all kinds of build failure and problems.
> 
> It also messes things for up, for example, when one might want to undefine options to
> keep the SPL small and doesn't want to be stuck with the CONFIG options used for U-boot.
> Lastly, this also avoids defining special CONFIG_SPL_ variables for cases where some
> options are required in U-boot but not in SPL.
> 
> We add a spl-autoconf.mk rule that is generated for SPL with the CONFIG_SPL_BUILD flag
> and conditionally include it for SPL builds.
> 
> Signed-off-by: Zhang Ying <rock.ap.freescale.net>
>

Please use a valid email address to sign off.

York
Zhang Ying-B40530 Aug. 16, 2013, 3:13 a.m. UTC | #2 
Need I resend a patch?

-----Original Message-----
From: sun york-R58495 
Sent: Friday, August 16, 2013 1:27 AM
To: Zhang Ying-B40530
Cc: u-boot@lists.denx.de; Wood Scott-B07421; Xie Xiaobo-R63061
Subject: Re: [PATCH v3] SPL: Makefile: Build a separate autoconf.mk for SPL

On 08/13/2013 11:01 PM, ying.zhang@freescale.com wrote:
> From: Zhang Ying <rock.ap.freescale.net>
> 
> SPL defines CONFIG_SPL_BUILD but this does not percolate to the autoconf.mk Makefile.
> As a result the build breaks when CONFIG_SPL_BUILD is used in the 
> board-specific include header file. With this, there is a possibility 
> of having a CONFIG option defined in the header file but not defined in the Makefile causing all kinds of build failure and problems.
> 
> It also messes things for up, for example, when one might want to 
> undefine options to keep the SPL small and doesn't want to be stuck with the CONFIG options used for U-boot.
> Lastly, this also avoids defining special CONFIG_SPL_ variables for 
> cases where some options are required in U-boot but not in SPL.
> 
> We add a spl-autoconf.mk rule that is generated for SPL with the 
> CONFIG_SPL_BUILD flag and conditionally include it for SPL builds.
> 
> Signed-off-by: Zhang Ying <rock.ap.freescale.net>
>

Please use a valid email address to sign off.

York
diff mbox

Patch

diff --git a/Makefile b/Makefile
index d545d30..75df06a 100644
--- a/Makefile
+++ b/Makefile
@@ -613,6 +613,7 @@  updater:
 # Explicitly make _depend in subdirs containing multiple targets to prevent
 # parallel sub-makes creating .depend files simultaneously.
 depend dep:	$(TIMESTAMP_FILE) $(VERSION_FILE) \
+		$(obj)include/spl-autoconf.mk \
 		$(obj)include/autoconf.mk \
 		$(obj)include/generated/generic-asm-offsets.h \
 		$(obj)include/generated/asm-offsets.h
@@ -694,12 +695,23 @@  $(obj)include/autoconf.mk: $(obj)include/config.h
 		sed -n -f tools/scripts/define2mk.sed > $@.tmp && \
 	mv $@.tmp $@
 
+# Auto-generate the spl-autoconf.mk file (which is included by all makefiles for SPL)
+$(obj)include/spl-autoconf.mk: $(obj)include/config.h
+	@$(XECHO) Generating $@ ; \
+	set -e ; \
+	: Extract the config macros ; \
+	$(CPP) $(CFLAGS) -DCONFIG_SPL_BUILD -DDO_DEPS_ONLY -dM include/common.h | \
+	sed -n -f tools/scripts/define2mk.sed > $@.tmp && \
+	mv $@.tmp $@
+
 $(obj)include/generated/generic-asm-offsets.h:	$(obj)include/autoconf.mk.dep \
+	$(obj)include/spl-autoconf.mk \
 	$(obj)lib/asm-offsets.s
 	@$(XECHO) Generating $@
 	tools/scripts/make-asm-offsets $(obj)lib/asm-offsets.s $@
 
 $(obj)lib/asm-offsets.s:	$(obj)include/autoconf.mk.dep \
+	$(obj)include/spl-autoconf.mk \
 	$(src)lib/asm-offsets.c
 	@mkdir -p $(obj)lib
 	$(CC) -DDO_DEPS_ONLY \
@@ -707,11 +719,13 @@  $(obj)lib/asm-offsets.s:	$(obj)include/autoconf.mk.dep \
 		-o $@ $(src)lib/asm-offsets.c -c -S
 
 $(obj)include/generated/asm-offsets.h:	$(obj)include/autoconf.mk.dep \
+	$(obj)include/spl-autoconf.mk \
 	$(obj)$(CPUDIR)/$(SOC)/asm-offsets.s
 	@$(XECHO) Generating $@
 	tools/scripts/make-asm-offsets $(obj)$(CPUDIR)/$(SOC)/asm-offsets.s $@
 
-$(obj)$(CPUDIR)/$(SOC)/asm-offsets.s:	$(obj)include/autoconf.mk.dep
+$(obj)$(CPUDIR)/$(SOC)/asm-offsets.s:	$(obj)include/autoconf.mk.dep \
+	$(obj)include/spl-autoconf.mk
 	@mkdir -p $(obj)$(CPUDIR)/$(SOC)
 	if [ -f $(src)$(CPUDIR)/$(SOC)/asm-offsets.c ];then \
 		$(CC) -DDO_DEPS_ONLY \
@@ -783,7 +797,8 @@  include/license.h: tools/bin2header COPYING
 unconfig:
 	@rm -f $(obj)include/config.h $(obj)include/config.mk \
 		$(obj)board/*/config.tmp $(obj)board/*/*/config.tmp \
-		$(obj)include/autoconf.mk $(obj)include/autoconf.mk.dep
+		$(obj)include/autoconf.mk $(obj)include/autoconf.mk.dep \
+		$(obj)include/spl-autoconf.mk
 
 %_config::	unconfig
 	@$(MKCONFIG) -A $(@:_config=)
diff --git a/config.mk b/config.mk
index 3e84f36..54e99f4 100644
--- a/config.mk
+++ b/config.mk
@@ -145,7 +145,13 @@  CHECK	= sparse
 #########################################################################
 
 # Load generated board configuration
+ifeq ($(CONFIG_SPL_BUILD),y)
+# Include SPL autoconf
+sinclude $(OBJTREE)/include/spl-autoconf.mk
+else
+# Include normal autoconf
 sinclude $(OBJTREE)/include/autoconf.mk
+endif
 sinclude $(OBJTREE)/include/config.mk
 
 # Some architecture config.mk files need to know what CPUDIR is set to,
diff --git a/spl/Makefile b/spl/Makefile
index 6e5299b..43db01f 100644
--- a/spl/Makefile
+++ b/spl/Makefile
@@ -80,6 +80,7 @@  LIBS-$(CONFIG_SPL_POST_MEM_SUPPORT) += post/drivers/memory.o
 LIBS-$(CONFIG_SPL_NET_SUPPORT) += net/libnet.o
 LIBS-$(CONFIG_SPL_ETH_SUPPORT) += drivers/net/libnet.o
 LIBS-$(CONFIG_SPL_ETH_SUPPORT) += drivers/net/phy/libphy.o
+LIBS-$(CONFIG_SPL_USBETH_SUPPORT) += drivers/net/phy/libphy.o
 LIBS-$(CONFIG_SPL_MUSB_NEW_SUPPORT) += drivers/usb/musb-new/libusb_musb-new.o
 LIBS-$(CONFIG_SPL_USBETH_SUPPORT) += drivers/usb/gadget/libusb_gadget.o