| Message ID | 520AFBEE.7030903@huawei.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 08/14/2013 07:39 AM, Libo Chen wrote: > We can use the wrapper functions platform_{get,set}_drvdata() instead of > dev_{get,set}_drvdata() with &pdev->dev, it is convenient for user. > Also, unnecessary dev_set_drvdata() is removed, because the driver core > clears the driver data to NULL after device_release or on probe failure. You misunderstood. That's a material for 2 separate patch sets (or maybe single patches, since multiple files can be collapsed in a single patch). > Signed-off-by: Libo Chen <libo.chen@huawei.com> WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2013/8/15 2:54, Sergei Shtylyov wrote: > Hello. > > On 08/14/2013 07:39 AM, Libo Chen wrote: > >> We can use the wrapper functions platform_{get,set}_drvdata() instead of >> dev_{get,set}_drvdata() with &pdev->dev, it is convenient for user. > >> Also, unnecessary dev_set_drvdata() is removed, because the driver core >> clears the driver data to NULL after device_release or on probe failure. > > You misunderstood. That's a material for 2 separate patch sets (or maybe single patches, since multiple files can be collapsed in a single patch). > okay, thanks. Libo >> Signed-off-by: Libo Chen <libo.chen@huawei.com> > > WBR, Sergei > > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c index c93a056..995a3ab 100644 --- a/drivers/net/ethernet/freescale/fsl_pq_mdio.c +++ b/drivers/net/ethernet/freescale/fsl_pq_mdio.c @@ -409,7 +409,7 @@ static int fsl_pq_mdio_probe(struct platform_device *pdev) priv->regs = priv->map + data->mii_offset; new_bus->parent = &pdev->dev; - dev_set_drvdata(&pdev->dev, new_bus); + platform_set_drvdata(pdev, new_bus); if (data->get_tbipa) { for_each_child_of_node(np, tbi) { @@ -468,7 +468,6 @@ static int fsl_pq_mdio_remove(struct platform_device *pdev) mdiobus_unregister(bus); - dev_set_drvdata(device, NULL); iounmap(priv->map); mdiobus_free(bus);
We can use the wrapper functions platform_{get,set}_drvdata() instead of dev_{get,set}_drvdata() with &pdev->dev, it is convenient for user. Also, unnecessary dev_set_drvdata() is removed, because the driver core clears the driver data to NULL after device_release or on probe failure. Signed-off-by: Libo Chen <libo.chen@huawei.com> --- drivers/net/ethernet/freescale/fsl_pq_mdio.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)