From patchwork Thu Apr 30 14:50:50 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Henriksson X-Patchwork-Id: 26696 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4AA6FB7079 for ; Fri, 1 May 2009 01:24:29 +1000 (EST) Received: by ozlabs.org (Postfix) id 3D442DDFD5; Fri, 1 May 2009 01:24:29 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id CA474DDFCD for ; Fri, 1 May 2009 01:24:28 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753837AbZD3PYW (ORCPT ); Thu, 30 Apr 2009 11:24:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752901AbZD3PYV (ORCPT ); Thu, 30 Apr 2009 11:24:21 -0400 Received: from 1-1-1-9a.ghn.gbg.bostream.se ([82.182.69.4]:42004 "EHLO amd64.fatal.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751868AbZD3PYV (ORCPT ); Thu, 30 Apr 2009 11:24:21 -0400 X-Greylist: delayed 2240 seconds by postgrey-1.27 at vger.kernel.org; Thu, 30 Apr 2009 11:24:20 EDT Received: from gem by amd64.fatal.se with local (Exim 4.69) (envelope-from ) id 1LzXb8-0001JV-Ve; Thu, 30 Apr 2009 16:50:51 +0200 Subject: [PATCH] Bug#526329: iproute: Segfault on garbage lladdr From: Andreas Henriksson To: Timothy Baldwin , 526329@bugs.debian.org, Stephen Hemminger Cc: netdev In-Reply-To: <20090430133251.7015.21654.reportbug@bfg.majoroak.f2s.com> References: <20090430133251.7015.21654.reportbug@bfg.majoroak.f2s.com> Date: Thu, 30 Apr 2009 16:50:50 +0200 Message-Id: <1241103050.19807.34.camel@amd64.fatal.se> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On tor, 2009-04-30 at 14:32 +0100, Timothy Baldwin wrote: > Package: iproute > Version: 20090324-1 > Severity: minor > > > $ ip link set eth0 address help > "help" is invalid lladdr. > Segmentation fault > > Desipte the invalid command line arguments it shouldn't crash. > Callers need to check return value from ll_addr_a2n(). Patch below. Signed-off-by: Andreas Henriksson --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/ip/iplink.c b/ip/iplink.c index 237ea82..55558e3 100644 --- a/ip/iplink.c +++ b/ip/iplink.c @@ -200,11 +200,15 @@ int iplink_parse(int argc, char **argv, struct iplink_req *req, } else if (matches(*argv, "address") == 0) { NEXT_ARG(); len = ll_addr_a2n(abuf, sizeof(abuf), *argv); + if (len < 0) + return -1; addattr_l(&req->n, sizeof(*req), IFLA_ADDRESS, abuf, len); } else if (matches(*argv, "broadcast") == 0 || strcmp(*argv, "brd") == 0) { NEXT_ARG(); len = ll_addr_a2n(abuf, sizeof(abuf), *argv); + if (len < 0) + return -1; addattr_l(&req->n, sizeof(*req), IFLA_BROADCAST, abuf, len); } else if (matches(*argv, "txqueuelen") == 0 || strcmp(*argv, "qlen") == 0 ||