Patchwork [GIT,PULL] ARM: TC2: CPU idle big.LITTLE driver

login
register
mail settings
Submitter Lorenzo Pieralisi
Date Aug. 12, 2013, 3:34 p.m.
Message ID <20130812153422.GA6426@e102568-lin.cambridge.arm.com>
Download mbox
Permalink /patch/266560/
State New
Headers show

Pull-request

git://linux-arm.org/linux-2.6-lp.git tags/cpuidle-bL

Comments

Lorenzo Pieralisi - Aug. 12, 2013, 3:34 p.m.
Hi Olof, Kevin,

please pull this patch series that provides a CPU idle driver for the vexpress
TC2 testchip, and it is a stepping stone towards an ARM unified CPU idle driver
based on the MCPM framework.

Series is based against this pull request from Pawel which is a strict
dependency and they must be merged in order:

http://lists.infradead.org/pipermail/linux-arm-kernel/2013-August/190067.html

Thanks !!
Lorenzo

The following changes since commit 2d6746c48076fd56619f11cdd5c74656ea8cde48:

  ARM: vexpress/TC2: implement PM suspend method (2013-08-12 10:59:13 +0100)

are available in the git repository at:

  git://linux-arm.org/linux-2.6-lp.git tags/cpuidle-bL

for you to fetch changes up to 04c40064928d3a1eb50e4ea3883765b9cfcb0f73:

  cpuidle: big.LITTLE: vexpress-TC2 CPU idle driver (2013-08-12 10:59:14 +0100)

----------------------------------------------------------------
This patch series contains:

- GIC driver update to add a method to disable the GIC CPU IF
- TC2 MCPM update to add GIC CPU disabling to suspend method
- TC2 CPU idle big.LITTLE driver

----------------------------------------------------------------
Lorenzo Pieralisi (2):
      ARM: vexpress: tc2: disable GIC CPU IF in tc2_pm_suspend
      cpuidle: big.LITTLE: vexpress-TC2 CPU idle driver

Nicolas Pitre (1):
      drivers: irq-chip: irq-gic: introduce gic_cpu_if_down()

 MAINTAINERS                          |   9 ++
 arch/arm/mach-vexpress/tc2_pm.c      |   2 +
 drivers/cpuidle/Kconfig              |  10 ++
 drivers/cpuidle/Makefile             |   1 +
 drivers/cpuidle/cpuidle-big_little.c | 209 +++++++++++++++++++++++++++++++++++
 drivers/irqchip/irq-gic.c            |   6 +
 include/linux/irqchip/arm-gic.h      |   1 +
 7 files changed, 238 insertions(+)
 create mode 100644 drivers/cpuidle/cpuidle-big_little.c
Lorenzo Pieralisi - Aug. 25, 2013, 9:08 a.m.
Hi Olof, Kevin,

On Mon, Aug 12, 2013 at 04:34:22PM +0100, Lorenzo Pieralisi wrote:
> Hi Olof, Kevin,
> 
> please pull this patch series that provides a CPU idle driver for the vexpress
> TC2 testchip, and it is a stepping stone towards an ARM unified CPU idle driver
> based on the MCPM framework.
> 
> Series is based against this pull request from Pawel which is a strict
> dependency and they must be merged in order:
> 
> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-August/190067.html

May I ask you please the status of this pull request ? It is to know if
it is ok as it is or I have to do something on my side, thanks.

Thank you,
Lorenzo

> Thanks !!
> Lorenzo
> 
> The following changes since commit 2d6746c48076fd56619f11cdd5c74656ea8cde48:
> 
>   ARM: vexpress/TC2: implement PM suspend method (2013-08-12 10:59:13 +0100)
> 
> are available in the git repository at:
> 
>   git://linux-arm.org/linux-2.6-lp.git tags/cpuidle-bL
> 
> for you to fetch changes up to 04c40064928d3a1eb50e4ea3883765b9cfcb0f73:
> 
>   cpuidle: big.LITTLE: vexpress-TC2 CPU idle driver (2013-08-12 10:59:14 +0100)
> 
> ----------------------------------------------------------------
> This patch series contains:
> 
> - GIC driver update to add a method to disable the GIC CPU IF
> - TC2 MCPM update to add GIC CPU disabling to suspend method
> - TC2 CPU idle big.LITTLE driver
> 
> ----------------------------------------------------------------
> Lorenzo Pieralisi (2):
>       ARM: vexpress: tc2: disable GIC CPU IF in tc2_pm_suspend
>       cpuidle: big.LITTLE: vexpress-TC2 CPU idle driver
> 
> Nicolas Pitre (1):
>       drivers: irq-chip: irq-gic: introduce gic_cpu_if_down()
> 
>  MAINTAINERS                          |   9 ++
>  arch/arm/mach-vexpress/tc2_pm.c      |   2 +
>  drivers/cpuidle/Kconfig              |  10 ++
>  drivers/cpuidle/Makefile             |   1 +
>  drivers/cpuidle/cpuidle-big_little.c | 209 +++++++++++++++++++++++++++++++++++
>  drivers/irqchip/irq-gic.c            |   6 +
>  include/linux/irqchip/arm-gic.h      |   1 +
>  7 files changed, 238 insertions(+)
>  create mode 100644 drivers/cpuidle/cpuidle-big_little.c
Olof Johansson - Aug. 28, 2013, 6:36 p.m.
On Sun, Aug 25, 2013 at 10:08:48AM +0100, Lorenzo Pieralisi wrote:
> Hi Olof, Kevin,
> 
> On Mon, Aug 12, 2013 at 04:34:22PM +0100, Lorenzo Pieralisi wrote:
> > Hi Olof, Kevin,
> > 
> > please pull this patch series that provides a CPU idle driver for the vexpress
> > TC2 testchip, and it is a stepping stone towards an ARM unified CPU idle driver
> > based on the MCPM framework.
> > 
> > Series is based against this pull request from Pawel which is a strict
> > dependency and they must be merged in order:
> > 
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2013-August/190067.html
> 
> May I ask you please the status of this pull request ? It is to know if
> it is ok as it is or I have to do something on my side, thanks.

This needed a rebase on top of the latest version of the mcpm backend branch,
since it's based on an older version.

I also don't see an ack from any of the cpuidle maintainers, if you want to
take it through arm-soc you need to get them to ack it for that purpose. I see
that you got an informal "It sounds good to me" in
http://www.spinics.net/lists/arm-kernel/msg266442.html, but please be diligent
in collecting these in the future.


So, I've essentially applied the topmost 3 patches in a new branch that's based
on our version of vexpress/mcpm, and merged that in.


-Olof
Lorenzo Pieralisi - Aug. 29, 2013, 9 a.m.
On Wed, Aug 28, 2013 at 07:36:24PM +0100, Olof Johansson wrote:
> On Sun, Aug 25, 2013 at 10:08:48AM +0100, Lorenzo Pieralisi wrote:
> > Hi Olof, Kevin,
> > 
> > On Mon, Aug 12, 2013 at 04:34:22PM +0100, Lorenzo Pieralisi wrote:
> > > Hi Olof, Kevin,
> > > 
> > > please pull this patch series that provides a CPU idle driver for the vexpress
> > > TC2 testchip, and it is a stepping stone towards an ARM unified CPU idle driver
> > > based on the MCPM framework.
> > > 
> > > Series is based against this pull request from Pawel which is a strict
> > > dependency and they must be merged in order:
> > > 
> > > http://lists.infradead.org/pipermail/linux-arm-kernel/2013-August/190067.html
> > 
> > May I ask you please the status of this pull request ? It is to know if
> > it is ok as it is or I have to do something on my side, thanks.
> 
> This needed a rebase on top of the latest version of the mcpm backend branch,
> since it's based on an older version.

Yes, I mentioned that in other threads, just wanted to avoid sending another
pull request when patches still apply cleanly, there was no real reson to do
that.

> I also don't see an ack from any of the cpuidle maintainers, if you want to
> take it through arm-soc you need to get them to ack it for that purpose. I see
> that you got an informal "It sounds good to me" in
> http://www.spinics.net/lists/arm-kernel/msg266442.html, but please be diligent
> in collecting these in the future.

Daniel signed off the CPU idle driver patch; as for the two other patches, one
is co-authored with Nico, and one is a one-liner that just updates the
vexpress MCPM back-end. I think this should be enough, but your point is taken,
I just could not ask Daniel to ack a patch he already signed off.

> So, I've essentially applied the topmost 3 patches in a new branch that's based
> on our version of vexpress/mcpm, and merged that in.

That's great, thank you very much, please let me know if you need help.

Thanks,
Lorenzo
Daniel Lezcano - Aug. 29, 2013, 9:13 a.m.
On 08/28/2013 08:36 PM, Olof Johansson wrote:
> On Sun, Aug 25, 2013 at 10:08:48AM +0100, Lorenzo Pieralisi wrote:
>> Hi Olof, Kevin,
>>
>> On Mon, Aug 12, 2013 at 04:34:22PM +0100, Lorenzo Pieralisi wrote:
>>> Hi Olof, Kevin,
>>>
>>> please pull this patch series that provides a CPU idle driver for the vexpress
>>> TC2 testchip, and it is a stepping stone towards an ARM unified CPU idle driver
>>> based on the MCPM framework.
>>>
>>> Series is based against this pull request from Pawel which is a strict
>>> dependency and they must be merged in order:
>>>
>>> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-August/190067.html
>>
>> May I ask you please the status of this pull request ? It is to know if
>> it is ok as it is or I have to do something on my side, thanks.
> 
> This needed a rebase on top of the latest version of the mcpm backend branch,
> since it's based on an older version.
> 
> I also don't see an ack from any of the cpuidle maintainers, if you want to
> take it through arm-soc you need to get them to ack it for that purpose. I see
> that you got an informal "It sounds good to me" in
> http://www.spinics.net/lists/arm-kernel/msg266442.html, but please be diligent
> in collecting these in the future.

Hi Olof,

there is my signed-off for the cpuidle patch because I wrote part of it
and Lorenzo finished it. This is why I thought it was not necessary to
add my acked-by.

> So, I've essentially applied the topmost 3 patches in a new branch that's based
> on our version of vexpress/mcpm, and merged that in.

Cool thanks !

  -- Daniel