Patchwork [1/1] mtd: diskonchip: Fix incorrect placement of __initdata

login
register
mail settings
Submitter Sachin Kamat
Date Aug. 12, 2013, 9:40 a.m.
Message ID <1376300447-7126-1-git-send-email-sachin.kamat@linaro.org>
Download mbox | patch
Permalink /patch/266474/
State Accepted
Commit 14a95b8a23133f1b21bb3e8b05d24d03ab5722c0
Headers show

Comments

Sachin Kamat - Aug. 12, 2013, 9:40 a.m.
__initdata should be placed between the variable name and equal
sign for the variable to be placed in the intended section.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/mtd/nand/diskonchip.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Brian Norris - Oct. 2, 2013, 8:20 p.m.
On Mon, Aug 12, 2013 at 03:10:47PM +0530, Sachin Kamat wrote:
> __initdata should be placed between the variable name and equal
> sign for the variable to be placed in the intended section.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/mtd/nand/diskonchip.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/diskonchip.c b/drivers/mtd/nand/diskonchip.c
> index eaa3c29..b68a495 100644
> --- a/drivers/mtd/nand/diskonchip.c
> +++ b/drivers/mtd/nand/diskonchip.c
> @@ -38,7 +38,7 @@
>  #define CONFIG_MTD_NAND_DISKONCHIP_PROBE_ADDRESS 0
>  #endif
>  
> -static unsigned long __initdata doc_locations[] = {
> +static unsigned long doc_locations[] __initdata = {
>  #if defined (__alpha__) || defined(__i386__) || defined(__x86_64__)
>  #ifdef CONFIG_MTD_NAND_DISKONCHIP_PROBE_HIGH
>  	0xfffc8000, 0xfffca000, 0xfffcc000, 0xfffce000,

Pushed to l2-mtd.git. If you're really interested in seeing this
changed, there are a few other similar places in drivers/mtd/. Feel free
to send a patch.

Thanks,
Brian
Sachin Kamat - Oct. 3, 2013, 7:02 a.m.
On 3 October 2013 01:50, Brian Norris <computersforpeace@gmail.com> wrote:
> On Mon, Aug 12, 2013 at 03:10:47PM +0530, Sachin Kamat wrote:
>> -static unsigned long __initdata doc_locations[] = {
>> +static unsigned long doc_locations[] __initdata = {
>>  #if defined (__alpha__) || defined(__i386__) || defined(__x86_64__)
>>  #ifdef CONFIG_MTD_NAND_DISKONCHIP_PROBE_HIGH
>>       0xfffc8000, 0xfffca000, 0xfffcc000, 0xfffce000,
>

> Pushed to l2-mtd.git.

Thanks.

> If you're really interested in seeing this
> changed, there are a few other similar places in drivers/mtd/. Feel free
> to send a patch.
>

Sure. I will take a look at remaining instances and send the necessary patches.
Thanks.

Patch

diff --git a/drivers/mtd/nand/diskonchip.c b/drivers/mtd/nand/diskonchip.c
index eaa3c29..b68a495 100644
--- a/drivers/mtd/nand/diskonchip.c
+++ b/drivers/mtd/nand/diskonchip.c
@@ -38,7 +38,7 @@ 
 #define CONFIG_MTD_NAND_DISKONCHIP_PROBE_ADDRESS 0
 #endif
 
-static unsigned long __initdata doc_locations[] = {
+static unsigned long doc_locations[] __initdata = {
 #if defined (__alpha__) || defined(__i386__) || defined(__x86_64__)
 #ifdef CONFIG_MTD_NAND_DISKONCHIP_PROBE_HIGH
 	0xfffc8000, 0xfffca000, 0xfffcc000, 0xfffce000,