From patchwork Fri Aug 9 22:02:03 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Dilger X-Patchwork-Id: 266176 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E518B2C00BB for ; Sat, 10 Aug 2013 08:11:44 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031250Ab3HIWLo (ORCPT ); Fri, 9 Aug 2013 18:11:44 -0400 Received: from smtp-out-05.shaw.ca ([64.59.134.13]:40309 "EHLO smtp-out-05.shaw.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031204Ab3HIWLn (ORCPT ); Fri, 9 Aug 2013 18:11:43 -0400 X-Greylist: delayed 577 seconds by postgrey-1.27 at vger.kernel.org; Fri, 09 Aug 2013 18:11:43 EDT X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=/OolT88hxzZB4/D8S1pLLnpaRVcdzwgG3HupJc0czqk= c=1 sm=1 a=Uu0qCeBZ9RUA:10 a=BLceEmwcHowA:10 a=sQcIUxX0G8DGr1HsvJ29bQ==:17 a=MOgk78zF1bMkf3KKSToA:9 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117 Received: from unknown (HELO sookie-gig.adilger.int) ([96.51.76.157]) by smtp-out-05.shaw.ca with ESMTP; 09 Aug 2013 16:02:05 -0600 From: Andreas Dilger To: tytso@mit.edu Cc: linux-ext4@vger.kernel.org, Andreas Dilger Subject: [PATCH] mmp: fix 64-bit handling of s_mmp_block Date: Fri, 9 Aug 2013 16:02:03 -0600 Message-Id: <1376085723-4314-1-git-send-email-adilger@dilger.ca> X-Mailer: git-send-email 1.7.3.4 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Fix the checking of s_mmp_block in e2fsck_pass1() and ext2fs_mmp_read() to handle the high 32 bits of s_blocks_count. Remove redundant check of s_mmp_block in do_dump_mmp() right before ext2fs_mmp_read() is called. Also fix s_blocks_count_hi in check_backup_super_block(), since it cannot use the ext2fs_blocks_count() helper easily. Signed-off-by: Andreas Dilger --- debugfs/debugfs.c | 5 ----- e2fsck/pass1.c | 4 ++-- e2fsck/super.c | 1 + lib/ext2fs/mmp.c | 2 +- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c index 2a1525a..6e97882 100644 --- a/debugfs/debugfs.c +++ b/debugfs/debugfs.c @@ -2243,11 +2243,6 @@ void do_dump_mmp(int argc EXT2FS_ATTR((unused)), char *argv[]) return; sb = current_fs->super; - if (sb->s_mmp_block <= sb->s_first_data_block || - sb->s_mmp_block >= ext2fs_blocks_count(sb)) { - com_err(argv[0], EXT2_ET_MMP_BAD_BLOCK, "while dumping it.\n"); - return; - } if (current_fs->mmp_buf == NULL) { retval = ext2fs_get_mem(current_fs->blocksize, diff --git a/e2fsck/pass1.c b/e2fsck/pass1.c index 9c37515..7f73e8a 100644 --- a/e2fsck/pass1.c +++ b/e2fsck/pass1.c @@ -716,8 +716,8 @@ void e2fsck_pass1(e2fsck_t ctx) busted_fs_time = 1; if ((fs->super->s_feature_incompat & EXT4_FEATURE_INCOMPAT_MMP) && - !(fs->super->s_mmp_block <= fs->super->s_first_data_block || - fs->super->s_mmp_block >= fs->super->s_blocks_count)) + fs->super->s_mmp_block > fs->super->s_first_data_block && + fs->super->s_mmp_block < ext2fs_blocks_count(fs->super)) ext2fs_mark_block_bitmap2(ctx->block_found_map, fs->super->s_mmp_block); diff --git a/e2fsck/super.c b/e2fsck/super.c index b9870f7..ce97a70 100644 --- a/e2fsck/super.c +++ b/e2fsck/super.c @@ -945,6 +945,7 @@ int check_backup_super_block(e2fsck_t ctx) SUPER_INCOMPAT_DIFFERENT(s_feature_incompat) || SUPER_RO_COMPAT_DIFFERENT(s_feature_ro_compat) || SUPER_DIFFERENT(s_blocks_count) || + SUPER_DIFFERENT(s_blocks_count_hi) || SUPER_DIFFERENT(s_inodes_count) || memcmp(fs->super->s_uuid, backup_sb->s_uuid, sizeof(fs->super->s_uuid))) diff --git a/lib/ext2fs/mmp.c b/lib/ext2fs/mmp.c index 435c5f4..ad20650 100644 --- a/lib/ext2fs/mmp.c +++ b/lib/ext2fs/mmp.c @@ -37,7 +37,7 @@ errcode_t ext2fs_mmp_read(ext2_filsys fs, blk64_t mmp_blk, void *buf) errcode_t retval = 0; if ((mmp_blk <= fs->super->s_first_data_block) || - (mmp_blk >= fs->super->s_blocks_count)) + (mmp_blk >= ext2fs_blocks_count(fs->super))) return EXT2_ET_MMP_BAD_BLOCK; /* ext2fs_open() reserves fd0,1,2 to avoid stdio collision, so checking