Patchwork mtd: m25p80: Micron SPI uses Macronix-style 4-byte addressing

login
register
mail settings
Submitter Brian Norris
Date Aug. 9, 2013, 6:24 p.m.
Message ID <1376072646-26089-1-git-send-email-computersforpeace@gmail.com>
Download mbox | patch
Permalink /patch/266130/
State Accepted
Commit eedeac3ce94e2a3d4ff28974221b9f309358d8de
Headers show

Comments

Brian Norris - Aug. 9, 2013, 6:24 p.m.
For SPI NOR flash that are larger than 128Mbit (16MiB), we need 4 bytes
of address space to reach the entire flash; however, the original SPI
flash protocol used only 3 bytes for the address. So far, the practice
for handling this has been either to use new command opcodes that are
defined to use 4 bytes for their address, or to use special
mode-switching command to configure all traditionally-3-byte-address
commands to take 4 bytes instead.

Macronix and Spansion developed two incompatible methods for
entering/exiting "4-byte address mode." Micron flash uses the Macronix
method (OPCODE_{EN4B,EX4B}), not the Spansion method.

This patch solves addressing issues on Micron n25q256a and provides the
ability to support other future Micron SPI flash >16MiB.

Quoting a Micron representative:

  "Majority of our NOR that needs 4-byte addressing (256Mb or 32MB and
   higher) enter and exit 4byte through B7h and E9h commands. The
   N25Q256A7xxx and N25Q512A7xxx parts do not support 4-byte addressing
   mode via B7h or E9h command."

They further clarified that those that don't support the enter/exit
opcodes (B7h/E9h) are manufactured specifically to come up by default in
4-byte mode. We don't need to treat those parts any diffently, as they
will discard the EN4B opcode as a no-op.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: Marek Vasut <marex@denx.de>
Cc: <stable@vger.kernel.org> # 3.10+
---
 drivers/mtd/devices/m25p80.c | 1 +
 1 file changed, 1 insertion(+)
Marek Vasut - Aug. 9, 2013, 6:46 p.m.
Dear Brian Norris,

> For SPI NOR flash that are larger than 128Mbit (16MiB), we need 4 bytes
> of address space to reach the entire flash; however, the original SPI
> flash protocol used only 3 bytes for the address. So far, the practice
> for handling this has been either to use new command opcodes that are
> defined to use 4 bytes for their address, or to use special
> mode-switching command to configure all traditionally-3-byte-address
> commands to take 4 bytes instead.
> 
> Macronix and Spansion developed two incompatible methods for
> entering/exiting "4-byte address mode." Micron flash uses the Macronix
> method (OPCODE_{EN4B,EX4B}), not the Spansion method.
> 
> This patch solves addressing issues on Micron n25q256a and provides the
> ability to support other future Micron SPI flash >16MiB.
> 
> Quoting a Micron representative:
> 
>   "Majority of our NOR that needs 4-byte addressing (256Mb or 32MB and
>    higher) enter and exit 4byte through B7h and E9h commands. The
>    N25Q256A7xxx and N25Q512A7xxx parts do not support 4-byte addressing
>    mode via B7h or E9h command."
> 
> They further clarified that those that don't support the enter/exit
> opcodes (B7h/E9h) are manufactured specifically to come up by default in
> 4-byte mode. We don't need to treat those parts any diffently, as they
> will discard the EN4B opcode as a no-op.
> 
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> Cc: Marek Vasut <marex@denx.de>
> Cc: <stable@vger.kernel.org> # 3.10+
> ---
>  drivers/mtd/devices/m25p80.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index b5190c4..a759c1f 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -169,6 +169,7 @@ static inline int set_4byte(struct m25p *flash, u32
> jedec_id, int enable) {
>  	switch (JEDEC_MFR(jedec_id)) {
>  	case CFI_MFR_MACRONIX:
> +	case CFI_MFR_ST: /* Micron, actually */
>  	case 0xEF /* winbond */:
>  		flash->command[0] = enable ? OPCODE_EN4B : OPCODE_EX4B;
>  		return spi_write(flash->spi, flash->command, 1);

The situation with the 4b addressing is a horrible mess :(

Acked-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut
Brian Norris - Aug. 9, 2013, 9:32 p.m.
On Fri, Aug 9, 2013 at 11:24 AM, Brian Norris
<computersforpeace@gmail.com> wrote:
> Quoting a Micron representative:
>
>   "Majority of our NOR that needs 4-byte addressing (256Mb or 32MB and
>    higher) enter and exit 4byte through B7h and E9h commands. The
>    N25Q256A7xxx and N25Q512A7xxx parts do not support 4-byte addressing
>    mode via B7h or E9h command."
>
> They further clarified that those that don't support the enter/exit
> opcodes (B7h/E9h) are manufactured specifically to come up by default in
> 4-byte mode. We don't need to treat those parts any diffently, as they
> will discard the EN4B opcode as a no-op.

A clarification: it seems that *all* large Micron SPI flash support
the B7h and E9h opcodes, just that some default to 4-byte addressing.
The patch stands as-is, but I'd replace this part of the changelog
with:

"Micron confirmed that all large (>16MiB) Micron SPI support the B7h
and E9h opcodes."

Thanks,
Brian
Brian Norris - Aug. 12, 2013, 2:44 a.m.
On Fri, Aug 9, 2013 at 11:46 AM, Marek Vasut <marex@denx.de> wrote:
> Dear Brian Norris,
>
>> For SPI NOR flash that are larger than 128Mbit (16MiB), we need 4 bytes
>> of address space to reach the entire flash; however, the original SPI
>> flash protocol used only 3 bytes for the address. So far, the practice
>> for handling this has been either to use new command opcodes that are
>> defined to use 4 bytes for their address, or to use special
>> mode-switching command to configure all traditionally-3-byte-address
>> commands to take 4 bytes instead.

[snip long description of a mess]

> The situation with the 4b addressing is a horrible mess :(

Agreed. It took me a while to figure out that this was the root of my
problems last week.

> Acked-by: Marek Vasut <marex@denx.de>

Thanks.

Brian
Vivien Didelot - Aug. 12, 2013, 2:06 p.m.
Hi Brian,

----- Mail original -----
> De: "Brian Norris" <computersforpeace@gmail.com>
> À: "Marek Vasut" <marex@denx.de>
> Cc: linux-mtd@lists.infradead.org, stable@vger.kernel.org, "Vivien Didelot" <vivien.didelot@savoirfairelinux.com>
> Envoyé: Dimanche 11 Août 2013 22:44:31
> Objet: Re: [PATCH] mtd: m25p80: Micron SPI uses Macronix-style 4-byte addressing
> 
> On Fri, Aug 9, 2013 at 11:46 AM, Marek Vasut <marex@denx.de> wrote:
> > Dear Brian Norris,
> >
> >> For SPI NOR flash that are larger than 128Mbit (16MiB), we need 4
> >> bytes
> >> of address space to reach the entire flash; however, the original
> >> SPI
> >> flash protocol used only 3 bytes for the address. So far, the
> >> practice
> >> for handling this has been either to use new command opcodes that
> >> are
> >> defined to use 4 bytes for their address, or to use special
> >> mode-switching command to configure all
> >> traditionally-3-byte-address
> >> commands to take 4 bytes instead.
> 
> [snip long description of a mess]
> 
> > The situation with the 4b addressing is a horrible mess :(
> 
> Agreed. It took me a while to figure out that this was the root of my
> problems last week.
> 
> > Acked-by: Marek Vasut <marex@denx.de>
> 
> Thanks.
> 
> Brian
> 

I'm just adding kernel@savoirfairelinux.com in the loop.

Thanks,
Vivien.
Brian Norris - Aug. 17, 2013, 7:31 p.m.
On Fri, Aug 09, 2013 at 11:24:06AM -0700, Brian Norris wrote:
> For SPI NOR flash that are larger than 128Mbit (16MiB), we need 4 bytes
> of address space to reach the entire flash; however, the original SPI
> flash protocol used only 3 bytes for the address. So far, the practice
> for handling this has been either to use new command opcodes that are
> defined to use 4 bytes for their address, or to use special
> mode-switching command to configure all traditionally-3-byte-address
> commands to take 4 bytes instead.
> 
> Macronix and Spansion developed two incompatible methods for
> entering/exiting "4-byte address mode." Micron flash uses the Macronix
> method (OPCODE_{EN4B,EX4B}), not the Spansion method.
> 
> This patch solves addressing issues on Micron n25q256a and provides the
> ability to support other future Micron SPI flash >16MiB.
> 
> Quoting a Micron representative:
> 
>   "Majority of our NOR that needs 4-byte addressing (256Mb or 32MB and
>    higher) enter and exit 4byte through B7h and E9h commands. The
>    N25Q256A7xxx and N25Q512A7xxx parts do not support 4-byte addressing
>    mode via B7h or E9h command."
> 
> They further clarified that those that don't support the enter/exit
> opcodes (B7h/E9h) are manufactured specifically to come up by default in
> 4-byte mode. We don't need to treat those parts any diffently, as they
> will discard the EN4B opcode as a no-op.

Just as a final clarification: Micron corrected themselves back to this
original statement. So some parts will come up in 4-byte mode and will
ignore the EN4B/EX4B commands.

With that, I just pushed this patch to l2-mtd.git with the original
comment, as that was the correct one.

Thanks,
Brian

Patch

diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index b5190c4..a759c1f 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -169,6 +169,7 @@  static inline int set_4byte(struct m25p *flash, u32 jedec_id, int enable)
 {
 	switch (JEDEC_MFR(jedec_id)) {
 	case CFI_MFR_MACRONIX:
+	case CFI_MFR_ST: /* Micron, actually */
 	case 0xEF /* winbond */:
 		flash->command[0] = enable ? OPCODE_EN4B : OPCODE_EX4B;
 		return spi_write(flash->spi, flash->command, 1);