Patchwork [3/3] crypto: dcp: rename 'compatible' property to 'fsl,dcp'

login
register
mail settings
Submitter Lothar Waßmann
Date Aug. 8, 2013, 1:30 p.m.
Message ID <1375968629-10091-4-git-send-email-LW@KARO-electronics.de>
Download mbox | patch
Permalink /patch/265727/
State New
Headers show

Comments

Lothar Waßmann - Aug. 8, 2013, 1:30 p.m.
Leave the old 'fsl-dcp' value in place with an appropriate comment
until external users have updated their DTBs.

Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
 arch/arm/boot/dts/imx28.dtsi |    2 +-
 drivers/crypto/dcp.c         |    2 ++
 2 files changed, 3 insertions(+), 1 deletions(-)
Sergei Shtylyov - Aug. 8, 2013, 7:39 p.m.
Hello.

On 08/08/2013 05:30 PM, Lothar Waßmann wrote:

> Leave the old 'fsl-dcp' value in place with an appropriate comment
> until external users have updated their DTBs.

> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
> ---
>   arch/arm/boot/dts/imx28.dtsi |    2 +-
>   drivers/crypto/dcp.c         |    2 ++
>   2 files changed, 3 insertions(+), 1 deletions(-)

> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index ea99d09..0584935 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -794,7 +794,7 @@
>   			};
>
>   			dcp: dcp@80028000 {

     By the way, I see that this is a crypto device, so it should be named 
"crypto" according to ePAPR spec. [1]

> -				compatible = "fsl-dcp";
> +				compatible = "fsl,dcp";
>   				reg = <0x80028000 0x2000>;
>   				interrupts = <52 53 54>;
>   				status = "disabled";

[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf

WBR, Sergei

Patch

diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index ea99d09..0584935 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -794,7 +794,7 @@ 
 			};
 
 			dcp: dcp@80028000 {
-				compatible = "fsl-dcp";
+				compatible = "fsl,dcp";
 				reg = <0x80028000 0x2000>;
 				interrupts = <52 53 54>;
 				status = "disabled";
diff --git a/drivers/crypto/dcp.c b/drivers/crypto/dcp.c
index 6a2495e..72196c0 100644
--- a/drivers/crypto/dcp.c
+++ b/drivers/crypto/dcp.c
@@ -889,6 +889,8 @@  static int dcp_remove(struct platform_device *pdev)
 }
 
 static struct of_device_id fs_dcp_of_match[] = {
+	{ .compatible = "fsl,dcp", },
+	/* To be removed when the DT blobs referencing this have been updated */
 	{ .compatible = "fsl-dcp", },
 	{}
 };