| Message ID | 1240928041-10905-1-git-send-email-galak@kernel.crashing.org |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Kumar Gala <galak@kernel.crashing.org> Date: Tue, 28 Apr 2009 09:14:01 -0500 > cacheable_memzero() is completely overkill for the clearing out the FCB > block which is only 8-bytes. The compiler should easily optimize this > with memset. Additionally, cacheable_memzero() only exists on ppc32 and > thus breaks builds of gianfar on ppc64. > > Signed-off-by: Kumar Gala <galak@kernel.crashing.org> Applied to net-next-2.6, thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index dae1437..2bb038b 100644 --- a/drivers/net/gianfar.c +++ b/drivers/net/gianfar.c @@ -1207,7 +1207,8 @@ static int gfar_enet_open(struct net_device *dev) static inline struct txfcb *gfar_add_fcb(struct sk_buff *skb) { struct txfcb *fcb = (struct txfcb *)skb_push(skb, GMAC_FCB_LEN); - cacheable_memzero(fcb, GMAC_FCB_LEN); + + memset(fcb, 0, GMAC_FCB_LEN); return fcb; }
cacheable_memzero() is completely overkill for the clearing out the FCB block which is only 8-bytes. The compiler should easily optimize this with memset. Additionally, cacheable_memzero() only exists on ppc32 and thus breaks builds of gianfar on ppc64. Signed-off-by: Kumar Gala <galak@kernel.crashing.org> --- drivers/net/gianfar.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)