Patchwork mtd: onenand: omap: remove two unused functions

login
register
mail settings
Submitter Paul Bolle
Date Aug. 7, 2013, 6:16 p.m.
Message ID <1375899409.7303.61.camel@x61.thuisdomein>
Download mbox | patch
Permalink /patch/265591/
State Accepted
Commit 86bc7bddc9bf7841372df5880805506228dbf4f4
Headers show

Comments

Paul Bolle - Aug. 7, 2013, 6:16 p.m.
Nothing calls omap2_onenand_rephase(). And __adjust_timing() is only
called by omap2_onenand_rephase(). Remove these two unused functions.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Completely untested.

 drivers/mtd/onenand/omap2.c | 22 ----------------------
 1 file changed, 22 deletions(-)
Brian Norris - Sept. 17, 2013, 2:24 a.m.
On Wed, Aug 07, 2013 at 08:16:49PM +0200, Paul Bolle wrote:
> Nothing calls omap2_onenand_rephase(). And __adjust_timing() is only
> called by omap2_onenand_rephase(). Remove these two unused functions.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Completely untested.

Compile-tested successfully here. And it gets rid of a few sparse warnings:

  drivers/mtd/onenand/omap2.c:592:5: warning: no previous prototype for 'omap2_onenand_rephase' [-Wmissing-prototypes]
  drivers/mtd/onenand/omap2.c:592:5: warning: symbol 'omap2_onenand_rephase' was not declared. Should it be static? [sparse]

Applied to l2-mtd.git. Thanks!

Brian

Patch

diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
index d98b198..1d43fdc 100644
--- a/drivers/mtd/onenand/omap2.c
+++ b/drivers/mtd/onenand/omap2.c
@@ -573,28 +573,6 @@  static int omap2_onenand_write_bufferram(struct mtd_info *mtd, int area,
 
 static struct platform_driver omap2_onenand_driver;
 
-static int __adjust_timing(struct device *dev, void *data)
-{
-	int ret = 0;
-	struct omap2_onenand *c;
-
-	c = dev_get_drvdata(dev);
-
-	BUG_ON(c->setup == NULL);
-
-	/* DMA is not in use so this is all that is needed */
-	/* Revisit for OMAP3! */
-	ret = c->setup(c->onenand.base, &c->freq);
-
-	return ret;
-}
-
-int omap2_onenand_rephase(void)
-{
-	return driver_for_each_device(&omap2_onenand_driver.driver, NULL,
-				      NULL, __adjust_timing);
-}
-
 static void omap2_onenand_shutdown(struct platform_device *pdev)
 {
 	struct omap2_onenand *c = dev_get_drvdata(&pdev->dev);