Message ID | 1375890758-30265-3-git-send-email-mark.langsdorf@calxeda.com |
---|---|
State | Not Applicable |
Delegated to: | David Miller |
Headers | show |
On Aug 7, 2013, at 10:52 AM, Mark Langsdorf wrote: > The Calxeda sata_highbank driver has been adding its descriptions to the > ahci driver. Separate them properly. > > Signed-off-by: Mark Langsdorf <mark.langsdorf@calxeda.com> > Acked-by: Rob Herring <rob.herring@calxeda.com> > --- > Changes from v2 > Fixed some indenting. > Changes from v1 > None. > > .../devicetree/bindings/ata/ahci-platform.txt | 18 +++--------- > .../devicetree/bindings/ata/sata_highbank.txt | 32 ++++++++++++++++++++++ > 2 files changed, 36 insertions(+), 14 deletions(-) > create mode 100644 Documentation/devicetree/bindings/ata/sata_highbank.txt > > diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Documentation/devicetree/bindings/ata/ahci-platform.txt > index 3ec0c5c..89de156 100644 > --- a/Documentation/devicetree/bindings/ata/ahci-platform.txt > +++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt > @@ -4,27 +4,17 @@ SATA nodes are defined to describe on-chip Serial ATA controllers. > Each SATA controller should have its own node. > > Required properties: > -- compatible : compatible list, contains "calxeda,hb-ahci" or "snps,spear-ahci" > +- compatible : compatible list, contains "snps,spear-ahci" > - interrupts : <interrupt mapping for SATA IRQ> > - reg : <registers mapping> > > Optional properties: > -- calxeda,port-phys: phandle-combophy and lane assignment, which maps each > - SATA port to a combophy and a lane within that > - combophy > -- calxeda,sgpio-gpio: phandle-gpio bank, bit offset, and default on or off, > - which indicates that the driver supports SGPIO > - indicator lights using the indicated GPIOs > -- calxeda,led-order : a u32 array that map port numbers to offsets within the > - SGPIO bitstream. > - dma-coherent : Present if dma operations are coherent > > Example: > sata@ffe08000 { > - compatible = "calxeda,hb-ahci"; > - reg = <0xffe08000 0x1000>; > - interrupts = <115>; > - calxeda,port-phys = <&combophy5 0 &combophy0 0 &combophy0 1 > - &combophy0 2 &combophy0 3>; > + compatible = "snps,spear-ahci"; > + reg = <0xffe08000 0x1000>; > + interrupts = <115>; > > }; > diff --git a/Documentation/devicetree/bindings/ata/sata_highbank.txt b/Documentation/devicetree/bindings/ata/sata_highbank.txt > new file mode 100644 > index 0000000..1ac6d3d > --- /dev/null > +++ b/Documentation/devicetree/bindings/ata/sata_highbank.txt > @@ -0,0 +1,32 @@ > +* Calxeda AHCI SATA Controller > + > +SATA nodes are defined to describe on-chip Serial ATA controllers. > +The Calxeda SATA controller mostly conforms to the AHCI interface > +with some special extensions to add functionality. > +Each SATA controller should have its own node. > + > +Required properties: > +- compatible : compatible list, contains "calxeda,hb-ahci" > +- interrupts : <interrupt mapping for SATA IRQ> > +- reg : <registers mapping> > + > +Optional properties: > +- dma-coherent : Present if dma operations are coherent > +- calxeda,port-phys: phandle-combophy and lane assignment, which maps each > + SATA port to a combophy and a lane within that > + combophy > +- calxeda,sgpio-gpio: phandle-gpio bank, bit offset, and default on or off, > + which indicates that the driver supports SGPIO > + indicator lights using the indicated GPIOs > +- calxeda,led-order : a u32 array that map port numbers to offsets within the > + SGPIO bitstream. nit: whitespace after : > + > +Example: > + sata@ffe08000 { > + compatible = "calxeda,hb-ahci"; > + reg = <0xffe08000 0x1000>; > + interrupts = <115>; > + calxeda,port-phys = <&combophy5 0 &combophy0 0 &combophy0 1 > + &combophy0 2 &combophy0 3>; > + Its probably good to show all optional props (dma-coherent, calxeda,sgpio-gpios, & calxeda,led-order) in the example. > + }; > -- > 1.8.1.2 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Aug 07, 2013 at 04:52:36PM +0100, Mark Langsdorf wrote: > The Calxeda sata_highbank driver has been adding its descriptions to the > ahci driver. Separate them properly. > > Signed-off-by: Mark Langsdorf <mark.langsdorf@calxeda.com> > Acked-by: Rob Herring <rob.herring@calxeda.com> > --- > Changes from v2 > Fixed some indenting. > Changes from v1 > None. > > .../devicetree/bindings/ata/ahci-platform.txt | 18 +++--------- > .../devicetree/bindings/ata/sata_highbank.txt | 32 ++++++++++++++++++++++ > 2 files changed, 36 insertions(+), 14 deletions(-) > create mode 100644 Documentation/devicetree/bindings/ata/sata_highbank.txt > > diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Documentation/devicetree/bindings/ata/ahci-platform.txt > index 3ec0c5c..89de156 100644 > --- a/Documentation/devicetree/bindings/ata/ahci-platform.txt > +++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt > @@ -4,27 +4,17 @@ SATA nodes are defined to describe on-chip Serial ATA controllers. > Each SATA controller should have its own node. > > Required properties: > -- compatible : compatible list, contains "calxeda,hb-ahci" or "snps,spear-ahci" > +- compatible : compatible list, contains "snps,spear-ahci" > - interrupts : <interrupt mapping for SATA IRQ> > - reg : <registers mapping> > > Optional properties: > -- calxeda,port-phys: phandle-combophy and lane assignment, which maps each > - SATA port to a combophy and a lane within that > - combophy > -- calxeda,sgpio-gpio: phandle-gpio bank, bit offset, and default on or off, > - which indicates that the driver supports SGPIO > - indicator lights using the indicated GPIOs > -- calxeda,led-order : a u32 array that map port numbers to offsets within the > - SGPIO bitstream. > - dma-coherent : Present if dma operations are coherent > > Example: > sata@ffe08000 { > - compatible = "calxeda,hb-ahci"; > - reg = <0xffe08000 0x1000>; > - interrupts = <115>; > - calxeda,port-phys = <&combophy5 0 &combophy0 0 &combophy0 1 > - &combophy0 2 &combophy0 3>; > + compatible = "snps,spear-ahci"; > + reg = <0xffe08000 0x1000>; > + interrupts = <115>; > > }; > diff --git a/Documentation/devicetree/bindings/ata/sata_highbank.txt b/Documentation/devicetree/bindings/ata/sata_highbank.txt > new file mode 100644 > index 0000000..1ac6d3d > --- /dev/null > +++ b/Documentation/devicetree/bindings/ata/sata_highbank.txt > @@ -0,0 +1,32 @@ > +* Calxeda AHCI SATA Controller > + > +SATA nodes are defined to describe on-chip Serial ATA controllers. > +The Calxeda SATA controller mostly conforms to the AHCI interface > +with some special extensions to add functionality. > +Each SATA controller should have its own node. > + > +Required properties: > +- compatible : compatible list, contains "calxeda,hb-ahci" > +- interrupts : <interrupt mapping for SATA IRQ> > +- reg : <registers mapping> > + > +Optional properties: > +- dma-coherent : Present if dma operations are coherent > +- calxeda,port-phys: phandle-combophy and lane assignment, which maps each > + SATA port to a combophy and a lane within that > + combophy > +- calxeda,sgpio-gpio: phandle-gpio bank, bit offset, and default on or off, > + which indicates that the driver supports SGPIO > + indicator lights using the indicated GPIOs > +- calxeda,led-order : a u32 array that map port numbers to offsets within the > + SGPIO bitstream. > + > +Example: > + sata@ffe08000 { > + compatible = "calxeda,hb-ahci"; > + reg = <0xffe08000 0x1000>; > + interrupts = <115>; > + calxeda,port-phys = <&combophy5 0 &combophy0 0 &combophy0 1 > + &combophy0 2 &combophy0 3>; > + > + }; It would be nice to have examples for the remaining optional properties, but otherwise: Acked-by: Mark Rutland <mark.rutland@arm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Aug 07, 2013 at 10:52:36AM -0500, Mark Langsdorf wrote: > The Calxeda sata_highbank driver has been adding its descriptions to the > ahci driver. Separate them properly. > > Signed-off-by: Mark Langsdorf <mark.langsdorf@calxeda.com> > Acked-by: Rob Herring <rob.herring@calxeda.com> Will wait for the update. I suppose this doesn't need to go in to for-3.11-fixes? I'd really appreciate what impact each patch has. Thanks.
On Fri, Aug 09, 2013 at 12:10:15PM -0400, Tejun Heo wrote: > Will wait for the update. I suppose this doesn't need to go in to > for-3.11-fixes? I'd really appreciate what impact each patch has. ^ descriptions of
On 08/09/2013 11:10 AM, Tejun Heo wrote: > On Wed, Aug 07, 2013 at 10:52:36AM -0500, Mark Langsdorf wrote: >> The Calxeda sata_highbank driver has been adding its descriptions to the >> ahci driver. Separate them properly. >> >> Signed-off-by: Mark Langsdorf <mark.langsdorf@calxeda.com> >> Acked-by: Rob Herring <rob.herring@calxeda.com> > > Will wait for the update. I suppose this doesn't need to go in to > for-3.11-fixes? I'd really appreciate what impact each patch has. I'll update the description when I resubmit it to give you more detail on the impact. Thanks for applying the others. --Mark Langsdorf Calxeda, Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello, Mark. On Fri, Aug 9, 2013 at 12:12 PM, Mark Langsdorf <mark.langsdorf@calxeda.com> wrote: > I'll update the description when I resubmit it to give you more detail on > the impact. Yes, please give me some hints on to which branch the patches are targeted and whether stable should be cc'd. I can't really tell just looking at the patches as I have no idea how widespread the device is in the wild and which kernels they'd be running or how critical being out-of-spec is (is it gonna burn phys on the receiving end in the long term? or is it just noisier and the link is gonna be more susceptible to errors from EM interferences and so on) and how risky the fixes are. Thanks.
diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Documentation/devicetree/bindings/ata/ahci-platform.txt index 3ec0c5c..89de156 100644 --- a/Documentation/devicetree/bindings/ata/ahci-platform.txt +++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt @@ -4,27 +4,17 @@ SATA nodes are defined to describe on-chip Serial ATA controllers. Each SATA controller should have its own node. Required properties: -- compatible : compatible list, contains "calxeda,hb-ahci" or "snps,spear-ahci" +- compatible : compatible list, contains "snps,spear-ahci" - interrupts : <interrupt mapping for SATA IRQ> - reg : <registers mapping> Optional properties: -- calxeda,port-phys: phandle-combophy and lane assignment, which maps each - SATA port to a combophy and a lane within that - combophy -- calxeda,sgpio-gpio: phandle-gpio bank, bit offset, and default on or off, - which indicates that the driver supports SGPIO - indicator lights using the indicated GPIOs -- calxeda,led-order : a u32 array that map port numbers to offsets within the - SGPIO bitstream. - dma-coherent : Present if dma operations are coherent Example: sata@ffe08000 { - compatible = "calxeda,hb-ahci"; - reg = <0xffe08000 0x1000>; - interrupts = <115>; - calxeda,port-phys = <&combophy5 0 &combophy0 0 &combophy0 1 - &combophy0 2 &combophy0 3>; + compatible = "snps,spear-ahci"; + reg = <0xffe08000 0x1000>; + interrupts = <115>; }; diff --git a/Documentation/devicetree/bindings/ata/sata_highbank.txt b/Documentation/devicetree/bindings/ata/sata_highbank.txt new file mode 100644 index 0000000..1ac6d3d --- /dev/null +++ b/Documentation/devicetree/bindings/ata/sata_highbank.txt @@ -0,0 +1,32 @@ +* Calxeda AHCI SATA Controller + +SATA nodes are defined to describe on-chip Serial ATA controllers. +The Calxeda SATA controller mostly conforms to the AHCI interface +with some special extensions to add functionality. +Each SATA controller should have its own node. + +Required properties: +- compatible : compatible list, contains "calxeda,hb-ahci" +- interrupts : <interrupt mapping for SATA IRQ> +- reg : <registers mapping> + +Optional properties: +- dma-coherent : Present if dma operations are coherent +- calxeda,port-phys: phandle-combophy and lane assignment, which maps each + SATA port to a combophy and a lane within that + combophy +- calxeda,sgpio-gpio: phandle-gpio bank, bit offset, and default on or off, + which indicates that the driver supports SGPIO + indicator lights using the indicated GPIOs +- calxeda,led-order : a u32 array that map port numbers to offsets within the + SGPIO bitstream. + +Example: + sata@ffe08000 { + compatible = "calxeda,hb-ahci"; + reg = <0xffe08000 0x1000>; + interrupts = <115>; + calxeda,port-phys = <&combophy5 0 &combophy0 0 &combophy0 1 + &combophy0 2 &combophy0 3>; + + };