From patchwork Wed Aug 7 11:09:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lekensteyn <1209180@bugs.launchpad.net> X-Patchwork-Id: 265519 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id BACDF2C033B for ; Thu, 8 Aug 2013 00:23:02 +1000 (EST) Received: from localhost ([::1]:45597 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V74dg-00070J-2m for incoming@patchwork.ozlabs.org; Wed, 07 Aug 2013 10:23:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V71iU-0005DF-QH for qemu-devel@nongnu.org; Wed, 07 Aug 2013 07:15:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V71iN-0001uU-0i for qemu-devel@nongnu.org; Wed, 07 Aug 2013 07:15:46 -0400 Received: from indium.canonical.com ([91.189.90.7]:59556) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V71iM-0001uN-Ns for qemu-devel@nongnu.org; Wed, 07 Aug 2013 07:15:38 -0400 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.71 #1 (Debian)) id 1V71iM-0006dg-2e for ; Wed, 07 Aug 2013 11:15:38 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id E992B2E808D for ; Wed, 7 Aug 2013 11:15:37 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 07 Aug 2013 11:09:01 -0000 From: Lekensteyn <1209180@bugs.launchpad.net> To: qemu-devel@nongnu.org X-Launchpad-Bug: product=qemu; status=New; importance=Undecided; assignee=None; X-Launchpad-Bug-Information-Type: Public X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: lekensteyn X-Launchpad-Bug-Reporter: Lekensteyn (lekensteyn) X-Launchpad-Bug-Modifier: Lekensteyn (lekensteyn) References: <20130807110901.6617.23985.malonedeb@soybean.canonical.com> Message-Id: <20130807110901.6617.23985.malonedeb@soybean.canonical.com> X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="16721"; Instance="launchpad-lazr.conf" X-Launchpad-Hash: 510fcbc19a60505bd6a14a14530b87d8fce433e8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 91.189.90.7 X-Mailman-Approved-At: Wed, 07 Aug 2013 10:22:30 -0400 Subject: [Qemu-devel] [Bug 1209180] [NEW] hw/usb/core.c:415: usb_handle_packet: Assertion `p->ep->type != 3 || (dev->flags & (1 << USB_DEV_FLAG_IS_HOST))' failed X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Reply-To: Bug 1209180 <1209180@bugs.launchpad.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Public bug reported: After the patch at http://lists.nongnu.org/archive/html/qemu- devel/2013-05/msg01567.html, I cannot get my Logitech Unifying USB receiver passed to the guest anymore. Minimal reproduction command: qemu-system-x86_64 -usbdevice host:046d:c52b Debug patch: yields: type=0 1 1 0x5555565de4c0 0x5555565de4c0 type=0 1 1 0x5555565de4c0 0x5555565de4c0 type=0 1 1 0x5555565de4c0 0x5555565de4c0 type=0 1 1 0x5555565de4c0 0x5555565de4c0 type=0 1 1 0x5555565de4c0 0x5555565de4c0 type=3 1 1 0x5555565de4c0 0x5555565de4c0 qemu-system-x86_64: hw/usb/core.c:415: usb_handle_packet: Assertion `p->ep->type != 3 || (dev->flags & (1 << USB_DEV_FLAG_IS_HOST))' failed. Program received signal SIGABRT, Aborted. 0x00007ffff10c61c9 in raise () from /usr/lib/libc.so.6 (gdb) bt #0 0x00007ffff10c61c9 in raise () from /usr/lib/libc.so.6 #1 0x00007ffff10c75c8 in abort () from /usr/lib/libc.so.6 #2 0x00007ffff10bf356 in __assert_fail_base () from /usr/lib/libc.so.6 #3 0x00007ffff10bf402 in __assert_fail () from /usr/lib/libc.so.6 #4 0x00005555556e4b38 in usb_handle_packet (dev=, p=p@entry=0x5555565da610) at hw/usb/core.c:414 #5 0x00005555556f93ef in uhci_handle_td (s=s@entry=0x5555565ce5d0, q=0x5555566a9dc0, q@entry=0x0, qh_addr=qh_addr@entry=980834, td=td@entry=0x7fffffffdd30, td_addr=, int_mask=int_mask@entry=0x7fffffffdd1c) at hw/usb/hcd-uhci.c:904 #6 0x00005555556f9949 in uhci_process_frame (s=s@entry=0x5555565ce5d0) at hw/usb/hcd-uhci.c:1084 #7 0x00005555556f9c35 in uhci_frame_timer (opaque=0x5555565ce5d0) at hw/usb/hcd-uhci.c:1183 #8 0x000055555573e086 in qemu_run_timers (clock=0x55555654e200) at qemu-timer.c:394 #9 0x000055555573e325 in qemu_run_timers (clock=) at qemu-timer.c:459 #10 qemu_run_all_timers () at qemu-timer.c:452 #11 0x0000555555711bee in main_loop_wait (nonblocking=) at main-loop.c:470 #12 0x00005555555e0161 in main_loop () at vl.c:2029 #13 main (argc=, argv=, envp=) at vl.c:4419 Looking around, I see that host-bsd.c and host-linux.c both set USB_DEV_FLAG_IS_HOST, but host-libusbx.c doesn't do that. Affected QEMU versions: 1.5.1, 1.5.2 Not affected: 1.5.0 libusb version: 1.0.16 ** Affects: qemu Importance: Undecided Status: New diff --git a/hw/usb/core.c b/hw/usb/core.c index 05948ca..20753cc 100644 --- a/hw/usb/core.c +++ b/hw/usb/core.c @@ -409,6 +409,8 @@ void usb_handle_packet(USBDevice *dev, USBPacket *p) /* hcd drivers cannot handle async for isoc */ assert(p->ep->type != USB_ENDPOINT_XFER_ISOC); /* using async for interrupt packets breaks migration */ + printf("type=%x %x %x %p %p\n", p->ep->type, + dev->flags, p->ep->dev->flags, dev, p->ep->dev); assert(p->ep->type != USB_ENDPOINT_XFER_INT || (dev->flags & (1 << USB_DEV_FLAG_IS_HOST))); usb_packet_set_state(p, USB_PACKET_ASYNC);