diff mbox

[U-Boot] edid: rename struct member to fix two EDID_* macros

Message ID 1375860153-2603-1-git-send-email-christian.gmeiner@gmail.com
State Accepted
Delegated to: Anatolij Gustschin
Headers show

Commit Message

Christian Gmeiner Aug. 7, 2013, 7:22 a.m. UTC
Without this change EDID_DETAILED_TIMING_VSYNC_OFFSET
and EDID_DETAILED_TIMING_VSYNC_PULSE_WIDTH macros can
not be used (compile error).
The fix is quite trivial: rename struct member to the
expected name.

Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
---
 include/edid.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christian Gmeiner Aug. 12, 2013, 6:14 a.m. UTC | #1
2013/8/7 Christian Gmeiner <christian.gmeiner@gmail.com>:
> Without this change EDID_DETAILED_TIMING_VSYNC_OFFSET
> and EDID_DETAILED_TIMING_VSYNC_PULSE_WIDTH macros can
> not be used (compile error).
> The fix is quite trivial: rename struct member to the
> expected name.
>
> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> ---
>  include/edid.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/edid.h b/include/edid.h
> index f153091..480a773 100644
> --- a/include/edid.h
> +++ b/include/edid.h
> @@ -54,7 +54,7 @@ struct edid_detailed_timing {
>          (_x).vertical_blanking)
>         unsigned char hsync_offset;
>         unsigned char hsync_pulse_width;
> -       unsigned char sync_offset_pulse_width;
> +       unsigned char vsync_offset_pulse_width;
>         unsigned char hsync_vsync_offset_pulse_width_hi;
>  #define EDID_DETAILED_TIMING_HSYNC_OFFSET(_x) \
>         ((GET_BITS((_x).hsync_vsync_offset_pulse_width_hi, 7, 6) << 8) + \
> --
> 1.7.10.4
>

ping
--
Christian Gmeiner, MSc
Anatolij Gustschin Aug. 12, 2013, 9:38 p.m. UTC | #2
On Wed,  7 Aug 2013 09:22:33 +0200
Christian Gmeiner <christian.gmeiner@gmail.com> wrote:

> Without this change EDID_DETAILED_TIMING_VSYNC_OFFSET
> and EDID_DETAILED_TIMING_VSYNC_PULSE_WIDTH macros can
> not be used (compile error).
> The fix is quite trivial: rename struct member to the
> expected name.
> 
> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> ---
>  include/edid.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to u-boot-video/master. Thanks!

Anatolij
diff mbox

Patch

diff --git a/include/edid.h b/include/edid.h
index f153091..480a773 100644
--- a/include/edid.h
+++ b/include/edid.h
@@ -54,7 +54,7 @@  struct edid_detailed_timing {
 	 (_x).vertical_blanking)
 	unsigned char hsync_offset;
 	unsigned char hsync_pulse_width;
-	unsigned char sync_offset_pulse_width;
+	unsigned char vsync_offset_pulse_width;
 	unsigned char hsync_vsync_offset_pulse_width_hi;
 #define EDID_DETAILED_TIMING_HSYNC_OFFSET(_x) \
 	((GET_BITS((_x).hsync_vsync_offset_pulse_width_hi, 7, 6) << 8) + \