From patchwork Wed Aug 7 06:47:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amerigo Wang X-Patchwork-Id: 265346 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3283E2C00ED for ; Wed, 7 Aug 2013 16:47:21 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757180Ab3HGGrR (ORCPT ); Wed, 7 Aug 2013 02:47:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61251 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755214Ab3HGGrR (ORCPT ); Wed, 7 Aug 2013 02:47:17 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r776lF8T009393 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 7 Aug 2013 02:47:16 -0400 Received: from [10.66.115.118] (vpn1-115-118.nay.redhat.com [10.66.115.118]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r776lBUw009813 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Wed, 7 Aug 2013 02:47:14 -0400 Message-ID: <1375858030.11370.25.camel@cr0> Subject: Re: A soft lockup in vxlan module From: Cong Wang To: Stephen Hemminger Cc: netdev@vger.kernel.org Date: Wed, 07 Aug 2013 14:47:10 +0800 In-Reply-To: <20130806211347.44c14755@nehalam.linuxnetplumber.net> References: <1375838634.11370.13.camel@cr0> <20130806211347.44c14755@nehalam.linuxnetplumber.net> Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 2013-08-06 at 21:13 -0700, Stephen Hemminger wrote: > > Probably the flush_workqueue can just be removed and let the normal > refcounting work. The workqueue has a reference to device and socket, > therefore the cleanups should work correctly. Sounds reasonable, I am testing the following patch: spin_unlock(&vn->sock_lock); --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 8bf31d9..c51ef9b 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -1837,8 +1837,6 @@ static void vxlan_dellink(struct net_device *dev, struct list_head *head) struct vxlan_net *vn = net_generic(dev_net(dev), vxlan_net_id); struct vxlan_dev *vxlan = netdev_priv(dev); - flush_workqueue(vxlan_wq); - spin_lock(&vn->sock_lock); hlist_del_rcu(&vxlan->hlist);