Patchwork [1/2] ide: palm_bk3710: add missing __iomem annotation

login
register
mail settings
Submitter Jingoo Han
Date Aug. 7, 2013, 5:17 a.m.
Message ID <002801ce932d$5ea499a0$1bedcce0$@samsung.com>
Download mbox | patch
Permalink /patch/265326/
State Accepted
Delegated to: David Miller
Headers show

Comments

Jingoo Han - Aug. 7, 2013, 5:17 a.m.
Added missing __iomem annotation in order to fix the following
sparse warnings:

drivers/ide/palm_bk3710.c:194:31: warning: incorrect type in initializer (different address spaces)
drivers/ide/palm_bk3710.c:194:31:    expected void [noderef] <asn:2>*base
drivers/ide/palm_bk3710.c:194:31:    got void *<noident>
drivers/ide/palm_bk3710.c:212:31: warning: incorrect type in initializer (different address spaces)
drivers/ide/palm_bk3710.c:212:31:    expected void [noderef] <asn:2>*base
drivers/ide/palm_bk3710.c:212:31:    got void *<noident>

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/ide/palm_bk3710.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
David Miller - Sept. 5, 2013, 7:38 p.m.
From: Jingoo Han <jg1.han@samsung.com>
Date: Wed, 07 Aug 2013 14:17:11 +0900

> Added missing __iomem annotation in order to fix the following
> sparse warnings:
> 
> drivers/ide/palm_bk3710.c:194:31: warning: incorrect type in initializer (different address spaces)
> drivers/ide/palm_bk3710.c:194:31:    expected void [noderef] <asn:2>*base
> drivers/ide/palm_bk3710.c:194:31:    got void *<noident>
> drivers/ide/palm_bk3710.c:212:31: warning: incorrect type in initializer (different address spaces)
> drivers/ide/palm_bk3710.c:212:31:    expected void [noderef] <asn:2>*base
> drivers/ide/palm_bk3710.c:212:31:    got void *<noident>
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ide/palm_bk3710.c b/drivers/ide/palm_bk3710.c
index 6107cc4..ba20d18 100644
--- a/drivers/ide/palm_bk3710.c
+++ b/drivers/ide/palm_bk3710.c
@@ -191,7 +191,7 @@  static void palm_bk3710_setpiomode(void __iomem *base, ide_drive_t *mate,
 static void palm_bk3710_set_dma_mode(ide_hwif_t *hwif, ide_drive_t *drive)
 {
 	int is_slave = drive->dn & 1;
-	void __iomem *base = (void *)hwif->dma_base;
+	void __iomem *base = (void __iomem *)hwif->dma_base;
 	const u8 xferspeed = drive->dma_mode;
 
 	if (xferspeed >= XFER_UDMA_0) {
@@ -209,7 +209,7 @@  static void palm_bk3710_set_pio_mode(ide_hwif_t *hwif, ide_drive_t *drive)
 	unsigned int cycle_time;
 	int is_slave = drive->dn & 1;
 	ide_drive_t *mate;
-	void __iomem *base = (void *)hwif->dma_base;
+	void __iomem *base = (void __iomem *)hwif->dma_base;
 	const u8 pio = drive->pio_mode - XFER_PIO_0;
 
 	/*