Patchwork Fix ARM uclibc build with !BR2_UCLIBC_ARM_BX.

login
register
mail settings
Submitter Justin Maggard
Date Aug. 6, 2013, 10:53 p.m.
Message ID <1375829638-7603-1-git-send-email-jmaggard10@gmail.com>
Download mbox | patch
Permalink /patch/265263/
State Accepted
Headers show

Comments

Justin Maggard - Aug. 6, 2013, 10:53 p.m.
When BR2_UCLIBC_ARM_BX is not set, UCLIBC_OPT_UNSET gets called with an extra
argument.  Remove it.

Signed-off-by: Justin Maggard <jmaggard10@gmail.com>
---
 package/uclibc/uclibc.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Thomas De Schampheleire - Aug. 7, 2013, 5:48 a.m.
On Wed, Aug 7, 2013 at 12:53 AM, Justin Maggard <jmaggard10@gmail.com> wrote:
> When BR2_UCLIBC_ARM_BX is not set, UCLIBC_OPT_UNSET gets called with an extra
> argument.  Remove it.
>
> Signed-off-by: Justin Maggard <jmaggard10@gmail.com>
> ---
>  package/uclibc/uclibc.mk |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk
> index 644c531..36a5001 100644
> --- a/package/uclibc/uclibc.mk
> +++ b/package/uclibc/uclibc.mk
> @@ -85,7 +85,7 @@ define UCLIBC_ARM_BX_CONFIG
>  endef
>  else
>  define UCLIBC_ARM_BX_CONFIG
> -       $(call UCLIBC_OPT_UNSET,USE_BX,y,$(@D))
> +       $(call UCLIBC_OPT_UNSET,USE_BX,$(@D))
>  endef
>  endif

Acked-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Thomas Petazzoni - Aug. 10, 2013, 7:29 p.m.
Dear Justin Maggard,

On Tue,  6 Aug 2013 15:53:58 -0700, Justin Maggard wrote:
> When BR2_UCLIBC_ARM_BX is not set, UCLIBC_OPT_UNSET gets called with an extra
> argument.  Remove it.
> 
> Signed-off-by: Justin Maggard <jmaggard10@gmail.com>

Committed, thanks.

Thomas

Patch

diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk
index 644c531..36a5001 100644
--- a/package/uclibc/uclibc.mk
+++ b/package/uclibc/uclibc.mk
@@ -85,7 +85,7 @@  define UCLIBC_ARM_BX_CONFIG
 endef
 else
 define UCLIBC_ARM_BX_CONFIG
-	$(call UCLIBC_OPT_UNSET,USE_BX,y,$(@D))
+	$(call UCLIBC_OPT_UNSET,USE_BX,$(@D))
 endef
 endif