From patchwork Mon Apr 27 22:20:51 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 26523 X-Patchwork-Delegate: grant.likely@secretlab.ca Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 8071DB707C for ; Tue, 28 Apr 2009 08:25:16 +1000 (EST) Received: by ozlabs.org (Postfix) id 994ADDE0DC; Tue, 28 Apr 2009 08:25:09 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 95F57DE0DB for ; Tue, 28 Apr 2009 08:25:09 +1000 (EST) X-Original-To: linuxppc-dev@ozlabs.org Delivered-To: linuxppc-dev@ozlabs.org Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "smtp.linux-foundation.org", Issuer "CA Cert Signing Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 222BBDDDA2 for ; Tue, 28 Apr 2009 08:24:50 +1000 (EST) Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n3RMKqLq028632 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 27 Apr 2009 15:21:28 -0700 Received: from akpm.mtv.corp.google.com (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with SMTP id n3RMKprQ008269; Mon, 27 Apr 2009 15:20:51 -0700 Date: Mon, 27 Apr 2009 15:20:51 -0700 From: Andrew Morton To: David Miller Subject: Re: "leds: Add openfirmware platform device support" breaks sparc Message-Id: <20090427152051.5067e888.akpm@linux-foundation.org> In-Reply-To: <20090303.163713.131742043.davem@davemloft.net> References: <20090303160906.9b30b376.akpm@linux-foundation.org> <20090303192932.31705cf7@lappy.seanm.ca> <20090303.163713.131742043.davem@davemloft.net> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 X-Spam-Status: No, hits=-2.974 required=5 tests=AWL,BAYES_00 X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Cc: sparclinux@vger.kernel.org, linuxppc-dev@ozlabs.org, rpurdie@linux.intel.com, tpiepho@freescale.com, smaclennan@pikatech.com X-BeenThere: linuxppc-dev@ozlabs.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org On Tue, 03 Mar 2009 16:37:13 -0800 (PST) David Miller wrote: > From: Sean MacLennan > Date: Tue, 3 Mar 2009 19:29:32 -0500 > > > It has been..... uhhhh carry the two... longer than I want to admit > > since I worked on a sparc. Would GPIO based LEDS make sense on a sparc > > platform? Is sparc used much in the embedded world? > > > > If yes, the of_register_platform_driver is just a nice wrapper. It > > would be trivial to either change it to work on sparc, or add the > > wrapper to the sparc includes. > > We generally create the platform devices by hand for LED > devices on sparc64. > > I'd CONFIG_POWERPC depend this thing for now. Nobody has done this, so current mainline's sparc64 allmodconfig remains busted. This? --- a/drivers/leds/Kconfig~a +++ a/drivers/leds/Kconfig @@ -139,6 +139,7 @@ config LEDS_GPIO_PLATFORM config LEDS_GPIO_OF bool "OpenFirmware platform device bindings for GPIO LEDs" depends on LEDS_GPIO && OF_DEVICE + depends on POWERPC default y help Let the leds-gpio driver drive LEDs which have been defined as