Patchwork "leds: Add openfirmware platform device support" breaks sparc

login
register
mail settings
Submitter Andrew Morton
Date April 27, 2009, 10:20 p.m.
Message ID <20090427152051.5067e888.akpm@linux-foundation.org>
Download mbox | patch
Permalink /patch/26523/
State Rejected
Delegated to: Grant Likely
Headers show

Comments

Andrew Morton - April 27, 2009, 10:20 p.m.
On Tue, 03 Mar 2009 16:37:13 -0800 (PST)
David Miller <davem@davemloft.net> wrote:

> From: Sean MacLennan <smaclennan@pikatech.com>
> Date: Tue, 3 Mar 2009 19:29:32 -0500
> 
> > It has been..... uhhhh carry the two... longer than I want to admit
> > since I worked on a sparc. Would GPIO based LEDS make sense on a sparc
> > platform? Is sparc used much in the embedded world?
> > 
> > If yes, the of_register_platform_driver is just a nice wrapper. It
> > would be trivial to either change it to work on sparc, or add the
> > wrapper to the sparc includes.
> 
> We generally create the platform devices by hand for LED
> devices on sparc64.
> 
> I'd CONFIG_POWERPC depend this thing for now.

Nobody has done this, so current mainline's sparc64 allmodconfig remains
busted.


This?

Patch

--- a/drivers/leds/Kconfig~a
+++ a/drivers/leds/Kconfig
@@ -139,6 +139,7 @@  config LEDS_GPIO_PLATFORM
 config LEDS_GPIO_OF
 	bool "OpenFirmware platform device bindings for GPIO LEDs"
 	depends on LEDS_GPIO && OF_DEVICE
+	depends on POWERPC
 	default y
 	help
 	  Let the leds-gpio driver drive LEDs which have been defined as