diff mbox

forcedeth: add clock gating feature

Message ID 49F5A5A7.4050609@nvidia.com
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

Ayaz Abdulla April 27, 2009, 12:31 p.m. UTC 
This patch adds support for clock gating the tx/rx engines which is 
available on certain chipsets.

Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>

Comments

Andrew Morton April 27, 2009, 7:24 p.m. UTC | #1 
On Mon, 27 Apr 2009 08:31:35 -0400
Ayaz Abdulla <aabdulla@nvidia.com> wrote:

> This patch adds support for clock gating the tx/rx engines which is 
> available on certain chipsets.

What are the effects of this patch?  Improved power management?  Fixes
a user-visible bug?  Something else?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Florian Fainelli April 28, 2009, 8:48 a.m. UTC | #2 
Hi,

Le Monday 27 April 2009 21:24:47 Andrew Morton, vous avez écrit :
> On Mon, 27 Apr 2009 08:31:35 -0400
>
> Ayaz Abdulla <aabdulla@nvidia.com> wrote:
> > This patch adds support for clock gating the tx/rx engines which is
> > available on certain chipsets.
>
> What are the effects of this patch?  Improved power management?  Fixes
> a user-visible bug?  Something else?

Clock gating is a design technique which improves power consumption by only 
clocking the necessary parts of the chip.

Ayaz do you have any figures on how this patch reduces consumption ?
Paulius Zaleckas April 28, 2009, 9:06 a.m. UTC | #3 
Ayaz Abdulla wrote:
> This patch adds support for clock gating the tx/rx engines which is
> available on certain chipsets.
> 
> Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
> 

Please inline patch. It is easier to write comments.

+		writel(powerstate,base + NvRegPowerState2);
                                 ^
                           put space here
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- old/drivers/net/forcedeth.c	2009-04-25 18:33:15.000000000 -0400
+++ new/drivers/net/forcedeth.c	2009-04-25 18:39:51.000000000 -0400
@@ -343,6 +343,7 @@ 
 #define NVREG_POWERSTATE2_POWERUP_MASK		0x0F15
 #define NVREG_POWERSTATE2_POWERUP_REV_A3	0x0001
 #define NVREG_POWERSTATE2_PHY_RESET		0x0004
+#define NVREG_POWERSTATE2_GATE_CLOCKS		0x0F00
 };
 
 /* Big endian: should work, but is untested */
@@ -1017,6 +1018,23 @@ 
 		return 1;
 }
 
+static void nv_txrx_gate(struct net_device *dev, bool gate)
+{
+	struct fe_priv *np = get_nvpriv(dev);
+	u8 __iomem *base = get_hwbase(dev);
+	u32 powerstate;
+
+	if (!np->mac_in_use &&
+	    (np->driver_data & DEV_HAS_POWER_CNTRL)) {
+		powerstate = readl(base + NvRegPowerState2);
+		if (gate)
+			powerstate |= NVREG_POWERSTATE2_GATE_CLOCKS;
+		else
+			powerstate &= ~NVREG_POWERSTATE2_GATE_CLOCKS;
+		writel(powerstate,base + NvRegPowerState2);
+	}
+}
+
 static void nv_enable_irq(struct net_device *dev)
 {
 	struct fe_priv *np = get_nvpriv(dev);
@@ -3394,12 +3412,14 @@ 
 		if (!netif_carrier_ok(dev)) {
 			netif_carrier_on(dev);
 			printk(KERN_INFO "%s: link up.\n", dev->name);
+			nv_txrx_gate(dev, false);
 			nv_start_rx(dev);
 		}
 	} else {
 		if (netif_carrier_ok(dev)) {
 			netif_carrier_off(dev);
 			printk(KERN_INFO "%s: link down.\n", dev->name);
+			nv_txrx_gate(dev, true);
 			nv_stop_rx(dev);
 		}
 	}
@@ -5327,6 +5347,7 @@ 
 	mii_rw(dev, np->phyaddr, MII_BMCR,
 	       mii_rw(dev, np->phyaddr, MII_BMCR, MII_READ) & ~BMCR_PDOWN);
 
+	nv_txrx_gate(dev, false);
 	/* erase previous misconfiguration */
 	if (np->driver_data & DEV_HAS_POWER_CNTRL)
 		nv_mac_reset(dev);
@@ -5514,12 +5535,14 @@ 
 	nv_drain_rxtx(dev);
 
 	if (np->wolenabled) {
+		nv_txrx_gate(dev, false);
 		writel(NVREG_PFF_ALWAYS|NVREG_PFF_MYADDR, base + NvRegPacketFilterFlags);
 		nv_start_rx(dev);
 	} else {
 		/* power down phy */
 		mii_rw(dev, np->phyaddr, MII_BMCR,
 		       mii_rw(dev, np->phyaddr, MII_BMCR, MII_READ)|BMCR_PDOWN);
+		nv_txrx_gate(dev, true);
 	}
 
 	/* FIXME: power down nic */