Patchwork [U-Boot] omap: emif: Set initial DDR PHY config first

login
register
mail settings
Submitter Taras Kondratiuk
Date Aug. 6, 2013, 1:16 p.m.
Message ID <1375795010-31786-1-git-send-email-taras@ti.com>
Download mbox | patch
Permalink /patch/265051/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Taras Kondratiuk - Aug. 6, 2013, 1:16 p.m.
Commit "OMAP5: emif/ddr: Change emif settings as required for ES1.0 silicon"
(f40107345cbcd6e0d1747eda45e76c4e2a6df0db)
changed sequence to set final DDR PHY config register value at the beginning.
Looks like it was made by mistake and should be reverted.

Signed-off-by: Taras Kondratiuk <taras@ti.com>
---
Based on v2013.07+ commit f53932a "dts/Makefile: pass -undef -D__DTS__ to cpp"

 arch/arm/cpu/armv7/omap-common/emif-common.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Tom Rini - Aug. 16, 2013, 1:36 p.m.
On Tue, Aug 06, 2013 at 04:16:50PM +0300, Taras Kondratiuk wrote:

> Commit "OMAP5: emif/ddr: Change emif settings as required for ES1.0 silicon"
> (f40107345cbcd6e0d1747eda45e76c4e2a6df0db)
> changed sequence to set final DDR PHY config register value at the beginning.
> Looks like it was made by mistake and should be reverted.
> 
> Signed-off-by: Taras Kondratiuk <taras@ti.com>

Applied to u-boot-ti/master, thanks!

Patch

diff --git a/arch/arm/cpu/armv7/omap-common/emif-common.c b/arch/arm/cpu/armv7/omap-common/emif-common.c
index ece3655..b0e1caa 100644
--- a/arch/arm/cpu/armv7/omap-common/emif-common.c
+++ b/arch/arm/cpu/armv7/omap-common/emif-common.c
@@ -153,7 +153,7 @@  static void lpddr2_init(u32 base, const struct emif_regs *regs)
 	 * un-locked frequency & default RL
 	 */
 	writel(regs->sdram_config_init, &emif->emif_sdram_config);
-	writel(regs->emif_ddr_phy_ctlr_1, &emif->emif_ddr_phy_ctrl_1);
+	writel(regs->emif_ddr_phy_ctlr_1_init, &emif->emif_ddr_phy_ctrl_1);
 
 	do_ext_phy_settings(base, regs);