Patchwork [U-Boot,u-boot,RFC,v1] sdp4430: Initialize board id using CONFIG_MACH_TYPE

login
register
mail settings
Submitter Oleksandr Tyshchenko
Date Aug. 6, 2013, 11:03 a.m.
Message ID <1375787007-15509-1-git-send-email-oleksandr.tyshchenko@ti.com>
Download mbox | patch
Permalink /patch/265020/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Oleksandr Tyshchenko - Aug. 6, 2013, 11:03 a.m.
Use CONFIG_MACH_TYPE generic macro to set the machine type
number in the common arm code instead of setting it in the
board code.

Signed-off-by: Oleksandr Tyshchenko <oleksandr.tyshchenko@ti.com>
---
 board/ti/sdp4430/sdp.c          |    1 -
 include/configs/omap4_sdp4430.h |    1 +
 2 files changed, 1 insertion(+), 1 deletion(-)
Tom Rini - Aug. 28, 2013, 6:25 p.m.
On Tue, Aug 06, 2013 at 02:03:27PM +0300, Oleksandr Tyshchenko wrote:

> Use CONFIG_MACH_TYPE generic macro to set the machine type
> number in the common arm code instead of setting it in the
> board code.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr.tyshchenko@ti.com>

Applied to u-boot-ti/master, thanks!
Albert ARIBAUD - Oct. 3, 2013, 9:15 p.m.
Hi Tom,

On Wed, 28 Aug 2013 14:25:25 -0400, Tom Rini <trini@ti.com> wrote:

> On Tue, Aug 06, 2013 at 02:03:27PM +0300, Oleksandr Tyshchenko wrote:
> 
> > Use CONFIG_MACH_TYPE generic macro to set the machine type
> > number in the common arm code instead of setting it in the
> > board code.
> > 
> > Signed-off-by: Oleksandr Tyshchenko <oleksandr.tyshchenko@ti.com>
> 
> Applied to u-boot-ti/master, thanks!

So it was not an RFC, then?

Amicalement,
Tom Rini - Oct. 3, 2013, 9:57 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/03/2013 05:15 PM, Albert ARIBAUD wrote:
> Hi Tom,
> 
> On Wed, 28 Aug 2013 14:25:25 -0400, Tom Rini <trini@ti.com> wrote:
> 
>> On Tue, Aug 06, 2013 at 02:03:27PM +0300, Oleksandr Tyshchenko 
>> wrote:
>> 
>>> Use CONFIG_MACH_TYPE generic macro to set the machine type 
>>> number in the common arm code instead of setting it in the 
>>> board code.
>>> 
>>> Signed-off-by: Oleksandr Tyshchenko 
>>> <oleksandr.tyshchenko@ti.com>
>> 
>> Applied to u-boot-ti/master, thanks!
> 
> So it was not an RFC, then?

Yes, there was nothing really RFC-worthy here, it was a small change.

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSTegtAAoJENk4IS6UOR1WAqYP/0khzMI3hCrC4T9C8Abyuw9o
XB3kH1pJ3mQCtoLP0jsPGeZP6dlDNQ9h50DXO46V1Juam/cPc7o2C3r/bYO7uwMx
/a9r4Z5TCQ7oPDsirMVvf5flTgPrY76Q8IK9diiv2N/OJzmIVjGfo2rMWjRRUBWP
48S/HlF+5jQNSUrqa5P8hx0NYuxv+3i0eoTM82zAF/kN4xPgVT+ThktGn8kmJZHz
EcHizUjXKSZwrqYC0735/PhIBjRefNgpcX0k6cnP0XcjT6N35f++Yvik8i1lLdBW
PMk2MO2Y1LGjK9OKh58oZQ6QicZmpkwii0fCE0rihXE1eJEw3glljVlityn4pVj0
1evZpqqXzsEg8XI0neAQwD2n98knzv64mR5Tp27m/sgkr5n38EK0YPVydcQAMyle
b2VIgO19h05GalTXC3itmcQmBq3ZL2PwW2UC/ZHTOyHLR8YuWwAax4SrvyTCfA8n
3hrPJ88bWEMaYgyeJFsfzjM80tTtW0347ZH9Zph1ymoVxMw9uQomn31C5hI7V95h
9bggRCH8XItynokq+qmOYVdFTAfuFYJUpUc6niHn+CzbM9o0EbwLBf5/U+2ij6PG
r4VJLCBgR2ow4p2ATfEae/1zZIm39ZeooI6FMXFOafKt3x9FZlBaUpJj14uO/tSc
lVoZngsvsXVGk5LkKb7I
=kq6T
-----END PGP SIGNATURE-----

Patch

diff --git a/board/ti/sdp4430/sdp.c b/board/ti/sdp4430/sdp.c
index 5dd1ba3..9f457e7 100644
--- a/board/ti/sdp4430/sdp.c
+++ b/board/ti/sdp4430/sdp.c
@@ -44,7 +44,6 @@  int board_init(void)
 {
 	gpmc_init();
 
-	gd->bd->bi_arch_number = MACH_TYPE_OMAP_4430SDP;
 	gd->bd->bi_boot_params = (0x80000000 + 0x100); /* boot param addr */
 
 	return 0;
diff --git a/include/configs/omap4_sdp4430.h b/include/configs/omap4_sdp4430.h
index 9e03291..9a4dea0 100644
--- a/include/configs/omap4_sdp4430.h
+++ b/include/configs/omap4_sdp4430.h
@@ -33,6 +33,7 @@ 
  * High Level Configuration Options
  */
 #define CONFIG_4430SDP		1	/* working with SDP */
+#define CONFIG_MACH_TYPE	MACH_TYPE_OMAP_4430SDP
 
 #include <configs/omap4_common.h>