Patchwork [U-Boot,RFC,06/10] icpdas lp8x4x: new USB hardware init interface

login
register
mail settings
Submitter Mateusz Zalega
Date Aug. 6, 2013, 10:50 a.m.
Message ID <1375786242-11734-7-git-send-email-m.zalega@samsung.com>
Download mbox | patch
Permalink /patch/265007/
State RFC
Headers show

Comments

Mateusz Zalega - Aug. 6, 2013, 10:50 a.m.
This commit changes name of an existing initialization function to
board_usb_init(), so that such functions could be reached by every
USB driver and command (ie. do_dfu()).

Signed-off-by: Mateusz Zalega <m.zalega@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Marek Vasut <marex@denx.de>
---
 board/icpdas/lp8x4x/lp8x4x.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Marek Vasut - Aug. 11, 2013, 6:07 p.m.
Dear Mateusz Zalega,

> This commit changes name of an existing initialization function to
> board_usb_init(), so that such functions could be reached by every
> USB driver and command (ie. do_dfu()).
> 
> Signed-off-by: Mateusz Zalega <m.zalega@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Marek Vasut <marex@denx.de>
> ---
>  board/icpdas/lp8x4x/lp8x4x.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Saw 03-06, OK.

> diff --git a/board/icpdas/lp8x4x/lp8x4x.c b/board/icpdas/lp8x4x/lp8x4x.c
> index 1b68ef3..54f8bba 100644
> --- a/board/icpdas/lp8x4x/lp8x4x.c
> +++ b/board/icpdas/lp8x4x/lp8x4x.c
> @@ -15,6 +15,7 @@
>  #include <netdev.h>
>  #include <serial.h>
>  #include <asm/io.h>
> +#include <usb.h>
> 
>  DECLARE_GLOBAL_DATA_PTR;
> 
> @@ -58,7 +59,7 @@ int board_mmc_init(bd_t *bis)
>  #endif
> 
>  #ifdef	CONFIG_CMD_USB
> -int usb_board_init(void)
> +int board_usb_init(enum board_usb_init_type what_to_init)
>  {
>  	writel((UHCHR | UHCHR_PCPL | UHCHR_PSPL) &
>  		~(UHCHR_SSEP0 | UHCHR_SSEP1 | UHCHR_SSEP2 | UHCHR_SSE),
> @@ -89,7 +90,7 @@ int usb_board_init(void)
>  	return 0;
>  }
> 
> -void usb_board_init_fail(void)
> +void board_usb_init_fail(void)
>  {
>  	return;
>  }

Best regards,
Marek Vasut

Patch

diff --git a/board/icpdas/lp8x4x/lp8x4x.c b/board/icpdas/lp8x4x/lp8x4x.c
index 1b68ef3..54f8bba 100644
--- a/board/icpdas/lp8x4x/lp8x4x.c
+++ b/board/icpdas/lp8x4x/lp8x4x.c
@@ -15,6 +15,7 @@ 
 #include <netdev.h>
 #include <serial.h>
 #include <asm/io.h>
+#include <usb.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
@@ -58,7 +59,7 @@  int board_mmc_init(bd_t *bis)
 #endif
 
 #ifdef	CONFIG_CMD_USB
-int usb_board_init(void)
+int board_usb_init(enum board_usb_init_type what_to_init)
 {
 	writel((UHCHR | UHCHR_PCPL | UHCHR_PSPL) &
 		~(UHCHR_SSEP0 | UHCHR_SSEP1 | UHCHR_SSEP2 | UHCHR_SSE),
@@ -89,7 +90,7 @@  int usb_board_init(void)
 	return 0;
 }
 
-void usb_board_init_fail(void)
+void board_usb_init_fail(void)
 {
 	return;
 }