Patchwork [3.5.y.z,extended,stable] Patch "arcnet: cleanup sizeof parameter" has been added to staging queue

mail settings
Submitter Luis Henriques
Date Aug. 6, 2013, 9:36 a.m.
Message ID <>
Download mbox | patch
Permalink /patch/264944/
State New
Headers show


Luis Henriques - Aug. 6, 2013, 9:36 a.m.
This is a note to let you know that I have just added a patch titled

    arcnet: cleanup sizeof parameter

to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
which can be found at:;a=shortlog;h=refs/heads/linux-3.5.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.y.z tree, see



From 0f9ab2d07a4d21b7a4b19fdcc60fde42ccafe515 Mon Sep 17 00:00:00 2001
From: Dan Carpenter <>
Date: Fri, 19 Jul 2013 08:48:05 +0300
Subject: [PATCH] arcnet: cleanup sizeof parameter

commit 087d273caf4f7d3f2159256f255f1f432bc84a5b upstream.

This patch doesn't change the compiled code because ARC_HDR_SIZE is 4
and sizeof(int) is 4, but the intent was to use the header size and not
the sizeof the header size.

Signed-off-by: Dan Carpenter <>
Signed-off-by: David S. Miller <>
Signed-off-by: Luis Henriques <>
 drivers/net/arcnet/arcnet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/drivers/net/arcnet/arcnet.c b/drivers/net/arcnet/arcnet.c
index a746ba2..a956053 100644
--- a/drivers/net/arcnet/arcnet.c
+++ b/drivers/net/arcnet/arcnet.c
@@ -1007,7 +1007,7 @@  static void arcnet_rx(struct net_device *dev, int bufnum)

 	soft = &pkt.soft.rfc1201;

-	lp->hw.copy_from_card(dev, bufnum, 0, &pkt, sizeof(ARC_HDR_SIZE));
+	lp->hw.copy_from_card(dev, bufnum, 0, &pkt, ARC_HDR_SIZE);
 	if (pkt.hard.offset[0]) {
 		ofs = pkt.hard.offset[0];
 		length = 256 - ofs;