Patchwork [1/2] Revert "kvm/ppc/booke64: Fix lazy ee handling in kvmppc_handle_exit()"

login
register
mail settings
Submitter Tiejun Chen
Date Aug. 6, 2013, 9:31 a.m.
Message ID <1375781469-27164-2-git-send-email-tiejun.chen@windriver.com>
Download mbox | patch
Permalink /patch/264940/
State New
Headers show

Comments

Tiejun Chen - Aug. 6, 2013, 9:31 a.m.
We should revert this commit to rework.

Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>
---
 arch/powerpc/kvm/booke.c |   11 -----------
 1 file changed, 11 deletions(-)
Scott Wood - Aug. 6, 2013, 8:50 p.m.
On Tue, 2013-08-06 at 17:31 +0800, Tiejun Chen wrote:
> We should revert this commit to rework.
> 
> Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>

This breaks bisect.

-Scott



--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tiejun Chen - Aug. 7, 2013, 1:58 a.m.
On 08/07/2013 04:50 AM, Scott Wood wrote:
> On Tue, 2013-08-06 at 17:31 +0800, Tiejun Chen wrote:
>> We should revert this commit to rework.
>>
>> Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>
>
> This breaks bisect.

Hmm...

Maybe I can squash these two patches into one.

Tiejun
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
index 17722d8..7653c9c 100644
--- a/arch/powerpc/kvm/booke.c
+++ b/arch/powerpc/kvm/booke.c
@@ -833,17 +833,6 @@  int kvmppc_handle_exit(struct kvm_run *run, struct kvm_vcpu *vcpu,
 	int s;
 	int idx;
 
-#ifdef CONFIG_PPC64
-	WARN_ON(local_paca->irq_happened != 0);
-#endif
-
-	/*
-	 * We enter with interrupts disabled in hardware, but
-	 * we need to call hard_irq_disable anyway to ensure that
-	 * the software state is kept in sync.
-	 */
-	hard_irq_disable();
-
 	/* update before a new last_exit_type is rewritten */
 	kvmppc_update_timing_stats(vcpu);