Patchwork syntaxcheck-0001: update test to keep in sync with fwts/ACPICA

login
register
mail settings
Submitter Keng-Yu Lin
Date Aug. 6, 2013, 8:36 a.m.
Message ID <1375778182-12837-1-git-send-email-kengyu@canonical.com>
Download mbox | patch
Permalink /patch/264914/
State Accepted
Headers show

Comments

Keng-Yu Lin - Aug. 6, 2013, 8:36 a.m.
New ACPICA disassembles with the line number shifted by one.

Signed-off-by: Keng-Yu Lin <kengyu@canonical.com>
---
 syntaxcheck-0001/syntaxcheck-0001.log | 48 +++++++++++++++++------------------
 1 file changed, 24 insertions(+), 24 deletions(-)
Colin King - Aug. 6, 2013, 8:38 a.m.
On 06/08/13 09:36, Keng-Yu Lin wrote:
> New ACPICA disassembles with the line number shifted by one.
>
> Signed-off-by: Keng-Yu Lin <kengyu@canonical.com>
> ---
>   syntaxcheck-0001/syntaxcheck-0001.log | 48 +++++++++++++++++------------------
>   1 file changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/syntaxcheck-0001/syntaxcheck-0001.log b/syntaxcheck-0001/syntaxcheck-0001.log
> index 80a7b80..43030de 100644
> --- a/syntaxcheck-0001/syntaxcheck-0001.log
> +++ b/syntaxcheck-0001/syntaxcheck-0001.log
> @@ -6,18 +6,18 @@ syntaxcheck
>   syntaxcheck     Checking ACPI table DSDT (#0)
>   syntaxcheck
>   syntaxcheck     FAILED [HIGH] AMLAsmASL_MSG_UPPER_CASE: Test 1, Assembler
> -syntaxcheck     error in line 709
> +syntaxcheck     error in line 710
>   syntaxcheck     Line | AML source
>   syntaxcheck     ----------------------------------------------------------
> -syntaxcheck     00706|     {
> -syntaxcheck     00707|         Device (AMW0)
> -syntaxcheck     00708|         {
> -syntaxcheck     00709|             Name (_HID, "pnp0c14")  // _HID: Hardware ID
> +syntaxcheck     00707|     {
> +syntaxcheck     00708|         Device (AMW0)
> +syntaxcheck     00709|         {
> +syntaxcheck     00710|             Name (_HID, "pnp0c14")  // _HID: Hardware ID
>   syntaxcheck          |                                ^
>   syntaxcheck          | Error 6136: Non-hex letters must be upper case    (pnp0c14)
> -syntaxcheck     00710|             Name (_UID, Zero)  // _UID: Unique ID
> -syntaxcheck     00711|             Name (_WDG, Buffer (0x3C)
> -syntaxcheck     00712|             {
> +syntaxcheck     00711|             Name (_UID, Zero)  // _UID: Unique ID
> +syntaxcheck     00712|             Name (_WDG, Buffer (0x3C)
> +syntaxcheck     00713|             {
>   syntaxcheck     ==========================================================
>   syntaxcheck
>   syntaxcheck     ADVICE: (for Error #6136, ASL_MSG_UPPER_CASE): Characters
> @@ -25,18 +25,18 @@ syntaxcheck     in literal string that are not hexadecimal letters must be
>   syntaxcheck     upper case.
>   syntaxcheck
>   syntaxcheck     FAILED [HIGH] AMLAsmASL_MSG_INVALID_ADDR_FLAGS: Test 1,
> -syntaxcheck     Assembler error in line 1069
> +syntaxcheck     Assembler error in line 1070
>   syntaxcheck     Line | AML source
>   syntaxcheck     ----------------------------------------------------------
> -syntaxcheck     01066|                     0x00000000,         // Range Minimum
> -syntaxcheck     01067|                     0xDFFFFFFF,         // Range Maximum
> -syntaxcheck     01068|                     0x00000000,         // Translation Offset
> -syntaxcheck     01069|                     0x00000000,         // Length
> +syntaxcheck     01067|                     0x00000000,         // Range Minimum
> +syntaxcheck     01068|                     0xDFFFFFFF,         // Range Maximum
> +syntaxcheck     01069|                     0x00000000,         // Translation Offset
> +syntaxcheck     01070|                     0x00000000,         // Length
>   syntaxcheck          |                             ^
>   syntaxcheck          | Error 6043: Invalid combination of Length and Min/Max fixed flags
> -syntaxcheck     01070|                     ,, _Y0D, AddressRangeMemory, TypeStatic)
> -syntaxcheck     01071|                 DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, Cacheable, ReadWrite,
> -syntaxcheck     01072|                     0x00000000,         // Granularity
> +syntaxcheck     01071|                     ,, _Y0D, AddressRangeMemory, TypeStatic)
> +syntaxcheck     01072|                 DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, Cacheable, ReadWrite,
> +syntaxcheck     01073|                     0x00000000,         // Granularity
>   syntaxcheck     ==========================================================
>   syntaxcheck
>   syntaxcheck     ADVICE: (for Error #6043, ASL_MSG_INVALID_ADDR_FLAGS):
> @@ -48,18 +48,18 @@ syntaxcheck     Address Space Resource Descriptors of the ACPI
>   syntaxcheck     specification for more details.
>   syntaxcheck
>   syntaxcheck     FAILED [HIGH] AMLAsmASL_MSG_INVALID_ADDR_FLAGS: Test 1,
> -syntaxcheck     Assembler error in line 1083
> +syntaxcheck     Assembler error in line 1084
>   syntaxcheck     Line | AML source
>   syntaxcheck     ----------------------------------------------------------
> -syntaxcheck     01080|                     0xFED40000,         // Range Minimum
> -syntaxcheck     01081|                     0xFED44FFF,         // Range Maximum
> -syntaxcheck     01082|                     0x00000000,         // Translation Offset
> -syntaxcheck     01083|                     0x00000000,         // Length
> +syntaxcheck     01081|                     0xFED40000,         // Range Minimum
> +syntaxcheck     01082|                     0xFED44FFF,         // Range Maximum
> +syntaxcheck     01083|                     0x00000000,         // Translation Offset
> +syntaxcheck     01084|                     0x00000000,         // Length
>   syntaxcheck          |                             ^
>   syntaxcheck          | Error 6043: Invalid combination of Length and Min/Max fixed flags
> -syntaxcheck     01084|                     ,, , AddressRangeMemory, TypeStatic)
> -syntaxcheck     01085|             })
> -syntaxcheck     01086|             Method (_CRS, 0, Serialized)  // _CRS: Current Resource Settings
> +syntaxcheck     01085|                     ,, , AddressRangeMemory, TypeStatic)
> +syntaxcheck     01086|             })
> +syntaxcheck     01087|             Method (_CRS, 0, Serialized)  // _CRS: Current Resource Settings
>   syntaxcheck     ==========================================================
>   syntaxcheck
>   syntaxcheck     ADVICE: (for Error #6043, ASL_MSG_INVALID_ADDR_FLAGS):
>
Acked-by: Colin Ian King <colin.king@canonical.com>
Ivan Hu - Aug. 6, 2013, 9:08 a.m.
On 08/06/2013 04:36 PM, Keng-Yu Lin wrote:
> New ACPICA disassembles with the line number shifted by one.
>
> Signed-off-by: Keng-Yu Lin <kengyu@canonical.com>
> ---
>   syntaxcheck-0001/syntaxcheck-0001.log | 48 +++++++++++++++++------------------
>   1 file changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/syntaxcheck-0001/syntaxcheck-0001.log b/syntaxcheck-0001/syntaxcheck-0001.log
> index 80a7b80..43030de 100644
> --- a/syntaxcheck-0001/syntaxcheck-0001.log
> +++ b/syntaxcheck-0001/syntaxcheck-0001.log
> @@ -6,18 +6,18 @@ syntaxcheck
>   syntaxcheck     Checking ACPI table DSDT (#0)
>   syntaxcheck
>   syntaxcheck     FAILED [HIGH] AMLAsmASL_MSG_UPPER_CASE: Test 1, Assembler
> -syntaxcheck     error in line 709
> +syntaxcheck     error in line 710
>   syntaxcheck     Line | AML source
>   syntaxcheck     ----------------------------------------------------------
> -syntaxcheck     00706|     {
> -syntaxcheck     00707|         Device (AMW0)
> -syntaxcheck     00708|         {
> -syntaxcheck     00709|             Name (_HID, "pnp0c14")  // _HID: Hardware ID
> +syntaxcheck     00707|     {
> +syntaxcheck     00708|         Device (AMW0)
> +syntaxcheck     00709|         {
> +syntaxcheck     00710|             Name (_HID, "pnp0c14")  // _HID: Hardware ID
>   syntaxcheck          |                                ^
>   syntaxcheck          | Error 6136: Non-hex letters must be upper case    (pnp0c14)
> -syntaxcheck     00710|             Name (_UID, Zero)  // _UID: Unique ID
> -syntaxcheck     00711|             Name (_WDG, Buffer (0x3C)
> -syntaxcheck     00712|             {
> +syntaxcheck     00711|             Name (_UID, Zero)  // _UID: Unique ID
> +syntaxcheck     00712|             Name (_WDG, Buffer (0x3C)
> +syntaxcheck     00713|             {
>   syntaxcheck     ==========================================================
>   syntaxcheck
>   syntaxcheck     ADVICE: (for Error #6136, ASL_MSG_UPPER_CASE): Characters
> @@ -25,18 +25,18 @@ syntaxcheck     in literal string that are not hexadecimal letters must be
>   syntaxcheck     upper case.
>   syntaxcheck
>   syntaxcheck     FAILED [HIGH] AMLAsmASL_MSG_INVALID_ADDR_FLAGS: Test 1,
> -syntaxcheck     Assembler error in line 1069
> +syntaxcheck     Assembler error in line 1070
>   syntaxcheck     Line | AML source
>   syntaxcheck     ----------------------------------------------------------
> -syntaxcheck     01066|                     0x00000000,         // Range Minimum
> -syntaxcheck     01067|                     0xDFFFFFFF,         // Range Maximum
> -syntaxcheck     01068|                     0x00000000,         // Translation Offset
> -syntaxcheck     01069|                     0x00000000,         // Length
> +syntaxcheck     01067|                     0x00000000,         // Range Minimum
> +syntaxcheck     01068|                     0xDFFFFFFF,         // Range Maximum
> +syntaxcheck     01069|                     0x00000000,         // Translation Offset
> +syntaxcheck     01070|                     0x00000000,         // Length
>   syntaxcheck          |                             ^
>   syntaxcheck          | Error 6043: Invalid combination of Length and Min/Max fixed flags
> -syntaxcheck     01070|                     ,, _Y0D, AddressRangeMemory, TypeStatic)
> -syntaxcheck     01071|                 DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, Cacheable, ReadWrite,
> -syntaxcheck     01072|                     0x00000000,         // Granularity
> +syntaxcheck     01071|                     ,, _Y0D, AddressRangeMemory, TypeStatic)
> +syntaxcheck     01072|                 DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, Cacheable, ReadWrite,
> +syntaxcheck     01073|                     0x00000000,         // Granularity
>   syntaxcheck     ==========================================================
>   syntaxcheck
>   syntaxcheck     ADVICE: (for Error #6043, ASL_MSG_INVALID_ADDR_FLAGS):
> @@ -48,18 +48,18 @@ syntaxcheck     Address Space Resource Descriptors of the ACPI
>   syntaxcheck     specification for more details.
>   syntaxcheck
>   syntaxcheck     FAILED [HIGH] AMLAsmASL_MSG_INVALID_ADDR_FLAGS: Test 1,
> -syntaxcheck     Assembler error in line 1083
> +syntaxcheck     Assembler error in line 1084
>   syntaxcheck     Line | AML source
>   syntaxcheck     ----------------------------------------------------------
> -syntaxcheck     01080|                     0xFED40000,         // Range Minimum
> -syntaxcheck     01081|                     0xFED44FFF,         // Range Maximum
> -syntaxcheck     01082|                     0x00000000,         // Translation Offset
> -syntaxcheck     01083|                     0x00000000,         // Length
> +syntaxcheck     01081|                     0xFED40000,         // Range Minimum
> +syntaxcheck     01082|                     0xFED44FFF,         // Range Maximum
> +syntaxcheck     01083|                     0x00000000,         // Translation Offset
> +syntaxcheck     01084|                     0x00000000,         // Length
>   syntaxcheck          |                             ^
>   syntaxcheck          | Error 6043: Invalid combination of Length and Min/Max fixed flags
> -syntaxcheck     01084|                     ,, , AddressRangeMemory, TypeStatic)
> -syntaxcheck     01085|             })
> -syntaxcheck     01086|             Method (_CRS, 0, Serialized)  // _CRS: Current Resource Settings
> +syntaxcheck     01085|                     ,, , AddressRangeMemory, TypeStatic)
> +syntaxcheck     01086|             })
> +syntaxcheck     01087|             Method (_CRS, 0, Serialized)  // _CRS: Current Resource Settings
>   syntaxcheck     ==========================================================
>   syntaxcheck
>   syntaxcheck     ADVICE: (for Error #6043, ASL_MSG_INVALID_ADDR_FLAGS):
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/syntaxcheck-0001/syntaxcheck-0001.log b/syntaxcheck-0001/syntaxcheck-0001.log
index 80a7b80..43030de 100644
--- a/syntaxcheck-0001/syntaxcheck-0001.log
+++ b/syntaxcheck-0001/syntaxcheck-0001.log
@@ -6,18 +6,18 @@  syntaxcheck
 syntaxcheck     Checking ACPI table DSDT (#0)
 syntaxcheck     
 syntaxcheck     FAILED [HIGH] AMLAsmASL_MSG_UPPER_CASE: Test 1, Assembler
-syntaxcheck     error in line 709
+syntaxcheck     error in line 710
 syntaxcheck     Line | AML source
 syntaxcheck     ----------------------------------------------------------
-syntaxcheck     00706|     {
-syntaxcheck     00707|         Device (AMW0)
-syntaxcheck     00708|         {
-syntaxcheck     00709|             Name (_HID, "pnp0c14")  // _HID: Hardware ID
+syntaxcheck     00707|     {
+syntaxcheck     00708|         Device (AMW0)
+syntaxcheck     00709|         {
+syntaxcheck     00710|             Name (_HID, "pnp0c14")  // _HID: Hardware ID
 syntaxcheck          |                                ^
 syntaxcheck          | Error 6136: Non-hex letters must be upper case    (pnp0c14)
-syntaxcheck     00710|             Name (_UID, Zero)  // _UID: Unique ID
-syntaxcheck     00711|             Name (_WDG, Buffer (0x3C)
-syntaxcheck     00712|             {
+syntaxcheck     00711|             Name (_UID, Zero)  // _UID: Unique ID
+syntaxcheck     00712|             Name (_WDG, Buffer (0x3C)
+syntaxcheck     00713|             {
 syntaxcheck     ==========================================================
 syntaxcheck     
 syntaxcheck     ADVICE: (for Error #6136, ASL_MSG_UPPER_CASE): Characters
@@ -25,18 +25,18 @@  syntaxcheck     in literal string that are not hexadecimal letters must be
 syntaxcheck     upper case.
 syntaxcheck     
 syntaxcheck     FAILED [HIGH] AMLAsmASL_MSG_INVALID_ADDR_FLAGS: Test 1,
-syntaxcheck     Assembler error in line 1069
+syntaxcheck     Assembler error in line 1070
 syntaxcheck     Line | AML source
 syntaxcheck     ----------------------------------------------------------
-syntaxcheck     01066|                     0x00000000,         // Range Minimum
-syntaxcheck     01067|                     0xDFFFFFFF,         // Range Maximum
-syntaxcheck     01068|                     0x00000000,         // Translation Offset
-syntaxcheck     01069|                     0x00000000,         // Length
+syntaxcheck     01067|                     0x00000000,         // Range Minimum
+syntaxcheck     01068|                     0xDFFFFFFF,         // Range Maximum
+syntaxcheck     01069|                     0x00000000,         // Translation Offset
+syntaxcheck     01070|                     0x00000000,         // Length
 syntaxcheck          |                             ^
 syntaxcheck          | Error 6043: Invalid combination of Length and Min/Max fixed flags
-syntaxcheck     01070|                     ,, _Y0D, AddressRangeMemory, TypeStatic)
-syntaxcheck     01071|                 DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, Cacheable, ReadWrite,
-syntaxcheck     01072|                     0x00000000,         // Granularity
+syntaxcheck     01071|                     ,, _Y0D, AddressRangeMemory, TypeStatic)
+syntaxcheck     01072|                 DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, Cacheable, ReadWrite,
+syntaxcheck     01073|                     0x00000000,         // Granularity
 syntaxcheck     ==========================================================
 syntaxcheck     
 syntaxcheck     ADVICE: (for Error #6043, ASL_MSG_INVALID_ADDR_FLAGS):
@@ -48,18 +48,18 @@  syntaxcheck     Address Space Resource Descriptors of the ACPI
 syntaxcheck     specification for more details.
 syntaxcheck     
 syntaxcheck     FAILED [HIGH] AMLAsmASL_MSG_INVALID_ADDR_FLAGS: Test 1,
-syntaxcheck     Assembler error in line 1083
+syntaxcheck     Assembler error in line 1084
 syntaxcheck     Line | AML source
 syntaxcheck     ----------------------------------------------------------
-syntaxcheck     01080|                     0xFED40000,         // Range Minimum
-syntaxcheck     01081|                     0xFED44FFF,         // Range Maximum
-syntaxcheck     01082|                     0x00000000,         // Translation Offset
-syntaxcheck     01083|                     0x00000000,         // Length
+syntaxcheck     01081|                     0xFED40000,         // Range Minimum
+syntaxcheck     01082|                     0xFED44FFF,         // Range Maximum
+syntaxcheck     01083|                     0x00000000,         // Translation Offset
+syntaxcheck     01084|                     0x00000000,         // Length
 syntaxcheck          |                             ^
 syntaxcheck          | Error 6043: Invalid combination of Length and Min/Max fixed flags
-syntaxcheck     01084|                     ,, , AddressRangeMemory, TypeStatic)
-syntaxcheck     01085|             })
-syntaxcheck     01086|             Method (_CRS, 0, Serialized)  // _CRS: Current Resource Settings
+syntaxcheck     01085|                     ,, , AddressRangeMemory, TypeStatic)
+syntaxcheck     01086|             })
+syntaxcheck     01087|             Method (_CRS, 0, Serialized)  // _CRS: Current Resource Settings
 syntaxcheck     ==========================================================
 syntaxcheck     
 syntaxcheck     ADVICE: (for Error #6043, ASL_MSG_INVALID_ADDR_FLAGS):