Patchwork [1/3] net: phy: micrel: Staticize ksz8873mll_read_status()

login
register
mail settings
Submitter Jingoo Han
Date Aug. 6, 2013, 8:29 a.m.
Message ID <000101ce927f$15413560$3fc3a020$@samsung.com>
Download mbox | patch
Permalink /patch/264907/
State Accepted
Delegated to: David Miller
Headers show

Comments

Jingoo Han - Aug. 6, 2013, 8:29 a.m.
ksz8873mll_read_status() is used only in this file.
Fix the following sparse warning:

drivers/net/phy/micrel.c:147:5: warning: symbol 'ksz8873mll_read_status' was not declared. Should it be static?

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/net/phy/micrel.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
David Miller - Aug. 7, 2013, 11:59 p.m.
From: Jingoo Han <jg1.han@samsung.com>
Date: Tue, 06 Aug 2013 17:29:35 +0900

> ksz8873mll_read_status() is used only in this file.
> Fix the following sparse warning:
> 
> drivers/net/phy/micrel.c:147:5: warning: symbol 'ksz8873mll_read_status' was not declared. Should it be static?
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 2510435..9ca4945 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -144,7 +144,7 @@  static int ks8051_config_init(struct phy_device *phydev)
 #define KSZ8873MLL_GLOBAL_CONTROL_4	0x06
 #define KSZ8873MLL_GLOBAL_CONTROL_4_DUPLEX	(1 << 6)
 #define KSZ8873MLL_GLOBAL_CONTROL_4_SPEED	(1 << 4)
-int ksz8873mll_read_status(struct phy_device *phydev)
+static int ksz8873mll_read_status(struct phy_device *phydev)
 {
 	int regval;