Patchwork [for-next,1/8] tcg-i386: Add and use tcg_out64

login
register
mail settings
Submitter Richard Henderson
Date Aug. 5, 2013, 6:07 p.m.
Message ID <1375726045-20797-2-git-send-email-rth@twiddle.net>
Download mbox | patch
Permalink /patch/264736/
State New
Headers show

Comments

Richard Henderson - Aug. 5, 2013, 6:07 p.m.
No point in splitting the write into 32-bit pieces.

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 tcg/i386/tcg-target.c | 3 +--
 tcg/tcg.c             | 6 ++++++
 2 files changed, 7 insertions(+), 2 deletions(-)
Aurelien Jarno - Aug. 15, 2013, 3:54 p.m.
On Mon, Aug 05, 2013 at 08:07:18AM -1000, Richard Henderson wrote:
> No point in splitting the write into 32-bit pieces.
> 
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  tcg/i386/tcg-target.c | 3 +--
>  tcg/tcg.c             | 6 ++++++
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
> index 87eeab3..841bd75 100644
> --- a/tcg/i386/tcg-target.c
> +++ b/tcg/i386/tcg-target.c
> @@ -552,8 +552,7 @@ static void tcg_out_movi(TCGContext *s, TCGType type,
>          tcg_out32(s, arg);
>      } else {
>          tcg_out_opc(s, OPC_MOVL_Iv + P_REXW + LOWREGMASK(ret), 0, ret, 0);
> -        tcg_out32(s, arg);
> -        tcg_out32(s, arg >> 31 >> 1);
> +        tcg_out64(s, arg);
>      }
>  }
>  
> diff --git a/tcg/tcg.c b/tcg/tcg.c
> index dac8224..9355b57 100644
> --- a/tcg/tcg.c
> +++ b/tcg/tcg.c
> @@ -131,6 +131,12 @@ static inline void tcg_out32(TCGContext *s, uint32_t v)
>      s->code_ptr += 4;
>  }
>  
> +static inline void tcg_out64(TCGContext *s, uint64_t v)
> +{
> +    *(uint64_t *)s->code_ptr = v;
> +    s->code_ptr += 8;
> +}
> +
>  /* label relocation processing */
>  
>  static void tcg_out_reloc(TCGContext *s, uint8_t *code_ptr, int type,

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

Patch

diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
index 87eeab3..841bd75 100644
--- a/tcg/i386/tcg-target.c
+++ b/tcg/i386/tcg-target.c
@@ -552,8 +552,7 @@  static void tcg_out_movi(TCGContext *s, TCGType type,
         tcg_out32(s, arg);
     } else {
         tcg_out_opc(s, OPC_MOVL_Iv + P_REXW + LOWREGMASK(ret), 0, ret, 0);
-        tcg_out32(s, arg);
-        tcg_out32(s, arg >> 31 >> 1);
+        tcg_out64(s, arg);
     }
 }
 
diff --git a/tcg/tcg.c b/tcg/tcg.c
index dac8224..9355b57 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -131,6 +131,12 @@  static inline void tcg_out32(TCGContext *s, uint32_t v)
     s->code_ptr += 4;
 }
 
+static inline void tcg_out64(TCGContext *s, uint64_t v)
+{
+    *(uint64_t *)s->code_ptr = v;
+    s->code_ptr += 8;
+}
+
 /* label relocation processing */
 
 static void tcg_out_reloc(TCGContext *s, uint8_t *code_ptr, int type,