Patchwork [for-1.6,v2,1/2] i82801b11: Fix i82801b11 PCI host bridge config space

login
register
mail settings
Submitter Andreas Färber
Date Aug. 5, 2013, 2:36 p.m.
Message ID <1375713401-24848-2-git-send-email-afaerber@suse.de>
Download mbox | patch
Permalink /patch/264697/
State New
Headers show

Comments

Andreas Färber - Aug. 5, 2013, 2:36 p.m.
From: Gerd Hoffmann <kraxel@redhat.com>

pci_bridge_write_config() was not being used.

Cc: qemu-stable@nongnu.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 hw/pci-bridge/i82801b11.c | 1 +
 1 file changed, 1 insertion(+)
Michael S. Tsirkin - Aug. 5, 2013, 3:37 p.m.
On Mon, Aug 05, 2013 at 04:36:40PM +0200, Andreas Färber wrote:
> From: Gerd Hoffmann <kraxel@redhat.com>
> 
> pci_bridge_write_config() was not being used.
> 
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/pci-bridge/i82801b11.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/pci-bridge/i82801b11.c b/hw/pci-bridge/i82801b11.c
> index 8a5e426..14cd7fd 100644
> --- a/hw/pci-bridge/i82801b11.c
> +++ b/hw/pci-bridge/i82801b11.c
> @@ -90,6 +90,7 @@ static void i82801b11_bridge_class_init(ObjectClass *klass, void *data)
>      k->device_id = PCI_DEVICE_ID_INTEL_82801BA_11;
>      k->revision = ICH9_D2P_A2_REVISION;
>      k->init = i82801b11_bridge_initfn;
> +    k->config_write = pci_bridge_write_config;
>      set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
>  }
>  
> -- 
> 1.8.1.4
Gerd Hoffmann - Aug. 12, 2013, 8:51 a.m.
On 08/05/13 16:36, Andreas Färber wrote:
> From: Gerd Hoffmann <kraxel@redhat.com>
> 
> pci_bridge_write_config() was not being used.
> 
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>

Ping?  I see it's not yet in master, can we *please* get this in?
It is save to take just this one-liner and defer 2/2 to 1.7.

cheers,
  Gerd
Andreas Färber - Aug. 12, 2013, 8:53 a.m.
Am 12.08.2013 10:51, schrieb Gerd Hoffmann:
> On 08/05/13 16:36, Andreas Färber wrote:
>> From: Gerd Hoffmann <kraxel@redhat.com>
>>
>> pci_bridge_write_config() was not being used.
>>
>> Cc: qemu-stable@nongnu.org
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
> 
> Ping?  I see it's not yet in master, can we *please* get this in?
> It is save to take just this one-liner and defer 2/2 to 1.7.

Michael, please decide as PCI maintainer and send a pull. Thanks!

Andreas

Patch

diff --git a/hw/pci-bridge/i82801b11.c b/hw/pci-bridge/i82801b11.c
index 8a5e426..14cd7fd 100644
--- a/hw/pci-bridge/i82801b11.c
+++ b/hw/pci-bridge/i82801b11.c
@@ -90,6 +90,7 @@  static void i82801b11_bridge_class_init(ObjectClass *klass, void *data)
     k->device_id = PCI_DEVICE_ID_INTEL_82801BA_11;
     k->revision = ICH9_D2P_A2_REVISION;
     k->init = i82801b11_bridge_initfn;
+    k->config_write = pci_bridge_write_config;
     set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
 }