Patchwork [for-1.6?,v2,18/21] shix: Drop debug output

login
register
mail settings
Submitter Andreas Färber
Date Aug. 5, 2013, 1:27 p.m.
Message ID <1375709247-10002-19-git-send-email-afaerber@suse.de>
Download mbox | patch
Permalink /patch/264685/
State New
Headers show

Comments

Andreas Färber - Aug. 5, 2013, 1:27 p.m.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 hw/sh4/shix.c | 7 -------
 1 file changed, 7 deletions(-)
Aurelien Jarno - Aug. 7, 2013, 10:13 a.m.
On Mon, Aug 05, 2013 at 03:27:24PM +0200, Andreas Färber wrote:
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  hw/sh4/shix.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/hw/sh4/shix.c b/hw/sh4/shix.c
> index 84dd666..66cbea4 100644
> --- a/hw/sh4/shix.c
> +++ b/hw/sh4/shix.c
> @@ -50,7 +50,6 @@ static void shix_init(QEMUMachineInitArgs *args)
>      if (!cpu_model)
>          cpu_model = "any";
>  
> -    printf("Initializing CPU\n");
>      cpu = cpu_sh4_init(cpu_model);
>      if (cpu == NULL) {
>          fprintf(stderr, "Unable to find CPU definition\n");
> @@ -58,16 +57,13 @@ static void shix_init(QEMUMachineInitArgs *args)
>      }
>  
>      /* Allocate memory space */
> -    printf("Allocating ROM\n");
>      memory_region_init_ram(rom, NULL, "shix.rom", 0x4000);
>      vmstate_register_ram_global(rom);
>      memory_region_set_readonly(rom, true);
>      memory_region_add_subregion(sysmem, 0x00000000, rom);
> -    printf("Allocating SDRAM 1\n");
>      memory_region_init_ram(&sdram[0], NULL, "shix.sdram1", 0x01000000);
>      vmstate_register_ram_global(&sdram[0]);
>      memory_region_add_subregion(sysmem, 0x08000000, &sdram[0]);
> -    printf("Allocating SDRAM 2\n");
>      memory_region_init_ram(&sdram[1], NULL, "shix.sdram2", 0x01000000);
>      vmstate_register_ram_global(&sdram[1]);
>      memory_region_add_subregion(sysmem, 0x0c000000, &sdram[1]);
> @@ -75,10 +71,8 @@ static void shix_init(QEMUMachineInitArgs *args)
>      /* Load BIOS in 0 (and access it through P2, 0xA0000000) */
>      if (bios_name == NULL)
>          bios_name = BIOS_FILENAME;
> -    printf("%s: load BIOS '%s'\n", __func__, bios_name);
>      ret = load_image_targphys(bios_name, 0, 0x4000);
>      if (ret < 0) {		/* Check bios size */
> -	fprintf(stderr, "ret=%d\n", ret);
>  	fprintf(stderr, "qemu: could not load SHIX bios '%s'\n",
>  		bios_name);
>  	exit(1);
> @@ -88,7 +82,6 @@ static void shix_init(QEMUMachineInitArgs *args)
>      s = sh7750_init(cpu, sysmem);
>      /* XXXXX Check success */
>      tc58128_init(s, "shix_linux_nand.bin", NULL);
> -    fprintf(stderr, "initialization terminated\n");
>  }
>  
>  static QEMUMachine shix_machine = {

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

Patch

diff --git a/hw/sh4/shix.c b/hw/sh4/shix.c
index 84dd666..66cbea4 100644
--- a/hw/sh4/shix.c
+++ b/hw/sh4/shix.c
@@ -50,7 +50,6 @@  static void shix_init(QEMUMachineInitArgs *args)
     if (!cpu_model)
         cpu_model = "any";
 
-    printf("Initializing CPU\n");
     cpu = cpu_sh4_init(cpu_model);
     if (cpu == NULL) {
         fprintf(stderr, "Unable to find CPU definition\n");
@@ -58,16 +57,13 @@  static void shix_init(QEMUMachineInitArgs *args)
     }
 
     /* Allocate memory space */
-    printf("Allocating ROM\n");
     memory_region_init_ram(rom, NULL, "shix.rom", 0x4000);
     vmstate_register_ram_global(rom);
     memory_region_set_readonly(rom, true);
     memory_region_add_subregion(sysmem, 0x00000000, rom);
-    printf("Allocating SDRAM 1\n");
     memory_region_init_ram(&sdram[0], NULL, "shix.sdram1", 0x01000000);
     vmstate_register_ram_global(&sdram[0]);
     memory_region_add_subregion(sysmem, 0x08000000, &sdram[0]);
-    printf("Allocating SDRAM 2\n");
     memory_region_init_ram(&sdram[1], NULL, "shix.sdram2", 0x01000000);
     vmstate_register_ram_global(&sdram[1]);
     memory_region_add_subregion(sysmem, 0x0c000000, &sdram[1]);
@@ -75,10 +71,8 @@  static void shix_init(QEMUMachineInitArgs *args)
     /* Load BIOS in 0 (and access it through P2, 0xA0000000) */
     if (bios_name == NULL)
         bios_name = BIOS_FILENAME;
-    printf("%s: load BIOS '%s'\n", __func__, bios_name);
     ret = load_image_targphys(bios_name, 0, 0x4000);
     if (ret < 0) {		/* Check bios size */
-	fprintf(stderr, "ret=%d\n", ret);
 	fprintf(stderr, "qemu: could not load SHIX bios '%s'\n",
 		bios_name);
 	exit(1);
@@ -88,7 +82,6 @@  static void shix_init(QEMUMachineInitArgs *args)
     s = sh7750_init(cpu, sysmem);
     /* XXXXX Check success */
     tc58128_init(s, "shix_linux_nand.bin", NULL);
-    fprintf(stderr, "initialization terminated\n");
 }
 
 static QEMUMachine shix_machine = {